Skip to content

Commit 4bef0ef

Browse files
committed
docs update, minor typos
1 parent caa216d commit 4bef0ef

File tree

4 files changed

+78
-6
lines changed

4 files changed

+78
-6
lines changed

README.md

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,33 @@ to avoid data losses when paginating (available starting from versions >= 1.4).
131131
* Type: any
132132
* Importance: low
133133

134+
135+
``es.tls.truststore.location``
136+
Elastic ssl truststore location
137+
138+
* Type: string
139+
* Importance: medium
140+
141+
``es.tls.truststore.password``
142+
Elastic ssl truststore password
143+
144+
* Type: string
145+
* Default: ""
146+
* Importance: medium
147+
148+
``es.tls.keystore.location``
149+
Elasticsearch keystore location
150+
151+
* Type: string
152+
* Importance: medium
153+
154+
``es.tls.keystore.password``
155+
Elasticsearch keystore password
156+
157+
* Type: string
158+
* Default: ""
159+
* Importance: medium
160+
134161
``connection.attempts``
135162
Maximum number of attempts to retrieve a valid Elasticsearch connection.
136163

doc/README.md

Lines changed: 45 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,13 +124,40 @@ The name of the strictly incrementing field to use to detect new records.
124124
* Importance: high
125125

126126
``incrementing.secondary.field.name``
127-
In case the main incrementing field may have duplicates,
128-
this secondary field is used as a secondary sort field in order
127+
In case the main incrementing field may have duplicates,
128+
this secondary field is used as a secondary sort field in order
129129
to avoid data losses when paginating (available starting from versions >= 1.4).
130130

131131
* Type: any
132132
* Importance: low
133133

134+
135+
``es.tls.truststore.location``
136+
Elastic ssl truststore location
137+
138+
* Type: string
139+
* Importance: medium
140+
141+
``es.tls.truststore.password``
142+
Elastic ssl truststore password
143+
144+
* Type: string
145+
* Default: ""
146+
* Importance: medium
147+
148+
``es.tls.keystore.location``
149+
Elasticsearch keystore location
150+
151+
* Type: string
152+
* Importance: medium
153+
154+
``es.tls.keystore.password``
155+
Elasticsearch keystore password
156+
157+
* Type: string
158+
* Default: ""
159+
* Importance: medium
160+
134161
``connection.attempts``
135162
Maximum number of attempts to retrieve a valid Elasticsearch connection.
136163

@@ -152,6 +179,13 @@ Indices prefix to include in copying.
152179
* Default: ""
153180
* Importance: medium
154181

182+
``index.names``
183+
List of elasticsearch indices: `es1,es2,es3`
184+
185+
* Type: string
186+
* Default: null
187+
* Importance: medium
188+
155189
### Connector Configuration
156190

157191
``poll.interval.ms``
@@ -183,6 +217,15 @@ nested fields. To provide multiple fields use `;` as separator
183217
* Importance: medium
184218
* Default: null
185219

220+
``filters.blacklist``
221+
Blacklist filter for extracting a subset of fields from elastic-search json documents. The blacklist filter supports
222+
nested fields. To provide multiple fields use `;` as separator
223+
(e.g. `customer;order.qty;order.price`).
224+
225+
* Type: string
226+
* Importance: medium
227+
* Default: null
228+
186229
``filters.json_cast``
187230
This filter casts nested fields to json string, avoiding parsing recursively as kafka connect-schema. The json-cast
188231
filter supports nested fields. To provide multiple fields use `;` as separator

src/main/java/com/github/dariobalinzo/ElasticSourceConnector.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ public void start(Map<String, String> props) {
7676

7777
String truststore = config.getString(ElasticSourceConnectorConfig.ES_TRUSTSTORE_CONF);
7878
String truststorePass = config.getString(ElasticSourceConnectorConfig.ES_TRUSTSTORE_PWD_CONF);
79-
String keystore = config.getString(ElasticSourceConnectorConfig.ES_TRUSTSTORE_CONF);
80-
String keystorePass = config.getString(ElasticSourceConnectorConfig.ES_TRUSTSTORE_PWD_CONF);
79+
String keystore = config.getString(ElasticSourceConnectorConfig.ES_KEYSTORE_CONF);
80+
String keystorePass = config.getString(ElasticSourceConnectorConfig.ES_KEYSTORE_PWD_CONF);
8181

8282
if (truststore != null) {
8383
connectionBuilder.withTrustStore(truststore, truststorePass);

src/main/java/com/github/dariobalinzo/task/ElasticSourceTask.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ public void start(Map<String, String> properties) {
9292

9393
topic = config.getString(ElasticSourceConnectorConfig.TOPIC_PREFIX_CONFIG);
9494
cursorField = config.getString(ElasticSourceConnectorConfig.INCREMENTING_FIELD_NAME_CONFIG);
95+
Objects.requireNonNull(cursorField, ElasticSourceConnectorConfig.INCREMENTING_FIELD_NAME_CONFIG
96+
+ " conf is mandatory");
9597
cursorFieldJsonName = removeKeywordSuffix(cursorField);
9698
secondaryCursorField = config.getString(ElasticSourceConnectorConfig.SECONDARY_INCREMENTING_FIELD_NAME_CONFIG);
9799
secondaryCursorFieldJsonName = removeKeywordSuffix(secondaryCursorField);
@@ -165,8 +167,8 @@ private void initEsConnection() {
165167

166168
String truststore = config.getString(ElasticSourceConnectorConfig.ES_TRUSTSTORE_CONF);
167169
String truststorePass = config.getString(ElasticSourceConnectorConfig.ES_TRUSTSTORE_PWD_CONF);
168-
String keystore = config.getString(ElasticSourceConnectorConfig.ES_TRUSTSTORE_CONF);
169-
String keystorePass = config.getString(ElasticSourceConnectorConfig.ES_TRUSTSTORE_PWD_CONF);
170+
String keystore = config.getString(ElasticSourceConnectorConfig.ES_KEYSTORE_CONF);
171+
String keystorePass = config.getString(ElasticSourceConnectorConfig.ES_KEYSTORE_PWD_CONF);
170172

171173
if (truststore != null) {
172174
connectionBuilder.withTrustStore(truststore, truststorePass);

0 commit comments

Comments
 (0)