Skip to content

Commit 7ee77b6

Browse files
committed
fix various pylint warnings
1 parent 0d092d7 commit 7ee77b6

5 files changed

Lines changed: 11 additions & 13 deletions

File tree

datalab/gui/processor/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1710,7 +1710,7 @@ def compute_n_to_1(
17101710
if dst_gid is not None:
17111711
self.panel.objview.set_current_item_id(dst_gid)
17121712

1713-
def compute_2_to_1(
1713+
def compute_2_to_1( # pylint: disable=too-many-return-statements
17141714
self,
17151715
obj2: SignalObj | ImageObj | list[SignalObj | ImageObj] | None,
17161716
obj2_name: str,

datalab/tests/features/common/creation_metadata_unit_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ def test_creation_parameters_use_versioned_envelope() -> None:
6161
assert payload["creation_params_version"] == CREATION_PARAMS_VERSION
6262
restored = extract_creation_parameters(obj)
6363
assert isinstance(restored, GaussParam)
64+
# pylint: disable-next=no-member # astroid cannot resolve the `create` TypeVar
6465
assert restored.amplitude == pytest.approx(param.amplitude)
6566

6667

datalab/tests/features/common/plot_results_app_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ def iterate_noisy_signals(
3838
param = sigima.objects.GaussParam.create(amplitude=a)
3939
for i in range(count):
4040
param.sigma = 1.0 + (i * 0.1) ** 2
41+
# pylint: disable-next=no-member # astroid cannot resolve the `create` TypeVar
4142
theoretical_fwhm = param.get_expected_features().fwhm
4243
sig = test_data.create_noisy_signal(
4344
noiseparam, param, f"Signal|fwhm_th={theoretical_fwhm:.2f}"

datalab/tests/features/signal/fitdialog_unit_test.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -81,21 +81,17 @@ def accept_initial_values(_x, _y, _fitfunc, fitparams, **_kwargs):
8181

8282

8383
NON_PEAK_FIT_CASES = (
84-
("linear", "noisy", lambda x, y: fdlg.linear_fit(x, y)),
84+
("linear", "noisy", fdlg.linear_fit),
8585
("polynomial", "noisy", lambda x, y: fdlg.polynomial_fit(x, y, 4)),
86-
("exponential", "noisy", lambda x, y: fdlg.exponential_fit(x, y)),
87-
("sinusoidal", "noisy", lambda x, y: fdlg.sinusoidal_fit(x, y)),
88-
("cdf", "noisy", lambda x, y: fdlg.cdf_fit(x, y)),
89-
("planckian", "gaussian_fit.txt", lambda x, y: fdlg.planckian_fit(x, y)),
90-
(
91-
"twohalfgaussian",
92-
"gaussian_fit.txt",
93-
lambda x, y: fdlg.twohalfgaussian_fit(x, y),
94-
),
86+
("exponential", "noisy", fdlg.exponential_fit),
87+
("sinusoidal", "noisy", fdlg.sinusoidal_fit),
88+
("cdf", "noisy", fdlg.cdf_fit),
89+
("planckian", "gaussian_fit.txt", fdlg.planckian_fit),
90+
("twohalfgaussian", "gaussian_fit.txt", fdlg.twohalfgaussian_fit),
9591
(
9692
"doubleexponential",
9793
"piecewiseexponential_fit.txt",
98-
lambda x, y: fdlg.piecewiseexponential_fit(x, y),
94+
fdlg.piecewiseexponential_fit,
9995
),
10096
)
10197

datalab/widgets/wizard.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ def cleanup(self) -> None:
157157
if callable(page_cleanup):
158158
page_cleanup()
159159

160-
def closeEvent(self, event: QG.QCloseEvent) -> None:
160+
def closeEvent(self, event: QG.QCloseEvent) -> None: # pylint: disable=invalid-name
161161
"""Release page resources when the dialog is closed"""
162162
self.cleanup()
163163
super().closeEvent(event)

0 commit comments

Comments
 (0)