From 7de3e3bb25f5f383eb74dfa801b0e547277c456c Mon Sep 17 00:00:00 2001 From: Ide Braakman Date: Thu, 11 Dec 2025 16:33:53 +0100 Subject: [PATCH 1/2] Issue #73: Translating a document with minification fails if the original file has no media --- src/DocumentMinifier.php | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/DocumentMinifier.php b/src/DocumentMinifier.php index bd33ea1..8171948 100644 --- a/src/DocumentMinifier.php +++ b/src/DocumentMinifier.php @@ -194,19 +194,21 @@ public function deminifyDocument( ): void { $extractedDocDirectory = $this->getExtractedDocDirectory(); $mediaDir = $this->getOriginalMediaDirectory(); - if (!mkdir($extractedDocDirectory)) { - throw new DocumentDeminificationException( - "Exception when deminifying, could not create directory at $extractedDocDirectory." + if (is_dir($mediaDir)) { + if (!mkdir($extractedDocDirectory)) { + throw new DocumentDeminificationException( + "Exception when deminifying, could not create directory at $extractedDocDirectory." + ); + } + + $this->extractZipTo($inputFilePath, $extractedDocDirectory, DocumentDeminificationException::class); + $this->replaceImagesInDir($extractedDocDirectory, $mediaDir); + $this->createZippedDocumentFromUnzippedDirectory( + $extractedDocDirectory, + $outputFilePath, + DocumentDeminificationException::class ); } - - $this->extractZipTo($inputFilePath, $extractedDocDirectory, DocumentDeminificationException::class); - $this->replaceImagesInDir($extractedDocDirectory, $mediaDir); - $this->createZippedDocumentFromUnzippedDirectory( - $extractedDocDirectory, - $outputFilePath, - DocumentDeminificationException::class - ); if ($cleanup) { $this->recursivelyDeleteDirectory($this->tempDir, DocumentDeminificationException::class); } From 11c341c3fc7044fc9344028ff9b1be37ccad43ab Mon Sep 17 00:00:00 2001 From: Ide Braakman Date: Thu, 11 Dec 2025 16:34:59 +0100 Subject: [PATCH 2/2] Fix indentation --- src/DocumentMinifier.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DocumentMinifier.php b/src/DocumentMinifier.php index 8171948..5efa73b 100644 --- a/src/DocumentMinifier.php +++ b/src/DocumentMinifier.php @@ -197,7 +197,7 @@ public function deminifyDocument( if (is_dir($mediaDir)) { if (!mkdir($extractedDocDirectory)) { throw new DocumentDeminificationException( - "Exception when deminifying, could not create directory at $extractedDocDirectory." + "Exception when deminifying, could not create directory at $extractedDocDirectory." ); }