Skip to content

fix(auth): show dembrane logo on unauthenticated pages instead of spinner#587

Merged
ussaama merged 1 commit into
mainfrom
fix/auth-logo-infinite-spinner
May 25, 2026
Merged

fix(auth): show dembrane logo on unauthenticated pages instead of spinner#587
ussaama merged 1 commit into
mainfrom
fix/auth-logo-infinite-spinner

Conversation

@ussaama
Copy link
Copy Markdown
Contributor

@ussaama ussaama commented May 25, 2026

WhitelabelLogoProvider initializes logoUrl to undefined and only gets
resolved by ParticipantHeader or useSidebarWhitelabelLogo — neither
mounts under AuthLayout. On a cold /login (initial visit or logout +
refresh), the value stayed undefined and LogoDembrane rendered its
forever.

Pass alwaysDembrane to the Logo in AuthLayout so the auth header
short-circuits whitelabel resolution and renders the dembrane logo
immediately. Workspace whitelabel behavior is unchanged — the sidebar
shell still resolves workspace.logo_url for authenticated routes.

Summary by CodeRabbit

  • Style
    • Updated logo display in authentication screens.

Review Change Stack

…nning

  WhitelabelLogoProvider initializes logoUrl to undefined and only gets
  resolved by ParticipantHeader or useSidebarWhitelabelLogo — neither
  mounts under AuthLayout. On a cold /login (initial visit or logout +
  refresh), the value stayed undefined and LogoDembrane rendered its
  <Loader> forever.

  Pass alwaysDembrane to the Logo in AuthLayout so the auth header
  short-circuits whitelabel resolution and renders the dembrane logo
  immediately. Workspace whitelabel behavior is unchanged — the sidebar
  shell still resolves workspace.logo_url for authenticated routes.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 52fd227f-71fa-4869-ba83-8b169d261d27

📥 Commits

Reviewing files that changed from the base of the PR and between 2eccbd7 and 356075e.

📒 Files selected for processing (1)
  • echo/frontend/src/components/layout/AuthLayout.tsx

Walkthrough

The AuthLayout component's header Logo rendering is updated to explicitly enable the alwaysDembrane prop, changing from an implicit default to an explicit alwaysDembrane={true} configuration.

Changes

Logo Dembrane branding

Layer / File(s) Summary
Logo alwaysDembrane prop
echo/frontend/src/components/layout/AuthLayout.tsx
The header Logo component now explicitly passes alwaysDembrane={true} to enforce consistent branding on the auth layout header.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: passing alwaysDembrane to Logo in AuthLayout to display the dembrane logo instead of an infinite spinner on unauthenticated pages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/auth-logo-infinite-spinner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ussaama ussaama requested a review from spashii May 25, 2026 15:58
@ussaama ussaama enabled auto-merge May 25, 2026 16:02
@ussaama ussaama disabled auto-merge May 25, 2026 16:06
@ussaama ussaama merged commit a288780 into main May 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant