From 041f140d90f2504e4f5967aee884a6a445f53b60 Mon Sep 17 00:00:00 2001 From: Hiran Wijesinghe Date: Mon, 24 Nov 2025 14:42:09 +0000 Subject: [PATCH 1/4] remove `CODECOV_TOKEN` --- .github/workflows/_test.yml | 5 ----- .github/workflows/ci.yml | 2 -- .../workflows/ci.yml.jinja" | 2 -- 3 files changed, 9 deletions(-) diff --git a/.github/workflows/_test.yml b/.github/workflows/_test.yml index 15c244ca..46cd49df 100644 --- a/.github/workflows/_test.yml +++ b/.github/workflows/_test.yml @@ -9,9 +9,6 @@ on: type: string description: The runner to run this job on required: true - secrets: - CODECOV_TOKEN: - required: true env: # https://github.com/pytest-dev/pytest/issues/2042 @@ -40,5 +37,3 @@ jobs: with: name: ${{ inputs.python-version }}/${{ inputs.runs-on }} files: cov.xml - env: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e3fc9c50..2ccb5691 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,8 +18,6 @@ jobs: uses: ./.github/workflows/_test.yml with: runs-on: ubuntu-latest - secrets: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} docs: uses: ./.github/workflows/_docs.yml diff --git "a/template/{% if git_platform==\"github.com\" %}.github{% endif %}/workflows/ci.yml.jinja" "b/template/{% if git_platform==\"github.com\" %}.github{% endif %}/workflows/ci.yml.jinja" index 5715df18..47c95c59 100644 --- "a/template/{% if git_platform==\"github.com\" %}.github{% endif %}/workflows/ci.yml.jinja" +++ "b/template/{% if git_platform==\"github.com\" %}.github{% endif %}/workflows/ci.yml.jinja" @@ -25,8 +25,6 @@ jobs: with: runs-on: ${{ matrix.runs-on }} python-version: ${{ matrix.python-version }} - secrets: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} {% endraw %}{% if docker %}{% raw %} container: needs: test From 691aa2d537251603093941a7ce4e345b202885b6 Mon Sep 17 00:00:00 2001 From: Hiran Wijesinghe Date: Mon, 24 Nov 2025 14:42:26 +0000 Subject: [PATCH 2/4] update docs --- docs/how-to/coverage.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/how-to/coverage.md b/docs/how-to/coverage.md index af43cf91..39f64dd9 100644 --- a/docs/how-to/coverage.md +++ b/docs/how-to/coverage.md @@ -17,6 +17,4 @@ If your repo is in an org where the codecov GitHub app is not installed, then fo ![Install Codecov](../images/gh-install-codecov.png) -Now you need to visit `https://app.codecov.io/account/gh//org-upload-token` to generate a token for your org, and store it as a secret named `CODECOV_TOKEN` in `https://github.com/organizations//settings/secrets/actions` - -Next time you create a pull request or merge to main, the code coverage will be uploaded, and the badge on the repository updated. +Next time you create a pull request or merge to main, the code coverage will be uploaded to `https://app.codecov.io/github/>/`, and the badge on the repository updated. From ad28ab2ee6368bf68398ee4f628604a0deb6a691 Mon Sep 17 00:00:00 2001 From: Hiran Wijesinghe Date: Mon, 24 Nov 2025 15:36:19 +0000 Subject: [PATCH 3/4] update docs as per CR --- docs/how-to/coverage.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/how-to/coverage.md b/docs/how-to/coverage.md index 39f64dd9..a4254285 100644 --- a/docs/how-to/coverage.md +++ b/docs/how-to/coverage.md @@ -6,7 +6,7 @@ Code coverage is reported to the command line and to a `cov.xml` file by the com (installing-codecov-github-app)= ## Installing Codecov GitHub app -If your repo is hosted in the DiamondLightSource org, then the codecov GitHub app is already installed and a global token stored so you don't need to do anything. +If your repo is hosted in the DiamondLightSource org, then the codecov GitHub app is already installed so you don't need to do anything. If your repo is in an org where the codecov GitHub app is not installed, then follow these steps to install it on the org: From 89429938e1ff58b861831adae7552fc32f5ae12e Mon Sep 17 00:00:00 2001 From: Hiran Wijesinghe Date: Mon, 24 Nov 2025 15:37:55 +0000 Subject: [PATCH 4/4] fix typo --- docs/how-to/coverage.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/how-to/coverage.md b/docs/how-to/coverage.md index a4254285..5df72641 100644 --- a/docs/how-to/coverage.md +++ b/docs/how-to/coverage.md @@ -17,4 +17,4 @@ If your repo is in an org where the codecov GitHub app is not installed, then fo ![Install Codecov](../images/gh-install-codecov.png) -Next time you create a pull request or merge to main, the code coverage will be uploaded to `https://app.codecov.io/github/>/`, and the badge on the repository updated. +Next time you create a pull request or merge to main, the code coverage will be uploaded to `https://app.codecov.io/github//`, and the badge on the repository updated.