Use typed properties where possible

Author: ksassnowski

src/Controllers/Api/FailedJobsController.php

@@ -2,10 +2,10 @@
 
 namespace Dionera\BeanstalkdUI\Controllers\Api;
 
-use DB;
-use Artisan;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Routing\Controller;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Artisan;
 
 class FailedJobsController extends Controller
 {

src/Controllers/Api/JobsController.php

@@ -3,16 +3,14 @@
 namespace Dionera\BeanstalkdUI\Controllers\Api;
 
 use Pheanstalk\JobId;
+use Illuminate\Http\JsonResponse;
 use Illuminate\Routing\Controller;
 use Pheanstalk\Exception\ServerException;
 use Pheanstalk\Contract\PheanstalkInterface;
 
 class JobsController extends Controller
 {
-    /**
-     * @var PheanstalkInterface
-     */
-    private $pheanstalk;
+    private PheanstalkInterface $pheanstalk;
 
     /**
      * JobsController constructor.
@@ -24,12 +22,7 @@ public function __construct(PheanstalkInterface $pheanstalk)
         $this->pheanstalk = $pheanstalk;
     }
 
-    /**
-     * @param $job
-     *
-     * @return \Illuminate\Http\JsonResponse
-     */
-    public function delete(int $job)
+    public function delete(int $job): JsonResponse
     {
         try {
             $instance = $this->pheanstalk->peek(new JobId($job));
@@ -48,12 +41,7 @@ public function delete(int $job)
         }
     }
 
-    /**
-     * @param $job
-     *
-     * @return \Illuminate\Http\RedirectResponse
-     */
-    public function kick(int $job)
+    public function kick(int $job): JsonResponse
     {
         try {
             $instance = $this->pheanstalk->peek(new JobId($job));

src/Controllers/Api/StatsController.php

@@ -9,14 +9,9 @@
 
 class StatsController extends Controller
 {
-    /**
-     * @var JobRepository
-     */
-    private $jobs;
-    /**
-     * @var PheanstalkInterface
-     */
-    private $pheanstalk;
+    private JobRepository $jobs;
+
+    private PheanstalkInterface $pheanstalk;
 
     public function __construct(PheanstalkInterface $pheanstalk, JobRepository $jobs)
     {

src/Models/Job.php

@@ -1,74 +1,38 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace Dionera\BeanstalkdUI\Models;
 
 use Illuminate\Support\Arr;
 use Pheanstalk\Job as PheanstalkJob;
 use Illuminate\Contracts\Support\Jsonable;
+use Pheanstalk\Contract\ResponseInterface;
 
 class Job implements Jsonable
 {
-    /**
-     * @var PheanstalkJob
-     */
-    private $job;
+    private PheanstalkJob $job;
+    private ?ResponseInterface $stats;
 
-    /**
-     * @var object
-     */
-    private $stats;
-
-    /**
-     * Job constructor.
-     *
-     * @param PheanstalkJob $job
-     * @param object        $stats
-     */
-    public function __construct(PheanstalkJob $job, $stats = null)
+    public function __construct(PheanstalkJob $job, ?ResponseInterface $stats = null)
     {
         $this->job = $job;
         $this->stats = $stats;
     }
 
-    /**
-     * Returns the underlying job's id.
-     *
-     * @return int
-     */
-    public function getId()
+    public function getId(): int
     {
         return $this->job->getId();
     }
 
-    /**
-     * Returns the underlying job's data.
-     *
-     * @return string
-     */
-    public function getData()
+    public function getData(): string
     {
         return $this->job->getData();
     }
 
-    /**
-     * Returns a specific stat for the underlying job.
-     *
-     * @param string $name
-     *
-     * @return mixed
-     */
-    public function getStat($name)
+    public function getStat(string $name)
     {
         return Arr::get($this->stats, $name);
     }
 
-    /**
-     * Convert the object to its JSON representation.
-     *
-     * @param int $options
-     *
-     * @return string
-     */
     public function toJson($options = 0)
     {
         return [

src/Repositories/JobRepository.php

@@ -10,8 +10,7 @@
 
 class JobRepository
 {
-    /** @var PheanstalkInterface */
-    private $pheanstalk;
+    private PheanstalkInterface $pheanstalk;
 
     public function __construct(PheanstalkInterface $pheanstalk)
     {