Add dynamic versioning #381
Merged
+110
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional for workflow_dispatch
enable last tag
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces dynamic versioning to the DoubleML package using setuptools-scm, which automatically determines version numbers from Git tags instead of requiring manual version updates in the codebase. The changes improve the deployment workflow by adding verification steps for both TestPyPI and PyPI releases.
Key changes:
- Migrates from hardcoded version strings to setuptools-scm for automatic version management from Git tags
- Adds comprehensive version fallback logic with test coverage
- Enhances CI/CD with verification steps after publishing to TestPyPI and PyPI
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Configures setuptools-scm for dynamic versioning and updates build dependencies |
| doubleml/init.py | Implements version import logic with fallback chain (_version.py → importlib.metadata → "0.0.0+unknown") |
| doubleml/tests/test_init.py | Adds comprehensive tests for version retrieval and fallback scenarios |
| doc/conf.py | Updates documentation to use dynamic version from doubleml.version |
| .gitignore | Excludes auto-generated _version.py file |
| .github/workflows/pytest.yml | Sets fetch-depth: 0 to enable setuptools-scm version detection |
| .github/workflows/deploy_pkg.yml | Adds workflow_dispatch trigger, verification jobs for TestPyPI/PyPI, and proper fetch-depth configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The main changes include switching to setuptools-scm for automatic version management, updating the deployment and verification steps in GitHub Actions, and ensuring documentation and package metadata reflect the new versioning approach.