get back the old hyper parameters and set some non-zero trimming threshold

Author: MalteKurz

tests/testthat/helper-05-ml-learner.R

@@ -178,8 +178,8 @@ get_default_mlmethod_irm = function(learner) {
       mlmethod_g = paste0("regr.", learner))
 
     params = list(
-      params_g = list(cp = 0.02, minsplit = 20),
-      params_m = list(cp = 0.02, minsplit = 20))
+      params_g = list(cp = 0.01, minsplit = 20),
+      params_m = list(cp = 0.01, minsplit = 20))
 
   }
   ml_g = mlr3::lrn(mlmethod$mlmethod_g)
@@ -214,9 +214,9 @@ get_default_mlmethod_iivm = function(learner) {
       mlmethod_r = paste0("classif.", learner))
 
     params = list(
-      params_m = list(cp = 0.02, minsplit = 20),
-      params_g = list(cp = 0.02, minsplit = 20),
-      params_r = list(cp = 0.02, minsplit = 20))
+      params_m = list(cp = 0.01, minsplit = 20),
+      params_g = list(cp = 0.01, minsplit = 20),
+      params_r = list(cp = 0.01, minsplit = 20))
 
   }
   ml_g = mlr3::lrn(mlmethod$mlmethod_g)

tests/testthat/test-double_ml_iivm.R

@@ -10,14 +10,14 @@ if (on_cran) {
     learner = "rpart",
     dml_procedure = "dml2",
     score = "LATE",
-    trimming_threshold = c(0),
+    trimming_threshold = c(0.0001),
     stringsAsFactors = FALSE)
 } else {
   test_cases = expand.grid(
     learner = "cv_glmnet",
     dml_procedure = c("dml1", "dml2"),
     score = "LATE",
-    trimming_threshold = c(0),
+    trimming_threshold = c(0.0001),
     stringsAsFactors = FALSE)
 }
 

tests/testthat/test-double_ml_irm_user_score.R

@@ -25,15 +25,15 @@ if (on_cran) {
     learner = "regr.rpart",
     learner_m = "classif.rpart",
     dml_procedure = "dml2",
-    trimming_threshold = 0,
+    trimming_threshold = 0.0001,
     stringsAsFactors = FALSE)
   test_cases[".test_name"] = apply(test_cases, 1, paste, collapse = "_")
 } else {
   test_cases = expand.grid(
     learner = "regr.glmnet",
     learner_m = "classif.glmnet",
     dml_procedure = c("dml1", "dml2"),
-    trimming_threshold = c(0, 0.01),
+    trimming_threshold = c(0.0001, 0.01),
     stringsAsFactors = FALSE)
   test_cases[".test_name"] = apply(test_cases, 1, paste, collapse = "_")
 }