Skip to content

Commit 5e04379

Browse files
authored
Merge pull request #129 from DoubleML/m-fix128
rename test_name to .test_name to fix #128
2 parents 9c36b6b + 00f9c4a commit 5e04379

40 files changed

+50
-50
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Suggests:
4242
rmarkdown,
4343
testthat,
4444
covr,
45-
patrick,
45+
patrick (>= 0.1.0),
4646
paradox (>= 0.4.0),
4747
dplyr,
4848
glmnet,

tests/testthat/test-double_ml_datasets.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ test_cases = expand.grid(
88
instrument = c(TRUE, FALSE),
99
stringsAsFactors = FALSE)
1010

11-
test_cases["test_name"] = apply(test_cases, 1, paste, collapse = "_")
11+
test_cases[".test_name"] = apply(test_cases, 1, paste, collapse = "_")
1212

1313
testthat::skip_on_cran()
1414
patrick::with_parameters_test_that("Unit tests for datasets functionalities:",

tests/testthat/test-double_ml_iivm.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ if (on_cran) {
2121
stringsAsFactors = FALSE)
2222
}
2323

24-
test_cases["test_name"] = apply(test_cases, 1, paste, collapse = "_")
24+
test_cases[".test_name"] = apply(test_cases, 1, paste, collapse = "_")
2525

2626
patrick::with_parameters_test_that("Unit tests for IIVM:",
2727
.cases = test_cases, {

tests/testthat/test-double_ml_iivm_parameter_passing.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ test_cases_nocf = expand.grid(
2626
trimming_threshold = 1e-5,
2727
stringsAsFactors = FALSE)
2828

29-
test_cases["test_name"] = apply(test_cases, 1, paste, collapse = "_")
30-
test_cases_nocf["test_name"] = apply(test_cases_nocf, 1, paste, collapse = "_")
29+
test_cases[".test_name"] = apply(test_cases, 1, paste, collapse = "_")
30+
test_cases_nocf[".test_name"] = apply(test_cases_nocf, 1, paste, collapse = "_")
3131

3232
patrick::with_parameters_test_that("Unit tests for parameter passing of IIVM (oop vs fun):",
3333
.cases = test_cases, {

tests/testthat/test-double_ml_iivm_trim.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ if (on_cran) {
2020
trimming_threshold = c(1e-12, 0.05),
2121
stringsAsFactors = FALSE)
2222
}
23-
test_cases["test_name"] = apply(test_cases, 1, paste, collapse = "_")
23+
test_cases[".test_name"] = apply(test_cases, 1, paste, collapse = "_")
2424

2525
patrick::with_parameters_test_that("Unit tests for IIVM:",
2626
.cases = test_cases, {

tests/testthat/test-double_ml_iivm_tuning.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ if (on_cran) {
4141
}
4242

4343

44-
test_cases["test_name"] = apply(test_cases, 1, paste, collapse = "_")
44+
test_cases[".test_name"] = apply(test_cases, 1, paste, collapse = "_")
4545

4646
patrick::with_parameters_test_that("Unit tests for tuning of IIVM:",
4747
.cases = test_cases, {

tests/testthat/test-double_ml_iivm_user_score.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ if (on_cran) {
3737
stringsAsFactors = FALSE)
3838
}
3939

40-
test_cases["test_name"] = apply(test_cases, 1, paste, collapse = "_")
40+
test_cases[".test_name"] = apply(test_cases, 1, paste, collapse = "_")
4141

4242
patrick::with_parameters_test_that("Unit tests for IIVM, callable score:",
4343
.cases = test_cases, {

tests/testthat/test-double_ml_irm.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ if (on_cran) {
1212
score = "ATTE",
1313
trimming_threshold = 0,
1414
stringsAsFactors = FALSE)
15-
test_cases["test_name"] = apply(test_cases, 1, paste, collapse = "_")
15+
test_cases[".test_name"] = apply(test_cases, 1, paste, collapse = "_")
1616
} else {
1717
test_cases = expand.grid(
1818
learner = "cv_glmnet",
1919
dml_procedure = c("dml1", "dml2"),
2020
score = c("ATE", "ATTE"),
2121
trimming_threshold = 0,
2222
stringsAsFactors = FALSE)
23-
test_cases["test_name"] = apply(test_cases, 1, paste, collapse = "_")
23+
test_cases[".test_name"] = apply(test_cases, 1, paste, collapse = "_")
2424
}
2525

2626
patrick::with_parameters_test_that("Unit tests for IRM:",

tests/testthat/test-double_ml_irm_loaded_mlr3learner.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ if (on_cran) {
1818
trimming_threshold = 0,
1919
stringsAsFactors = FALSE)
2020
}
21-
test_cases["test_name"] = apply(test_cases, 1, paste, collapse = "_")
21+
test_cases[".test_name"] = apply(test_cases, 1, paste, collapse = "_")
2222

2323
patrick::with_parameters_test_that("Unit tests for IRM:",
2424
.cases = test_cases, {

tests/testthat/test-double_ml_irm_parameter_passing.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ test_cases_nocf = expand.grid(
2626
trimming_threshold = 1e-5,
2727
stringsAsFactors = FALSE)
2828

29-
test_cases["test_name"] = apply(test_cases, 1, paste, collapse = "_")
30-
test_cases_nocf["test_name"] = apply(test_cases_nocf, 1, paste, collapse = "_")
29+
test_cases[".test_name"] = apply(test_cases, 1, paste, collapse = "_")
30+
test_cases_nocf[".test_name"] = apply(test_cases_nocf, 1, paste, collapse = "_")
3131

3232
patrick::with_parameters_test_that("Unit tests for parameter passing of IRM (oop vs fun):",
3333
.cases = test_cases, {

0 commit comments

Comments
 (0)