Create Makefile

[Rangak]

Create top level (and if necessary sub-directory) Makefiles to build, clean etc and replace the shell scripts such as build.sh etc.

[emanchado]

@paulfurley are you going to do the rest of this ticket? It looks like it should be relatively easy for a newcomer, so if you're not going to finish this off I was thinking of trying my luck with it :-)

[fawkesley]

Please go ahead - I'm away for a bit so don't wait for me :)

—
Sent from mobile

On Sat, Aug 23, 2014 at 9:55 PM, Esteban Manchado Velázquez
notifications@github.com wrote:

@paulfurley are you going to do the rest of this ticket? It looks like it should be relatively easy for a newcomer, so if you're not going to finish this off I was thinking of trying my luck with it :-)

Reply to this email directly or view it on GitHub:
#227 (comment)

[emanchado]

I just had a moment and had a look at it. I have two questions:

1. Do we have an ETA for the installation of handlebars on the build server? It would be nice to remove the current code for checking that templates.js is updated.

2. Why Makefile? It seems we're using Grunt to run the tests. If we're depending on it anyway, why not use it for everything (I have never used it, so I don't know if it's a good idea)?

[jsha]

Regarding Grunt vs Makefile: We already depend on both tools for a full build, since building the Cerowrt base system uses Make. I think it's reasonable to have our top-level build command be Make, and continue to use grunt for the frontend Javascript tests, since that tool is more likely to be familiar to Javascript engineers.

[jsha]

Regarding ETA for handlebars on build server: Unfortunately it's blocked on some other tasks and I think it could be a couple of months, but @Rangak can answer better.

[Rangak]

On (1) no ETA as the new build server setup will take some time.
On (2) Makefile is not for running tests it is to build the router image. Makefiles are
standard use in Linux and OpenWRT and we want to continue with that for compatibility.

[emanchado]

@jsha OK, Makefile it is, then.

@Rangak oh, I assumed that once we moved to Makefile, we would turn everything possible to it (I, for one, am used to running tests with "make test", and I would definitely expect that over ./run-tests.sh if I knew there is a Makefile).

If we're not going to run the tests with make, what's missing? The description says "shell scripts such as build.sh etc.", but removing the tests-running scripts only leaves install-dev-dependencies.sh. Is that really the only other thing left to move?

[Rangak]

Sorry I should have been clearer. We can have a target 'test' so tests are run with 'make test'. No problem with that. My concern was more with building the images, which is what I had in mind when I wrote up this issue. Thanks for taking this on. Much appreciated.

[emanchado]

I think I might be done. You guys can have a look at https://github.com/emanchado/OpenWireless/tree/227-makefile. Or should I just file a pull request?

[fawkesley]

Nice one! Pull request might be easier to track comments etc?

On Monday Sep 1, 2014 at 21:13, Esteban Manchado Velázquez , wrote:

I think I might be done. You guys can have a look at https://github.com/emanchado/OpenWireless/tree/227-makefile. Or should I just file a pull request?

---

Reply to this email directly or view it on GitHub:
#227 (comment)