Fix render.yml: configure branch name, use correct boolean type for inputs

Author: climbfuji

.github/workflows/pull_request_ci.yml

@@ -57,6 +57,7 @@ jobs:
     uses: ./.github/workflows/render.yml
     with:
       commit_to_branch: false
+      branch_name: ${{ github.event_name == "pull_request" && github.head_ref || github.ref_name }}
     #runs-on: ubuntu-latest
     #steps:
     #  - name: Checkout repository

.github/workflows/pull_request_precommit.yml

@@ -1,7 +1,7 @@
 name: Pull request precommit tasks
 
 on:
-  workflow_dispatch:
+  #workflow_dispatch:
   pull_request:
     branches:
       - main
@@ -16,6 +16,8 @@ jobs:
     uses: ./.github/workflows/render.yml
     with:
       commit_to_branch: true
+      branch_name: ${{ github.head_ref }} # ${{ github.event_name == "pull_request" && github.head_ref || github.ref_name }}
+
     #runs-on: ubuntu-latest
     #steps:
     #  - name: Checkout repository

.github/workflows/render.yml

@@ -1,59 +1,57 @@
-name: Render XML to output formats and optionally commit to branch
-
-on:
-  workflow_call:
-    inputs:
-      commit_to_branch:
-        required: true
-        type: string
-
-#env:
-#  #COMMIT_TO_BRANCH: ${{ inputs.commit_to_branch }}
-
-jobs:
-
-  render_to_markdown_and_yaml:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
-      - name: Setup Python
-        uses: actions/setup-python@v4
-        with:
-          python-version: "3.x"
-
-      - name: Install dependencies
-        run: |
-          sudo apt-get update
-          sudo apt-get -y install libxml2-utils
-          python -m pip install --upgrade pip
-          python -m pip install PyYaml
-
-      - name: Render xml file to markdown
-        run: |
-          tools/write_standard_name_table.py --output-format md standard_names.xml
-          echo "The following changes will be committed when this pull request is merged (git diff Metadata-standard-names.md; "
-          echo "assuming that 'Metadata-standard-names.md' wasn't updated and matches the version in the authoritative branch):"
-          git diff Metadata-standard-names.md
-
-      - name: Rendering xml file to yaml
-        run: |
-          tools/write_standard_name_table.py --output-format yaml standard_names.xml
-          echo "The following changes will be committed when this pull request is merged (git diff Metadata-standard-names.yaml; "
-          echo "assuming that 'Metadata-standard-names.yaml' wasn't updated and matches the version in the authoritative branch):"
-          git diff Metadata-standard-names.yaml
-
-      - name: Configure git
-        if: ${{ inputs.commit_to_branch }}
-        run: |
-          git config --global user.name "github-actions[bot]"
-          git config --global user.email "github-actions[bot]@users.noreply.github.com"
-
-      - name: Commit and push changes
-        if: ${{ inputs.commit_to_branch }}
-        run: |
-          git commit -m "Update Metadata-standard-names.{md,yaml} from standard_names.xml" || echo "No changes to commit"
-          git push
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+name: Render XML to output formats and optionally commit to branch
+
+on:
+  workflow_call:
+    inputs:
+      commit_to_branch:
+        required: true
+        type: boolean
+      branch_name:
+        required: true
+        type: string
+      
+jobs:
+
+  render_to_markdown_and_yaml:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Setup Python
+        uses: actions/setup-python@v4
+        with:
+          python-version: "3.x"
+
+      - name: Install dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get -y install libxml2-utils
+          python -m pip install --upgrade pip
+          python -m pip install PyYaml
+
+      - name: Render xml file to markdown
+        run: |
+          tools/write_standard_name_table.py --output-format md standard_names.xml
+          echo "The following changes will be committed when this pull request is merged (git diff Metadata-standard-names.md; "
+          echo "assuming that 'Metadata-standard-names.md' wasn't updated and matches the version in the authoritative branch):"
+          git diff Metadata-standard-names.md
+
+      - name: Rendering xml file to yaml
+        run: |
+          tools/write_standard_name_table.py --output-format yaml standard_names.xml
+          echo "The following changes will be committed when this pull request is merged (git diff Metadata-standard-names.yaml; "
+          echo "assuming that 'Metadata-standard-names.yaml' wasn't updated and matches the version in the authoritative branch):"
+          git diff Metadata-standard-names.yaml
+
+      - name: Configure git, commit and push changes
+        if: ${{ inputs.commit_to_branch }}
+        run: |
+          git config --global user.name "github-actions[bot]"
+          git config --global user.email "github-actions[bot]@users.noreply.github.com"
+          git checkout -b ${{ inputs.branch_name }}
+          git commit -m "Update Metadata-standard-names.{md,yaml} from standard_names.xml" || echo "No changes to commit"
+          git push
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          #BRANCH_NAME: ${{ github.event_name == "pull_request" && github.head_ref || github.ref_name }}