changing basis_params dictionary param

Author: jngaravitoc

CHANGELOG.md

@@ -0,0 +1,15 @@
+# Changelog
+
+## [0.2.2] – 2025-12-24
+
+### Added
+- Docstrings in basis module
+- Support to build cylindrical basis
+
+### Changed
+- Rename basis_build folder to match pyEXP naming convention
+- Basis module was refactor
+
+### Fixed
+- A typo in make_model was fixed
+- Prevented log10 of zero in density smoothing

EXPtools/basis/basis_utils.py

@@ -174,7 +174,7 @@ def write_config(basis_params):
 
     return yaml.dump(config_dict, sort_keys=False)
 
-def make_basis(R, D, Mtotal, **basis_params):
+def make_basis(R, D, Mtotal, basis_params, physical_units=True):
     """
     Construct a basis from a given radial density profile.
 
@@ -188,6 +188,9 @@ def make_basis(R, D, Mtotal, **basis_params):
         Total mass normalization (default is 1.0).
     basis_params : dict 
         basis parameters e.g., basis_id, nmax, lmax
+        For the descriptions of the basis_params please see the EXP description:
+        https://github.com/EXP-code/EXP-docs/blob/93207da758d34cf10092650a840cdb23180b859a/topics/yamlconfig.rst#L229
+
 
     Returns
     -------
@@ -200,6 +203,11 @@ def make_basis(R, D, Mtotal, **basis_params):
       the supplied density profile and total mass.
     - It then builds a basis either spherical (`sphereSL`) or cylindrical using `EXPtools.make_config`
       and returns the corresponding `pyEXP` basis object.
+    
+    TODO:
+    -----
+     - check cache values are consitent with basis_params
+     - informce float for rmapping
     """
 
     if "modelname" not in basis_params.keys():
@@ -208,13 +216,15 @@ def make_basis(R, D, Mtotal, **basis_params):
     if "cachename" not in basis_params.keys():
         basis_params['cachename']="test_cache.txt"
 
-    R, D, _, _ = make_model(
+    _ = make_model(
         R, D, Mtotal=Mtotal, 
-        output_filename=basis_params['modelname']
+        output_filename=basis_params['modelname'], 
+        physical_units=physical_units
     )
 
 
+
     config = write_config(basis_params)
 
     basis = pyEXP.basis.Basis.factory(config)
-    return basis
+    return basis

EXPtools/ios/ios.py

@@ -6,14 +6,10 @@
 read AGAMA coefficients into EXP
 """
 
-import os
+
 import numpy as np
-from pytest import approx
 import pyEXP
-from EXPtools.basis_builder.basis_utils import make_config
-
-DATAPATH = "../../tests/data/"
-
+from EXPtools.basis.basis_utils import make_config
 
 def exp_coefficients(coeffile, config, **kwargs):
     """
@@ -42,38 +38,5 @@ def exp_coefficients(coeffile, config, **kwargs):
     coefs = pyEXP.coefs.Coefs.factory(coeffile)
     return basis, coefs
 
-## tests
-
-def _exp_coefficients():
-    """
-    Test 
-    """
-    coeftest = os.path.join(DATAPATH, "spherical_hernquist_halo_coef.h5")
-    config = make_config('sphereSL', numr=51, rmin=0.02,
-                        rmax=1.9799999999999995, lmax=5, nmax=10, scale=1,
-                        modelname=DATAPATH+'SLGrid.empirical_spherical_hernquist_halo',
-                        cachename=DATAPATH+".slgrid_spherical_hernquist_halo")
-    basis, coefs = exp_coefficients(coeftest, config)
-
-    basis_density = np.log10(basis.getBasis()[0][0]['density'].flatten()[0::20])
-    basis_true = np.array([2.52452473, 2.52007596,  2.51333528, 2.50305991,
-                           2.4872475, 2.46254365, 2.42296872, 2.35670352,
-                           2.23560574, 2.02788039, 1.82455463, 1.61151223,
-                           1.38374334,  1.13708294, 0.86224642, 0.55234052,
-                           0.19739773, -0.20560017, -0.66084427, -1.1953064 ])
-
-
-    assert basis_density == approx(basis_true)
 
-    assert coefs.getAllCoefs().shape == approx((21, 10, 1))
-
-    first_coefs = np.array([1.58866402e+00, 1.61446863e-02, -1.21213618e-03,
-                            1.94620389e-03, 8.00640342e-04, -9.05078238e-04,
-                            -1.89598446e-03, -8.74281279e-04, 1.00354378e-03,
-                            4.03461871e-04])
-
-    assert coefs.getAllCoefs()[0].real.flatten() == approx(first_coefs)
-    return basis, coefs
 
-if __name__ == "__main__":
-    _exp_coefficients()