Merge pull request #51 from EbenezerGH/class-visibility-performance-test

EbenezerGH · web-flow · commit 3fa258ca5248 · 2018-04-12T17:46:29.000-07:00
modify access visibilities
diff --git a/etherscanapi/src/main/java/jfyg/account/AccountContract.kt b/etherscanapi/src/main/java/jfyg/account/AccountContract.kt
@@ -5,7 +5,7 @@ import jfyg.model.Blocks
 import jfyg.model.Transactions
 import jfyg.model.TransactionsInternal
 
-interface AccountContract {
+internal interface AccountContract {
 
     /**
      * Return network status
diff --git a/etherscanapi/src/main/java/jfyg/network/NetworkService.kt b/etherscanapi/src/main/java/jfyg/network/NetworkService.kt
@@ -14,7 +14,7 @@ import retrofit2.http.Query
 /**
  * Etherscan request endpoints
  */
-interface NetworkService {
+internal interface NetworkService {
 
     @GET("api")
     fun getStat(@Query("module") module: String?,
diff --git a/etherscanapi/src/main/java/jfyg/network/RestClient.kt b/etherscanapi/src/main/java/jfyg/network/RestClient.kt
@@ -9,7 +9,7 @@ import io.reactivex.schedulers.Schedulers
 /**
  * Client used to create the network call
  */
-class RestClient {
+internal class RestClient {
 
     private var baseUrl: String = "http://api.etherscan.io/"
     private var networkService: NetworkService
diff --git a/etherscanapi/src/main/java/jfyg/queries/AccountQueries.kt b/etherscanapi/src/main/java/jfyg/queries/AccountQueries.kt
@@ -7,7 +7,7 @@ import jfyg.response.account.AccountInternalTransactionResponse
 import jfyg.response.account.AccountMultiBalanceResponse
 import jfyg.response.account.AccountTransactionResponse
 
-interface AccountQueries {
+internal interface AccountQueries {
 
     /**
      * Get Ether balance for a single address
diff --git a/etherscanapi/src/main/java/jfyg/queries/QueryMediator.kt b/etherscanapi/src/main/java/jfyg/queries/QueryMediator.kt
@@ -16,7 +16,7 @@ import jfyg.response.stat.StatSupplyResponse
 /**
  * A mediator between the responses and errors that come from every query
  */
-class QueryMediator : AccountQueries, StatQueries { //todo #36
+internal class QueryMediator : AccountQueries, StatQueries { //todo #36
     private val TAG = javaClass.name
 
     private var statPriceInfo = StatPriceResponse()
diff --git a/etherscanapi/src/main/java/jfyg/queries/StatQueries.kt b/etherscanapi/src/main/java/jfyg/queries/StatQueries.kt
@@ -4,7 +4,7 @@ import io.reactivex.disposables.Disposable
 import jfyg.response.stat.StatPriceResponse
 import jfyg.response.stat.StatSupplyResponse
 
-interface StatQueries {
+internal interface StatQueries {
 
     /**
      * Get Ether last price
diff --git a/etherscanapi/src/main/java/jfyg/response/BaseResponse.kt b/etherscanapi/src/main/java/jfyg/response/BaseResponse.kt
@@ -3,7 +3,7 @@ package jfyg.response
 /**
  * Base response that all queries will utilize
  */
-open class BaseResponse {
+internal open class BaseResponse {
 
     var status: String? = null
 
diff --git a/etherscanapi/src/main/java/jfyg/response/account/AccountBalanceResponse.kt b/etherscanapi/src/main/java/jfyg/response/account/AccountBalanceResponse.kt
@@ -5,4 +5,4 @@ import jfyg.response.BaseResponse
 /**
  * Balance of Ether existing in an account
  */
-data class AccountBalanceResponse(var result: String? = null) : BaseResponse()
+internal data class AccountBalanceResponse(var result: String? = null) : BaseResponse()
diff --git a/etherscanapi/src/main/java/jfyg/response/account/AccountBlockResponse.kt b/etherscanapi/src/main/java/jfyg/response/account/AccountBlockResponse.kt
@@ -6,4 +6,4 @@ import jfyg.response.BaseResponse
 /**
  * Blocks mined by an account
  */
-data class AccountBlockResponse(var result: ArrayList<Blocks>? = null) : BaseResponse()
+internal data class AccountBlockResponse(var result: ArrayList<Blocks>? = null) : BaseResponse()
diff --git a/etherscanapi/src/main/java/jfyg/response/account/AccountInternalTransactionResponse.kt b/etherscanapi/src/main/java/jfyg/response/account/AccountInternalTransactionResponse.kt
@@ -6,5 +6,4 @@ import jfyg.response.BaseResponse
 /**
  * Internal Transactions recorded by an account
  */
-class AccountInternalTransactionResponse(var result: ArrayList<TransactionsInternal>? = null) : BaseResponse() {
-}
+internal class AccountInternalTransactionResponse(var result: ArrayList<TransactionsInternal>? = null) : BaseResponse()
diff --git a/etherscanapi/src/main/java/jfyg/response/account/AccountMultiBalanceResponse.kt b/etherscanapi/src/main/java/jfyg/response/account/AccountMultiBalanceResponse.kt
@@ -5,4 +5,4 @@ import jfyg.model.Balances
 /**
  * Balances of multiple accounts
  */
-data class AccountMultiBalanceResponse(var result: ArrayList<Balances>? = null)
+internal data class AccountMultiBalanceResponse(var result: ArrayList<Balances>? = null)
diff --git a/etherscanapi/src/main/java/jfyg/response/account/AccountTransactionResponse.kt b/etherscanapi/src/main/java/jfyg/response/account/AccountTransactionResponse.kt
@@ -6,4 +6,4 @@ import jfyg.response.BaseResponse
 /**
  * Transactions recorded by an account
  */
-data class AccountTransactionResponse(var result: ArrayList<Transactions>? = null) : BaseResponse()
+internal data class AccountTransactionResponse(var result: ArrayList<Transactions>? = null) : BaseResponse()
diff --git a/etherscanapi/src/main/java/jfyg/response/stat/StatPriceResponse.kt b/etherscanapi/src/main/java/jfyg/response/stat/StatPriceResponse.kt
@@ -6,4 +6,4 @@ import jfyg.response.BaseResponse
 /**
  * Responses for Stat
  */
-data class StatPriceResponse(var result: StatPrice? = null) : BaseResponse()
+internal data class StatPriceResponse(var result: StatPrice? = null) : BaseResponse()
diff --git a/etherscanapi/src/main/java/jfyg/response/stat/StatSupplyResponse.kt b/etherscanapi/src/main/java/jfyg/response/stat/StatSupplyResponse.kt
@@ -3,4 +3,4 @@ package jfyg.response.stat
 /**
  * Response for total supply of Ether
  */
-data class StatSupplyResponse(var result: String? = null)
+internal data class StatSupplyResponse(var result: String? = null)
diff --git a/etherscanapi/src/main/java/jfyg/stat/StatContract.kt b/etherscanapi/src/main/java/jfyg/stat/StatContract.kt
@@ -1,6 +1,6 @@
 package jfyg.stat
 
-interface StatContract {
+internal interface StatContract {
 
     /**
      * Return total supply of Ether
diff --git a/etherscanapi/src/main/java/jfyg/utils/QueryUtils.kt b/etherscanapi/src/main/java/jfyg/utils/QueryUtils.kt
@@ -3,7 +3,7 @@ package jfyg.utils
 /**
  * Utilities that may be used to provide successful Queries
  */
-class QueryUtils {
+internal class QueryUtils {
 
     fun retrieveAccounts(accounts: ArrayList<String>?): String {
 
diff --git a/etherscanapi/src/test/java/jfyg/account/AccountTest.kt b/etherscanapi/src/test/java/jfyg/account/AccountTest.kt
@@ -13,7 +13,7 @@ import org.junit.Assert
 import org.junit.Before
 import org.junit.Test
 
-class AccountTest {
+internal class AccountTest {
     lateinit var gson: Gson
 
     private val accountBalance = """
diff --git a/etherscanapi/src/test/java/jfyg/network/RestClientTest.kt b/etherscanapi/src/test/java/jfyg/network/RestClientTest.kt
@@ -16,7 +16,7 @@ import retrofit2.adapter.rxjava2.RxJava2CallAdapterFactory
 import retrofit2.converter.gson.GsonConverterFactory
 
 @RunWith(JUnit4::class)
-class RestClientTest {
+internal class RestClientTest {
     private var baseUrl: String = "http://api.etherscan.io/"
     private lateinit var mockWebServer: MockWebServer
 
diff --git a/etherscanapi/src/test/java/jfyg/queries/QueryMediatorTest.kt b/etherscanapi/src/test/java/jfyg/queries/QueryMediatorTest.kt
@@ -2,7 +2,7 @@ package jfyg.queries
 
 import org.junit.Test
 
-class QueryMediatorTest {
+internal class QueryMediatorTest {
     @Test
     fun accountBalance() {
     }
diff --git a/etherscanapi/src/test/java/jfyg/stat/StatTest.kt b/etherscanapi/src/test/java/jfyg/stat/StatTest.kt
@@ -9,7 +9,7 @@ import org.junit.Before
 import org.junit.Test
 import org.junit.Assert.assertEquals
 
-class StatTest {
+internal class StatTest {
     lateinit var gson: Gson
 
     private val inputSupply = """
diff --git a/etherscanapi/src/test/java/jfyg/utils/QueryUtilsTest.kt b/etherscanapi/src/test/java/jfyg/utils/QueryUtilsTest.kt
@@ -3,7 +3,7 @@ package jfyg.utils
 import org.junit.Assert
 import org.junit.Test
 
-class QueryUtilsTest {
+internal class QueryUtilsTest {
 
     @Test
     fun retrieveAccounts() {
