Skip to content

Commit fe089ad

Browse files
authored
feat: implement atan(y, x) with atan2 (#1927)
* atan2 * test
1 parent b016c87 commit fe089ad

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

src/TracedRNumber.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -533,6 +533,7 @@ Base.asind(x::TracedRNumber) = rad2deg(asin(x))
533533
Base.acosd(x::TracedRNumber) = rad2deg(acos(x))
534534
Base.atand(x::TracedRNumber) = rad2deg(atan(x))
535535

536+
Base.atan(y::TracedRNumber, x::TracedRNumber) = @opcall atan2(y, x)
536537
Base.atand(y::TracedRNumber, x::TracedRNumber) = rad2deg(atan(y, x))
537538

538539
Base.acscd(x::TracedRNumber) = rad2deg(asin(1 / x))

test/basic.jl

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -770,6 +770,14 @@ end
770770
@test @jit(fn.(xrad_ra)) isa ConcreteRArray{Float32,2}
771771
end
772772

773+
yrad = Reactant.TestUtils.construct_test_array(Float32, 4, 16)[:, 3:9]
774+
yrad_ra = Reactant.to_rarray(yrad)
775+
776+
@testset for fn in (atan, atand)
777+
@test @jit(fn.(yrad_ra, xrad_ra)) fn.(yrad, xrad)
778+
@test @jit(fn.(yrad_ra, xrad_ra)) isa ConcreteRArray{Float32,2}
779+
end
780+
773781
x = 0.235f0
774782
x_ra = Reactant.to_rarray(x; track_numbers=Number)
775783

0 commit comments

Comments
 (0)