[$250] Report - Expense moved offline to WS with workflows disabled, still shows "Submit" option

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.73-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2305/folder/13176670/41237098/1060192756
Email or phone of affected tester (no customers): ibellicotest+2154@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least two workspaces.
Prerequisite 2: Workspace 1 has delayed submissions and approvals enabled and workspace 2 has workflows disabled.

1. Open the Expensify app.
2. Navigate to workspace 1 chat.
3. Create a manual expense.
4. Open the report of the just created expense.
5. Turn off internet connection.
6. Tap on "More" > "Change Workspace"
7. Select workspace 2 to move the expense to.
8. Navigate to the workspace where expense was moved.
9. Note that "Submit" option is available on expense preview and also inside report despite "Workflows" being disabled.
10. While inside report, tap on "Submit"
11. Turn on internet connection.
12. Note that "Unexpected error" message appears on the "Submitted" system message.
13. Dismiss the error and return to chat.
14. Note that a RBR without error message is visible on report preview.

Expected Result:

When an expense is moved from a workspace with delayed submissions and approvals enabled to a workspace with "Workflows" disabled, "Submit" option shouldn´t be available and report should be automatically displayed with "Done" status.

Actual Result:

"Submit" option is still available when moving an expense to a workspace with "Workflows" disabled while offline. Also, tapping on "Submit" while inside of the report, triggers an unexpected error when recovering internet connection, and expense preview shows a RBR without any error message.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022003923878847635220
• Upwork Job ID: 2003923878847635220
• Last Price Increase: 2025-12-31

Issue Owner

Current Issue Owner: @carlosmiceli

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report - Expense moved offline to WS with workflows disabled, still shows "Submit" option

What is the root cause of that problem?

In buildOptimisticChangePolicyData we are setting the new expense report's stateNum and statusNum to approved and closed when we move a submitted expense to a policy with disabled workflow. But we are not doing the same when the report we are moving is also open. And since stateNum and statusNum will be a default of open status we return true from isSubmitAction and we will show submit button

App/src/libs/actions/Report.ts

Lines 5717 to 5728 in 7605a2c

	if (isProcessingReport(report) && isInstantSubmitEnabledLocal && isSubmitAndCloseLocal && arePaymentsDisabled) {
	newStatusNum = CONST.REPORT.STATUS_NUM.CLOSED;
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
	value: {
	stateNum: CONST.REPORT.STATE_NUM.APPROVED,
	statusNum: CONST.REPORT.STATUS_NUM.CLOSED,
	},
	});
	failureData.push({

What changes do you think we should make in order to solve the problem?

We should set the report's stateNum to approved and statusNum to closed when the report is also open since the default stateNum and statNum of open expense report created in a workflow disabled workspace is approved and closed.

    if ((isProcessingReport(report) || isOpenReport(report)) && isInstantSubmitEnabledLocal && isSubmitAndCloseLocal && arePaymentsDisabled) {

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report - Expense moved offline to WS with workflows disabled, still shows "Submit" option

What is the root cause of that problem?

When moving an expense to a workspace with workflows disabled, the current logic checks if isInstantSubmitEnabled is true before auto-closing the report. However, workspaces with workflows disabled have autoReporting set to false, which makes isInstantSubmitEnabled return false. This causes the report to remain open instead of being automatically closed, incorrectly showing the "Submit" button even though workflows are disabled on that workspace.

App/src/libs/actions/Report.ts

Lines 5716 to 5717 in e288b20

	const arePaymentsDisabled = policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO;
	if (isProcessingReport(report) && isInstantSubmitEnabledLocal && isSubmitAndCloseLocal && arePaymentsDisabled) {

What changes do you think we should make in order to solve the problem?

In the buildOptimisticChangePolicyData function, we should add a direct check for when workflows are disabled areWorkflowsEnabled = false. When this condition is met and the report is in an open or submitted state, we should automatically close the report and set its status to "Done", regardless of the autoReporting setting. This will prevent the Submit button from appearing and ensure the expense correctly displays with a closed status.

The condition should check if workflows are disabled AND approval mode is "Submit & Close" AND the report is open or processing, then close the report immediately.

const arePaymentsDisabled = policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO; 
const shouldAutoCloseReport =
    (areWorkflowsDisabled && isSubmitAndCloseLocal && (isOpenExpenseReport(report) || isProcessingReport(report))) ||
    (isProcessingReport(report) && isInstantSubmitEnabledLocal && isSubmitAndCloseLocal && arePaymentsDisabled);
if (shouldAutoCloseReport) {

here

App/src/libs/actions/Report.ts

Lines 5716 to 5717 in e288b20

	const arePaymentsDisabled = policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO;
	if (isProcessingReport(report) && isInstantSubmitEnabledLocal && isSubmitAndCloseLocal && arePaymentsDisabled) {

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[mallenexpensify]

Will get to soon, lotta repro steps

[melvin-bot]

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?