Make it easier to change a business bank account linked to the workspace

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.0-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack: No
Issue reported by: @VictoriaExpensify (CC: @joekaufmanexpensify @dannymcclain @sonialiap)
Slack conversation: #migrate

Action Performed:

1. Add two business bank accounts to your account
2. Connect one to the workspace successfully
3. Go to Workflows > Make or track payments > click on the bank account

Expected Result:

This is an improvement.

1. When an admin of a workspace clicks on the bank account in Workflows show this screen:

2. When they click Change bank account navigate them to this existing screen if they have other bank accounts they can add instead:

3. Else, this existing screen if they don't have an existing bank account:

Actual Result:

Today, the only option you see is to Disconnect bank account, so it's unclear that you need to do that first to see your other business bank accounts to change over to.

Workaround:

Disconnect first, then add another existing bank account.

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

In-line above.

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ZhenjaHorbach

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Make it easier to change a business bank account linked to the workspace

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?

1. Currently we don't have change bank account logic, perhaps we need to add one here:
   

   App/src/pages/ReimbursementAccount/ConnectedVerifiedBankAccount.tsx

   Lines 101 to 107 in 6b079b6

   	<MenuItem
   	title={translate('workspace.bankAccount.disconnectBankAccount')}
   	icon={Close}
   	onPress={requestResetBankAccount}
   	outerWrapperStyle={shouldUseNarrowLayout ? styles.mhn5 : styles.mhn8}
   	disabled={!!pendingAction || !isEmptyObject(errors)}
   	/>

Similar to disconnect BA

2. Create one ChangeBankAccountPage, add a check if bankAccounts.length > 1 then we wanna show this page (specified in OP)

3. Else we wanna show the ReimbursementAccountPage

What alternative solutions did you explore? (Optional)

n/A

Result

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[joekaufmanexpensify]

We may have @koko57 or @MrMuzyk take this, if available, because it's related to an existing project they're working on

[MrMuzyk]

This looks fairly easy to implement but I don't have capacity right now :(
I'd probably have space for it next week.

[ZhenjaHorbach]

@joekaufmanexpensify
Since it's an easy feature
I suppose we can choose a contributor
Or I don't mind waiting @MrMuzyk !

[melvin-bot]

@ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!