All Outstanding reports aren't showing up in ND

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.11-53
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @abbagail
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Go to Reports > To Do > Approve
2. See all reports that are Outstanding for all workspaces

Expected Result:

All the reports in outstanding status displayed

Actual Result:

ND only shows few reports, but OD shows all the reports

Workaround:

Switch back to Classic to see all Outstanding reports

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Recording.2349.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @brunovjk

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

ND only shows few reports, but OD shows all the reports

What is the root cause of that problem?

When user navigates to To Do > Approve, the app uses live Onyx data instead of fetching from the server API. This is controlled by the shouldUseLiveData flag in SearchContext.

App/src/components/Search/SearchContext.tsx

Line 86 in 6e22ce7

const shouldUseLiveData = !!currentSearchKey && isTodoSearch(currentSearchHash, suggestedSearches);

When shouldUseLiveData is true, the app:

1. Skips calling the Search API
2. Uses useTodos() hook which builds data from ONYXKEYS.DERIVED.TODOS
3. ONYXKEYS.DERIVED.TODOS is computed from ONYXKEYS.COLLECTION.REPORT which only contains reports that have been previously loaded into Onyx

App/src/libs/actions/OnyxDerived/configs/todos.ts

Lines 78 to 91 in 6e22ce7

	export default createOnyxDerivedValueConfig({
	key: ONYXKEYS.DERIVED.TODOS,
	dependencies: [
	ONYXKEYS.COLLECTION.REPORT,
	ONYXKEYS.COLLECTION.POLICY,
	ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS,
	ONYXKEYS.COLLECTION.TRANSACTION,
	ONYXKEYS.COLLECTION.REPORT_ACTIONS,
	ONYXKEYS.COLLECTION.REPORT_METADATA,
	ONYXKEYS.BANK_ACCOUNT_LIST,
	ONYXKEYS.SESSION,
	ONYXKEYS.PERSONAL_DETAILS_LIST,
	],
	compute: ([allReports, allPolicies, allReportNameValuePairs, allTransactions, allReportActions, allReportMetadata, bankAccountList, session, personalDetailsList]) => {

The problem is that not all outstanding reports are loaded into Onyx. The ONYXKEYS.COLLECTION.REPORT only contains reports that:

• Were returned by OpenApp API (which has limited results)
• Were opened individually by the user via OpenReport API

So if there are outstanding reports that the user hasn't visited yet and weren't included in the initial OpenApp response, they won't appear in the To Do > Approve list.

What changes do you think we should make in order to solve the problem?

We should call the Search API for To Do searches (Approve, Submit, Pay, Export) to fetch all relevant reports from the server, rather than relying solely on local Onyx data.

The fix should modify the logic in src/components/Search/index.tsx to always call the Search API even for To Do searches:

--- a/src/components/Search/index.tsx
+++ b/src/components/Search/index.tsx
@@ -402,7 +402,7 @@ function Search({queryJSON, onSearchListScroll, contentContainerStyle, shouldUse

     // There's a race condition in Onyx which makes it return data from the previous Search, so in addition to checking that the data is loaded
     // we also need to check that the searchResults matches the type and status of the current search
-    const isDataLoaded = shouldUseLiveData || isSearchDataLoaded(searchResults, queryJSON);
+    const isDataLoaded = isSearchDataLoaded(searchResults, queryJSON);

     const hasErrors = Object.keys(searchResults?.errors ?? {}).length > 0 && !isOffline;

@@ -408,7 +408,6 @@ function Search({queryJSON, onSearchListScroll, contentContainerStyle, shouldUse
     // For to-do searches, we never show loading state since the data is always available locally from Onyx
     const shouldShowLoadingState =
-        !shouldUseLiveData &&
         !isOffline &&
         (!isDataLoaded ||
             (!!searchResults?.search.isLoading && Array.isArray(searchResults?.data) && searchResults?.data.length === 0) ||

What alternative solutions did you explore? (Optional)

N/A

[annaweber830]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In NewDot, the Reports → To Do → Approve view is missing some “Outstanding” expense reports that the user should be able to approve across all their workspaces. OldDot shows the full list, but NewDot only shows a subset.

What is the root cause of that problem?

For “to‑do” searches (Submit/Approve/Pay/Export), Search swaps the server-provided Search snapshot data for locally derived “live” data built from Onyx collections. Since Onyx does not necessarily contain all outstanding reports/transactions for the user (it’s limited to what’s been loaded into the app), the derived results are incomplete and the Approve list shows only a few items.

App/src/components/Search/SearchContext.tsx

Lines 79 to 109 in 60ca7c8

	const [snapshotSearchResults] = useOnyx(`${ONYXKEYS.COLLECTION.SNAPSHOT}${searchContextData.currentSearchHash}`, {canBeMissing: true});
	const {todoSearchResultsData} = useTodos();
	const currentSearchKey = searchContextData.currentSearchKey;
	const currentSearchHash = searchContextData.currentSearchHash;
	const {accountID} = useCurrentUserPersonalDetails();
	const suggestedSearches = useMemo(() => getSuggestedSearches(accountID), [accountID]);
	const shouldUseLiveData = !!currentSearchKey && isTodoSearch(currentSearchHash, suggestedSearches);
	// If viewing a to-do search, use live data from useTodos, otherwise return the snapshot data
	// We do this so that we can show the counters for the to-do search results without visiting the specific to-do page, e.g. show `Approve [3]` while viewing the `Submit` to-do search.
	const currentSearchResults = useMemo((): SearchResults | undefined => {
	if (shouldUseLiveData) {
	const liveData = todoSearchResultsData[currentSearchKey as keyof typeof todoSearchResultsData];
	const searchInfo: SearchResultsInfo = {
	...(snapshotSearchResults?.search ?? defaultSearchInfo),
	count: liveData.metadata.count,
	total: liveData.metadata.total,
	currency: liveData.metadata.currency,
	};
	const hasResults = Object.keys(liveData.data).length > 0;
	// For to-do searches, always return a valid SearchResults object (even with empty data)
	// This ensures we show the empty state instead of loading/blocking views
	return {
	search: {...searchInfo, isLoading: false, hasResults},
	data: liveData.data,
	};
	}
	return snapshotSearchResults ?? undefined;
	}, [shouldUseLiveData, currentSearchKey, todoSearchResultsData, snapshotSearchResults]);

The “live” to‑do data comes from useTodos(), which filters whatever is currently present in ONYXKEYS.COLLECTION.REPORT and ONYXKEYS.COLLECTION.TRANSACTION (and uses those partial inputs to decide which reports are “approvable”), so it cannot reliably represent “all outstanding reports”.

App/src/hooks/useTodos.ts

Lines 119 to 177 in 60ca7c8

	export default function useTodos() {
	const [allReports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: false});
	const [allPolicies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: false});
	const [allReportNameValuePairs] = useOnyx(ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS, {canBeMissing: false});
	const [allTransactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION, {canBeMissing: false});
	const [allReportActions] = useOnyx(ONYXKEYS.COLLECTION.REPORT_ACTIONS, {canBeMissing: false});
	const [allReportMetadata] = useOnyx(ONYXKEYS.COLLECTION.REPORT_METADATA, {canBeMissing: false});
	const [allTransactionViolations] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, {canBeMissing: true});
	const [bankAccountList] = useOnyx(ONYXKEYS.BANK_ACCOUNT_LIST, {canBeMissing: true});
	const [personalDetailsList] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {canBeMissing: true});
	const {login = '', accountID: currentUserAccountID} = useCurrentUserPersonalDetails();
	const todos = useMemo(() => {
	const reportsToSubmit: Report[] = [];
	const reportsToApprove: Report[] = [];
	const reportsToPay: Report[] = [];
	const reportsToExport: Report[] = [];
	const transactionsByReportID: Record<string, Transaction[]> = {};
	const reports = allReports ? Object.values(allReports) : [];
	if (reports.length === 0) {
	return {reportsToSubmit, reportsToApprove, reportsToPay, reportsToExport, transactionsByReportID};
	}
	if (allTransactions) {
	for (const transaction of Object.values(allTransactions)) {
	if (!transaction?.reportID) {
	continue;
	}
	(transactionsByReportID[transaction.reportID] ??= []).push(transaction);
	}
	}
	for (const report of reports) {
	if (!report?.reportID || report.type !== CONST.REPORT.TYPE.EXPENSE) {
	continue;
	}
	const policy = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report.policyID}`];
	const reportNameValuePair = allReportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report.chatReportID}`];
	const reportActions = Object.values(allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`] ?? []);
	const reportTransactions = transactionsByReportID[report.reportID] ?? [];
	const reportMetadata = allReportMetadata?.[`${ONYXKEYS.COLLECTION.REPORT_METADATA}${report.reportID}`];
	if (isSubmitAction(report, reportTransactions, reportMetadata, policy, reportNameValuePair, undefined, login, currentUserAccountID)) {
	reportsToSubmit.push(report);
	}
	if (isApproveAction(report, reportTransactions, currentUserAccountID, reportMetadata, policy)) {
	reportsToApprove.push(report);
	}
	if (isPrimaryPayAction(report, currentUserAccountID, login, bankAccountList, policy, reportNameValuePair)) {
	reportsToPay.push(report);
	}
	if (isExportAction(report, login, policy, reportActions)) {
	reportsToExport.push(report);
	}
	}
	return {reportsToSubmit, reportsToApprove, reportsToPay, reportsToExport, transactionsByReportID};
	}, [allReports, allTransactions, allPolicies, allReportNameValuePairs, allReportActions, currentUserAccountID, login, bankAccountList, allReportMetadata]);

What changes do you think we should make in order to solve the problem?

Stop overriding to‑do search results with locally derived Onyx data, and always render the server snapshot for the active search. This ensures the Approve list is complete (matches OldDot / backend search results). If we still want “live” counters/badges, keep them sourced from useTodos() in the type menu (which is already done via reportCounts) rather than replacing the actual results list.

App/src/components/Search/SearchContext.tsx

Lines 79 to 109 in 60ca7c8

	const [snapshotSearchResults] = useOnyx(`${ONYXKEYS.COLLECTION.SNAPSHOT}${searchContextData.currentSearchHash}`, {canBeMissing: true});
	const {todoSearchResultsData} = useTodos();
	const currentSearchKey = searchContextData.currentSearchKey;
	const currentSearchHash = searchContextData.currentSearchHash;
	const {accountID} = useCurrentUserPersonalDetails();
	const suggestedSearches = useMemo(() => getSuggestedSearches(accountID), [accountID]);
	const shouldUseLiveData = !!currentSearchKey && isTodoSearch(currentSearchHash, suggestedSearches);
	// If viewing a to-do search, use live data from useTodos, otherwise return the snapshot data
	// We do this so that we can show the counters for the to-do search results without visiting the specific to-do page, e.g. show `Approve [3]` while viewing the `Submit` to-do search.
	const currentSearchResults = useMemo((): SearchResults | undefined => {
	if (shouldUseLiveData) {
	const liveData = todoSearchResultsData[currentSearchKey as keyof typeof todoSearchResultsData];
	const searchInfo: SearchResultsInfo = {
	...(snapshotSearchResults?.search ?? defaultSearchInfo),
	count: liveData.metadata.count,
	total: liveData.metadata.total,
	currency: liveData.metadata.currency,
	};
	const hasResults = Object.keys(liveData.data).length > 0;
	// For to-do searches, always return a valid SearchResults object (even with empty data)
	// This ensures we show the empty state instead of loading/blocking views
	return {
	search: {...searchInfo, isLoading: false, hasResults},
	data: liveData.data,
	};
	}
	return snapshotSearchResults ?? undefined;
	}, [shouldUseLiveData, currentSearchKey, todoSearchResultsData, snapshotSearchResults]);

const suggestedSearches = useMemo(() => getSuggestedSearches(accountID), [accountID]);

// NOTE: We intentionally do NOT replace to-do search results with locally-derived Onyx data,
// because the Onyx collections do not guarantee they contain all outstanding reports.
// We keep using server snapshots for correctness/completeness.
const shouldUseLiveData = false;

const currentSearchResults = useMemo((): SearchResults | undefined => snapshotSearchResults ?? undefined, [snapshotSearchResults]);

What alternative solutions did you explore? (Optional)

• Keep “live” results, but first guarantee completeness by persisting the full to‑do Search response into Onyx (reports + transactions + metadata) and having useTodos()/Search consume that dataset. This is higher risk and more involved (data duplication + eviction/perf considerations).
• Hybrid approach: use snapshot results for data, and only use useTodos() to update metadata (counts/totals). This still requires revisiting shouldUseLiveData semantics in Search since it currently affects loading behavior and “data loaded” checks.

[github-actions]

⚠️ @annaweber830 Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.