cleanup for upcoming release

Author: Alexander-Krause-Glau

kiekeradapter/src/main/java/net/explorviz/kiekeradapter/configuration/GenericExplorVizExternalLogAdapter.java

@@ -17,24 +17,20 @@
 import explorviz.live_trace_processing.record.misc.SystemMonitoringRecord;
 import explorviz.live_trace_processing.record.trace.HostApplicationMetaDataRecord;
 import java.nio.ByteBuffer;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Prepares the ByteBuffer and sends out the buffer to the backend.
  *
- * @author Christian Zirkelbach (czi@informatik.uni-kiel.de)
- *
  */
 public final class GenericExplorVizExternalLogAdapter {
 
-  private static final Logger LOGGER =
-      LoggerFactory.getLogger(GenericExplorVizExternalLogAdapter.class);
+  // private static final Logger LOGGER =
+  // LoggerFactory.getLogger(GenericExplorVizExternalLogAdapter.class);
 
-  private static final boolean REPLAY_IN_REALTIME = false;
+  // private static final boolean REPLAY_IN_REALTIME = false;
   private static final ByteBuffer EXPLORVIZ_BUFFER;
   private static long firstTimestamp = -1;
-  private static long firstWallclockTimestamp;
+  // private static long firstWallclockTimestamp;
 
   private GenericExplorVizExternalLogAdapter() {
     // private constructor
@@ -80,19 +76,19 @@ private static void sendBufferIfHasElements(final long timestamp) {
     if (EXPLORVIZ_BUFFER.position() > 0) {
       if (firstTimestamp == -1) {
         firstTimestamp = timestamp;
-        firstWallclockTimestamp = System.nanoTime();
+        // firstWallclockTimestamp = System.nanoTime();
       } else {
-        final long passedTime = timestamp - firstTimestamp;
-
-        while (REPLAY_IN_REALTIME && System.nanoTime() - firstWallclockTimestamp < passedTime) {
-          if (passedTime > 1000L * 1000L) {
-            try {
-              Thread.sleep(1000L);
-            } catch (final InterruptedException e) {
-              LOGGER.warn(LOGGER.getName() + ": " + e.getMessage());
-            }
-          }
-        }
+        // final long passedTime = timestamp - firstTimestamp;
+
+        // while (REPLAY_IN_REALTIME && System.nanoTime() - firstWallclockTimestamp < passedTime) {
+        // if (passedTime > 1000L * 1000L) {
+        // try {
+        // Thread.sleep(1000L);
+        // } catch (final InterruptedException e) {
+        // LOGGER.warn(LOGGER.getName() + ": " + e.getMessage());
+        // }
+        // }
+        // }
       }
 
       MonitoringController.sendOutBuffer(EXPLORVIZ_BUFFER);

settings-service/src/main/java/net/explorviz/settings/server/main/SetupApplicationListener.java

@@ -16,18 +16,14 @@
 import org.glassfish.jersey.server.monitoring.ApplicationEventListener;
 import org.glassfish.jersey.server.monitoring.RequestEvent;
 import org.glassfish.jersey.server.monitoring.RequestEventListener;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Primary starting class - executed, when the servlet context is started.
  */
 @WebListener
 public class SetupApplicationListener implements ApplicationEventListener {
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(SetupApplicationListener.class);
-
-  private static final String ADMIN_NAME = "admin";
+  // private static final Logger LOGGER = LoggerFactory.getLogger(SetupApplicationListener.class);
 
   @Inject
   private SettingsRepository settingRepo;
@@ -63,7 +59,7 @@ public RequestEventListener onRequest(final RequestEvent requestEvent) {
 
 
   /**
-   * Adds the default settings to the database
+   * Adds the default settings to the database.
    */
   private void addDefaultSettings() {
     final String origin = "backend";

settings-service/src/main/java/net/explorviz/settings/services/SettingsRepository.java

@@ -70,10 +70,10 @@ public Optional<Setting> find(final String id) {
       return Optional.empty();
     }
 
-    final Class[] types = {RangeSetting.class, FlagSetting.class};
+    final Class<?>[] types = {RangeSetting.class, FlagSetting.class};
 
-    for (final Class<? extends Setting> t : types) {
-      final Setting setting = this.datastore.get(t, id);
+    for (final Class<?> t : types) {
+      final Setting setting = (Setting) this.datastore.get(t, id);
       final Optional<Setting> res = Optional.ofNullable(setting);
 
       if (res.isPresent()) {

settings-service/src/main/java/net/explorviz/settings/services/validation/PreferenceValidator.java

@@ -17,7 +17,7 @@ public class PreferenceValidator {
 
   private final UserPreference up;
 
-  private final List<Class> settingTypes = new ArrayList<>();
+  private final List<Class<?>> settingTypes = new ArrayList<>();
 
 
 

settings-service/src/test/java/net/explorviz/settings/services/validation/PreferenceValidatorTest.java

@@ -24,7 +24,7 @@ public class PreferenceValidatorTest {
   private static final String ERROR = "Valid preference but exception thrown";
 
 
-  private static final double DEFAULT = 0.001;
+  // private static final double DEFAULT = 0.001;
   private static final double MIN = -10.01;
   private static final double MAX = 102;
 

user-service/src/main/java/net/explorviz/security/util/PasswordStorage.java

@@ -15,7 +15,6 @@
  *      "https://github.com/defuse/password-hashing">https://github.com/defuse/password-hashing</a>
  *
  */
-@SuppressWarnings({"PMD"})
 public class PasswordStorage {
 
   // CHECKSTYLE.OFF: javadoc