make functions private and underscored

Author: artemeff

lib/construct/hooks/fasten.ex

@@ -12,12 +12,14 @@ defmodule Construct.Hooks.Fasten do
   def __compile__(module, fields) do
     cast_defs =
       Enum.map(fields, fn({name, type, opts}) ->
+        function_name = :"__cast_#{name}__"
+
         {default_before_clause, default_after_clause} =
           case Keyword.get(opts, :default) do
             :__construct_no_default_value__ ->
               clause_after =
                 quote do
-                  def unquote(:"cast_#{name}")(_, _) do
+                  defp unquote(function_name)(_, _) do
                     {:error, %{unquote(name) => :missing}}
                   end
                 end
@@ -27,7 +29,7 @@ defmodule Construct.Hooks.Fasten do
             nil ->
               clause_after =
                 quote do
-                  def unquote(:"cast_#{name}")(_, _) do
+                  defp unquote(function_name)(_, _) do
                     {:error, %{unquote(name) => :missing}}
                   end
                 end
@@ -39,18 +41,18 @@ defmodule Construct.Hooks.Fasten do
 
               clause_before =
                 quote do
-                  def unquote(:"cast_#{name}")(%{unquote(to_string(name)) => term}, _opts) when term == unquote(term) do
+                  defp unquote(function_name)(%{unquote(to_string(name)) => term}, _opts) when term == unquote(term) do
                     {:ok, unquote(term)}
                   end
 
-                  def unquote(:"cast_#{name}")(%{unquote(name) => term}, _opts) when term == unquote(term) do
+                  defp unquote(function_name)(%{unquote(name) => term}, _opts) when term == unquote(term) do
                     {:ok, unquote(term)}
                   end
                 end
 
               clause_after =
                 quote do
-                  def unquote(:"cast_#{name}")(_, _) do
+                  defp unquote(function_name)(_, _) do
                     {:ok, unquote(term)}
                   end
                 end
@@ -60,11 +62,11 @@ defmodule Construct.Hooks.Fasten do
 
         cast_clause =
           quote do
-            def unquote(:"cast_#{name}")(%{unquote(to_string(name)) => term}, opts) do
+            defp unquote(function_name)(%{unquote(to_string(name)) => term}, opts) do
               Construct.Type.cast(unquote(type), term, opts)
             end
 
-            def unquote(:"cast_#{name}")(%{unquote(name) => term}, opts) do
+            defp unquote(function_name)(%{unquote(name) => term}, opts) do
               Construct.Type.cast(unquote(type), term, opts)
             end
           end
@@ -90,7 +92,7 @@ defmodule Construct.Hooks.Fasten do
     with_matches =
       Enum.map(fields, fn({name, _type, _opts}) ->
         quote do
-          {:ok, unquote(Macro.var(name, nil))} <- unquote(:"cast_#{name}")(params, opts)
+          {:ok, unquote(Macro.var(name, nil))} <- unquote(:"__cast_#{name}__")(params, opts)
         end
       end)
 
@@ -104,7 +106,6 @@ defmodule Construct.Hooks.Fasten do
       end
 
     merge_blocks(make_ast, cast_defs)
-    |> tap(fn(ast) -> IO.puts(Macro.to_string(ast)) end)
   end
 
   defp merge_blocks(a, b) do