Fix SSL bypass for POST methods

Author: TheLanc3

OutlineManager.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Threading.Tasks;
 using System.Net;
 using System.IO;
@@ -9,6 +9,8 @@
 using System.Linq;
 using Newtonsoft.Json;
 using OutlineManagerExceptions;
+using System.Net.Security;
+using System.Security.Cryptography.X509Certificates;
 
 namespace OutlineManager
 {
@@ -54,7 +56,7 @@ private static bool CallRequest(string urlMethod, string method, out string data
                 }
                 return true;
             }
-            catch(WebException exc)
+            catch (WebException exc)
             {
                 data = null;
                 if (exc.Message == "The SSL connection could not be established, see inner exception.")
@@ -73,12 +75,12 @@ private static bool CallRequest(string urlMethod, string method, JObject args, o
             {
                 WebClient webClient = new WebClient();
                 webClient.Headers[HttpRequestHeader.ContentType] = "application/json";
-                if(HasSsl == false)
-                    ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12;
+                if (HasSsl == false)
+                    ServicePointManager.ServerCertificateValidationCallback = (object sender, X509Certificate certificate, X509Chain chain, SslPolicyErrors sslPolicyErrors) => true;
                 data = webClient.UploadString($"{ApiUrl}/{urlMethod}", method, args.ToString());
                 return true;
             }
-            catch(WebException exc)
+            catch (WebException exc)
             {
                 data = null;
                 if (exc.Message == "The SSL connection could not be established, see inner exception.")
@@ -97,46 +99,51 @@ private static bool CallRequest(string urlMethod, string method, JObject args, o
         /// </summary>
         /// <returns>Outline Server Info in <see cref="T:OutlineManager.Types.OutlineServer" /></returns>
         /// <exception cref="OutlineManagerException"></exception>
-        public OutlineServer GetOutlineServer() {
+        public OutlineServer GetOutlineServer()
+        {
             CallRequest("server", "GET", out var data);
             return JsonConvert.DeserializeObject<OutlineServer>(data);
         }
-        
+
         ///<summary>
         /// Changes the hostname for access keys.
         /// Must be a valid hostname or IP address.
         /// If it's a hostname, DNS must be set up independently of this API.
         ///</summary>
         /// <returns><b>True</b>, if the hostname was changed succesfully</returns>
-        public bool ChangeHostname(string newHostname) {
-            return CallRequest("server/hostname-for-access-keys", "PUT", new JObject { {"hostname", newHostname} }, out _);
+        public bool ChangeHostname(string newHostname)
+        {
+            return CallRequest("server/hostname-for-access-keys", "PUT", new JObject { { "hostname", newHostname } }, out _);
         }
-        
+
         ///<summary>
         /// Changes the default port for newly created access keys.
         /// This can be a port already used for access keys.
         ///</summary>
         /// <returns><b>True</b>, if the port was changed succesfully</returns>
-        public bool ChangePort(int newPort) {
-            return CallRequest("server/port-for-new-access-keys", "PUT", new JObject { {"port", newPort} }, out _);
+        public bool ChangePort(int newPort)
+        {
+            return CallRequest("server/port-for-new-access-keys", "PUT", new JObject { { "port", newPort } }, out _);
         }
-        
+
         ///<summary>
         /// Rename the Outline Server
         ///</summary>
         /// <returns><b>True</b>, if the server name was changed succesfully</returns>
-        public bool RenameServer(string newName) {
-            return CallRequest("name", "PUT", new JObject { {"name", newName} }, out _);
+        public bool RenameServer(string newName)
+        {
+            return CallRequest("name", "PUT", new JObject { { "name", newName } }, out _);
         }
-        
+
         ///<summary>
         /// Change Metrics Sharing
         ///</summary>
         /// <returns><b>True</b>, if the metrics sharing was changed succesfully</returns>
-        public bool ChangeMetricsSharing(bool newParam) {
-            return CallRequest("metrics/enabled", "PUT", new JObject { {"metricsEnabled", newParam} }, out _);
+        public bool ChangeMetricsSharing(bool newParam)
+        {
+            return CallRequest("metrics/enabled", "PUT", new JObject { { "metricsEnabled", newParam } }, out _);
         }
-            
+
         /// <summary>
         /// Get Outline key in <see cref="T:OutlineManager.Types.OutlineKey" /> by ID
         /// </summary>

OutlineManager.csproj

@@ -12,6 +12,7 @@
     <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
     <GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>
     <GenerateAssemblyInformationalVersionAttribute>false</GenerateAssemblyInformationalVersionAttribute>
+    <Configurations>Release;Debug</Configurations>
   </PropertyGroup>
 
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
@@ -25,6 +26,6 @@
     <None Include="/Users/lance/Projects/OutlineManager/icon.png" Pack="true" Visible="false" PackagePath="images\icon.png" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
+    <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
   </ItemGroup>
 </Project>

Properties/AssemblyInfo.cs

@@ -1,4 +1,4 @@
-using System.Reflection;
+using System.Reflection;
 using System.Runtime.CompilerServices;
 
 // Information about this assembly is defined by the following attributes. 
@@ -14,8 +14,8 @@
 // The form "{Major}.{Minor}.*" will automatically update the build and revision,
 // and "{Major}.{Minor}.{Build}.*" will update just the revision.
 
-[assembly: AssemblyVersion("1.1.2")]
-[assembly: AssemblyFileVersion("1.1.2.0")]
+[assembly: AssemblyVersion("1.1.3")]
+[assembly: AssemblyFileVersion("1.1.3.0")]
 
 // The following attributes are used to specify the signing key for the assembly, 
 // if desired. See the Mono documentation for more information about signing.

Types/DataLimit.cs

@@ -1,11 +1,11 @@
-using System;
+using System;
 
 namespace OutlineManager.Types
 {
 	public class DataLimit
 	{
-		/// <value>Set limit for key</value>
-		public long Bytes;
+        /// <value>Set limit for key</value>
+        public long Bytes;
 	}
 }
 

Types/OutlineKey.cs

@@ -7,8 +7,8 @@ namespace OutlineManager.Types
 	/// </summary>
 	public class OutlineKey
 	{
-		/// <value>Key ID</value>
-		public int Id;
+        /// <value>Key ID</value>
+        public int Id;
 		/// <value>Name of key</value>
 		public string Name;
 		/// <value>Password of key</value>
@@ -18,9 +18,10 @@ public class OutlineKey
 		/// <value>Method for password of key</value>
 		public string Method;
 		/// <value><see cref="T:OutlineManager.Types.DataLimit"/> of key</value>
-		public DataLimit DataLimit;
-		/// <value>Access URL for using in Outline Client App</value>
-		public string AccessUrl;
+        public DataLimit DataLimit;
+        /// <value>Access URL for using in Outline Client App</value>
+        public string AccessUrl;
 	}
+
 }
 

Types/OutlineServer.cs

@@ -20,4 +20,4 @@ public class OutlineServer {
         ///<value>IP/Hostname server for access keys</value>
         public string HostnameForAccessKeys;
     }
-}
+}

Types/SearchMethod.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 
 namespace OutlineManager.Types
 {

Types/TransferredData.cs

@@ -3,10 +3,10 @@ namespace OutlineManager.Types
 {
 	public class TransferredData
 	{
-		/// <value>Key ID</value>
-		public int KeyId;
-		/// <value>Used bytes by this key</value>
-		public long UsedBytes;
+        /// <value>Key ID</value>
+        public int KeyId;
+        /// <value>Used bytes by this key</value>
+        public long UsedBytes;
 	}
 }