build(deps-dev): swap happy-dom for jsdom as Vitest DOM environment#419
Conversation
happy-dom is single-maintainer with a past critical CVE; jsdom has 6 maintainers, ~7x the weekly downloads, and a perfect Snyk maintenance score. Test suite (1691 tests / 82 files) stays green on jsdom.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
📝 WalkthroughWalkthroughVitest's DOM test environment is migrated from ChangesTest Environment Migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
docs/ar/testing.mdxESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. docs/de/testing.mdxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. docs/es/testing.mdxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Summary
Swap the Vitest DOM environment from
happy-domtojsdom.happy-domis single-maintainer and has a past critical CVE (AIKIDO-2024-10426).jsdomhas 6 maintainers, ~7x the weekly downloads (~49M vs ~7M), a 100/100 Snyk maintenance score, and broader DOM API coverage.Changes
vitest.config.mts:environment: "happy-dom"->"jsdom"package.json: drophappy-dom ^20.7.0, addjsdom ^29.1.1bun.lock: regenerateddocs/testing.mdx+ 14 translated mirrors: replacehappy-dommention withjsdomCHANGELOG.md: entry under### Dependenciesfor0.0.11-beta.3Test plan
bun run test:run— 1691 tests pass across 82 files on jsdombun run lint— 0 errors (2 pre-existing warnings unrelated)bunx tsc --noEmit— cleanbun run build— Next.js + dist bundle build greenGenerated with Claude Code
Summary by CodeRabbit
Documentation
Chores