From 4dd5f0a8202305e93cbca212c3e16d97b27dadbd Mon Sep 17 00:00:00 2001 From: Alan Deutscher Date: Tue, 27 Jan 2026 15:22:33 -0800 Subject: [PATCH 1/3] Add minimal INetworkConnectionBroadcaster interface so that a network connection's broadcasting can be more easily mocked. --- .../FishNet/Runtime/Connection/NetworkConnection.Buffer.cs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs b/Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs index 1de07448..6ac8c78c 100644 --- a/Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs +++ b/Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs @@ -10,7 +10,12 @@ namespace FishNet.Connection { - public partial class NetworkConnection + public interface INetworkConnectionBroadcaster + { + void Broadcast(T message, bool requireAuthenticated = true, Channel channel = Channel.Reliable) where T : struct, IBroadcast; + } + + public partial class NetworkConnection : INetworkConnectionBroadcaster { #region Private. /// From f5d70a7cf6521e9251330802a7ef83be8bcc3114 Mon Sep 17 00:00:00 2001 From: Alan Deutscher Date: Tue, 27 Jan 2026 15:31:39 -0800 Subject: [PATCH 2/3] include documentation comments --- .../FishNet/Runtime/Connection/NetworkConnection.Buffer.cs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs b/Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs index 6ac8c78c..9ca69a4f 100644 --- a/Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs +++ b/Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs @@ -12,6 +12,13 @@ namespace FishNet.Connection { public interface INetworkConnectionBroadcaster { + /// + /// Sends a broadcast to this connection. + /// + /// Type of broadcast to send. + /// Broadcast data being sent; for example: an instance of your broadcast type. + /// True if the client must be authenticated for this broadcast to send. + /// Channel to send on. void Broadcast(T message, bool requireAuthenticated = true, Channel channel = Channel.Reliable) where T : struct, IBroadcast; } From 843cd2ce3d8f9870d9e029f1229de269488765e7 Mon Sep 17 00:00:00 2001 From: Alan Deutscher Date: Tue, 27 Jan 2026 15:33:35 -0800 Subject: [PATCH 3/3] more comments --- Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs b/Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs index 9ca69a4f..b1ac827e 100644 --- a/Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs +++ b/Assets/FishNet/Runtime/Connection/NetworkConnection.Buffer.cs @@ -10,6 +10,9 @@ namespace FishNet.Connection { + /// + /// Abstraction of a NetworkConnection's broadcasting duties + /// public interface INetworkConnectionBroadcaster { ///