feat!: rename EventProcessorConfig.analytics_server_url to events_api_url and default it

Default points to https://events.api.flagsmith.com/ so callers don't have
to specify it for cloud Flagsmith. Self-hosted users override via the
events_api_url field.

BREAKING CHANGE: EventProcessorConfig field analytics_server_url renamed
to events_api_url.

Author: gagantrivedi

flagsmith/analytics.py

@@ -19,6 +19,8 @@
 
 FLAG_EXPOSURE_EVENT: typing.Final[str] = "$flag_exposure"
 
+DEFAULT_EVENT_API_URL: typing.Final[str] = "https://events.api.flagsmith.com/"
+
 session = FuturesSession(max_workers=4)
 
 
@@ -74,7 +76,7 @@ def track_feature(self, feature_name: str) -> None:
 
 @dataclass
 class EventProcessorConfig:
-    analytics_server_url: str
+    events_api_url: str = DEFAULT_EVENT_API_URL
     max_buffer_items: int = 1000
     flush_interval_seconds: float = 10.0
 
@@ -91,7 +93,7 @@ def __init__(
         config: EventProcessorConfig,
         environment_key: str,
     ) -> None:
-        url = config.analytics_server_url
+        url = config.events_api_url
         if not url.endswith("/"):
             url = f"{url}/"
         self._batch_endpoint = f"{url}v1/events"

tests/conftest.py

@@ -32,7 +32,7 @@ def analytics_processor() -> AnalyticsProcessor:
 
 @pytest.fixture()
 def event_processor_config() -> EventProcessorConfig:
-    return EventProcessorConfig(analytics_server_url="http://test_analytics/")
+    return EventProcessorConfig(events_api_url="http://test_analytics/")
 
 
 @pytest.fixture()

tests/test_event_processor.py

@@ -86,7 +86,7 @@ def test_track_exposure_event_uses_explicit_timestamp(
 
 def test_auto_flush_on_buffer_full() -> None:
     config = EventProcessorConfig(
-        analytics_server_url="http://test/", max_buffer_items=5
+        events_api_url="http://test/", max_buffer_items=5
     )
     processor = EventProcessor(config=config, environment_key="key")
 
@@ -139,7 +139,7 @@ def test_failed_flush_requeues_events(event_processor: EventProcessor) -> None:
 
 def test_start_stop_lifecycle() -> None:
     config = EventProcessorConfig(
-        analytics_server_url="http://test/", flush_interval_seconds=100
+        events_api_url="http://test/", flush_interval_seconds=100
     )
     processor = EventProcessor(config=config, environment_key="key")
 

tests/test_flagsmith.py

@@ -960,7 +960,7 @@ def test_track_event_raises_without_config(api_key: str) -> None:
 def test_track_event_delegates_to_event_processor(
     mocker: MockerFixture, api_key: str
 ) -> None:
-    config = EventProcessorConfig(analytics_server_url="http://test/")
+    config = EventProcessorConfig(events_api_url="http://test/")
     flagsmith = Flagsmith(environment_key=api_key, event_processor_config=config)
 
     mock_track = mocker.patch.object(flagsmith._event_processor, "track_event")
@@ -992,7 +992,7 @@ def test_track_exposure_event_raises_without_config(api_key: str) -> None:
 def test_track_exposure_event_delegates_to_event_processor(
     mocker: MockerFixture, api_key: str
 ) -> None:
-    config = EventProcessorConfig(analytics_server_url="http://test/")
+    config = EventProcessorConfig(events_api_url="http://test/")
     flagsmith = Flagsmith(environment_key=api_key, event_processor_config=config)
 
     mock_track = mocker.patch.object(flagsmith._event_processor, "track_exposure_event")
@@ -1019,7 +1019,7 @@ def test_track_exposure_event_delegates_to_event_processor(
 def test_get_experiment_flag_returns_flag_and_tracks_exposure(
     mocker: MockerFixture, api_key: str, identities_json: str
 ) -> None:
-    config = EventProcessorConfig(analytics_server_url="http://test/")
+    config = EventProcessorConfig(events_api_url="http://test/")
     flagsmith = Flagsmith(environment_key=api_key, event_processor_config=config)
 
     mock_track = mocker.patch.object(flagsmith._event_processor, "track_exposure_event")
@@ -1049,7 +1049,7 @@ def test_get_experiment_flag_returns_flag_and_tracks_exposure(
 def test_get_experiment_flag_skips_exposure_for_default_flag(
     mocker: MockerFixture, api_key: str
 ) -> None:
-    config = EventProcessorConfig(analytics_server_url="http://test/")
+    config = EventProcessorConfig(events_api_url="http://test/")
 
     def default_flag_handler(feature_name: str) -> DefaultFlag:
         return DefaultFlag(enabled=True, value="default-variant")