refactor: stringify value in _buffer_event so all layers accept the broad type

DB stores value as string, so it must be string on the wire. Move the
conversion to the single deepest point (`_buffer_event`) instead of forcing
callers / Flagsmith.* to stringify. All public methods now accept
Optional[Union[str, int, float, bool]] symmetrically; get_experiment_flag
just passes flag.value through.

Author: gagantrivedi

flagsmith/analytics.py

@@ -109,7 +109,7 @@ def track_event(
         self,
         event: str,
         identifier: typing.Optional[str] = None,
-        value: typing.Optional[typing.Union[str, int, float]] = None,
+        value: typing.Optional[typing.Union[str, int, float, bool]] = None,
         traits: typing.Optional[typing.Dict[str, typing.Any]] = None,
         metadata: typing.Optional[typing.Dict[str, typing.Any]] = None,
     ) -> None:
@@ -126,7 +126,7 @@ def track_exposure_event(
         self,
         feature_name: str,
         identifier: typing.Optional[str] = None,
-        value: typing.Optional[str] = None,
+        value: typing.Optional[typing.Union[str, int, float, bool]] = None,
         traits: typing.Optional[typing.Dict[str, typing.Any]] = None,
         metadata: typing.Optional[typing.Dict[str, typing.Any]] = None,
     ) -> None:
@@ -144,7 +144,7 @@ def _buffer_event(
         event: str,
         feature_name: typing.Optional[str],
         identifier: typing.Optional[str],
-        value: typing.Optional[typing.Union[str, int, float]],
+        value: typing.Optional[typing.Union[str, int, float, bool]],
         traits: typing.Optional[typing.Dict[str, typing.Any]],
         metadata: typing.Optional[typing.Dict[str, typing.Any]],
     ) -> None:
@@ -155,7 +155,7 @@ def _buffer_event(
                     "event": event,
                     "feature_name": feature_name,
                     "identifier": identifier,
-                    "value": value,
+                    "value": str(value) if value is not None else None,
                     "traits": dict(traits) if traits else None,
                     "metadata": {**(metadata or {}), "sdk_version": __version__},
                     "timestamp": int(datetime.now().timestamp() * 1000),

flagsmith/flagsmith.py

@@ -365,7 +365,7 @@ def get_experiment_flag(
             self.track_exposure_event(
                 feature_name=feature_name,
                 identifier=identifier,
-                value=str(flag.value) if flag.value is not None else None,
+                value=flag.value,
                 traits=traits,
             )
         return flag
@@ -374,7 +374,7 @@ def track_event(
         self,
         event: str,
         identifier: typing.Optional[str] = None,
-        value: typing.Optional[typing.Union[str, int, float]] = None,
+        value: typing.Optional[typing.Union[str, int, float, bool]] = None,
         traits: typing.Optional[TraitMapping] = None,
         metadata: typing.Optional[typing.Dict[str, typing.Any]] = None,
     ) -> None:
@@ -392,7 +392,7 @@ def track_exposure_event(
         self,
         feature_name: str,
         identifier: typing.Optional[str] = None,
-        value: typing.Optional[str] = None,
+        value: typing.Optional[typing.Union[str, int, float, bool]] = None,
         traits: typing.Optional[TraitMapping] = None,
         metadata: typing.Optional[typing.Dict[str, typing.Any]] = None,
     ) -> None:

tests/test_event_processor.py

@@ -25,13 +25,31 @@ def test_track_event_buffers_event(event_processor: EventProcessor) -> None:
     assert event["event"] == "purchase"
     assert event["feature_name"] is None
     assert event["identifier"] == "user1"
-    assert event["value"] == 99.5
+    assert event["value"] == "99.5"
     assert event["traits"] == {"plan": "premium"}
     assert event["metadata"]["sku"] == "abc"
     assert "sdk_version" in event["metadata"]
     assert isinstance(event["timestamp"], int)
 
 
+def test_buffer_stringifies_non_string_values(
+    event_processor: EventProcessor,
+) -> None:
+    event_processor.track_event(event="purchase", value=99.5)
+    event_processor.track_event(event="opt_in", value=True)
+    event_processor.track_event(event="count", value=3)
+    event_processor.track_event(event="variant", value="control")
+    event_processor.track_event(event="empty")
+
+    assert [e["value"] for e in event_processor._buffer] == [
+        "99.5",
+        "True",
+        "3",
+        "control",
+        None,
+    ]
+
+
 def test_track_event_defaults_timestamp_to_now(
     event_processor: EventProcessor,
 ) -> None: