Use FES /account/feedback endpoint

[sosnovsky]

For feedback messages we need to migrate from deprecated https://flowcrypt.com/api/help/feedback endpoint to the newer shared-tenant-fes/api/v1/account/feedback endpoint.

flowcrypt-android/FlowCrypt/src/main/java/com/flowcrypt/email/api/retrofit/RetrofitApiServiceInterface.kt

Line 63 in f3cf428

@POST(BuildConfig.BACKEND_URL + "help/feedback")

Should be done after https://github.com/FlowCrypt/enterprise-server/issues/6123 is implemented and deployed

[sosnovsky]

Hi @DenBond7, mentioned functionality was deployed to shared-tenant-fes, please include this task in the next Android release, thanks!

[DenBond7]

I've tried to migrate but I caught errors

-> POST https://flowcrypt.com/shared-tenant-fes/api/v1/account/feedback
2024-12-30 11:32:05.073 okhttp.OkHttpClient  com...email.debug  I  Content-Type: application/json; charset=UTF-8
2024-12-30 11:32:05.073 okhttp.OkHttpClient  com...email.debug  I  Content-Length: 196
2024-12-30 11:32:05.073 okhttp.OkHttpClient  com...email.debug  I  api-version: 3
2024-12-30 11:32:05.074 okhttp.OkHttpClient  com...email.debug  I  {"email":"den@flowcrypt.com","logs":"","message":"Test issue \n\nhttps://github.com/FlowCrypt/flowcrypt-android/issues/2827\n\nversion: Android 1.6.1_dev_161__2024_12_30__b121724","screenshot":""}
2024-12-30 11:32:05.075 okhttp.OkHttpClient  com...email.debug  I  --> END POST (196-byte body)

2024-12-30 11:32:05.264 okhttp.OkHttpClient  com...email.debug  I  <-- 400 Bad Request https://flowcrypt.com/shared-tenant-fes/api/v1/account/feedback (189ms)
2024-12-30 11:32:05.264 okhttp.OkHttpClient  com...email.debug  I  Date: Mon, 30 Dec 2024 09:32:06 GMT
2024-12-30 11:32:05.264 okhttp.OkHttpClient  com...email.debug  I  Content-Type: application/json
2024-12-30 11:32:05.264 okhttp.OkHttpClient  com...email.debug  I  Content-Length: 107
2024-12-30 11:32:05.264 okhttp.OkHttpClient  com...email.debug  I  Connection: keep-alive
2024-12-30 11:32:05.264 okhttp.OkHttpClient  com...email.debug  I  Access-Control-Allow-Origin: *
2024-12-30 11:32:05.264 okhttp.OkHttpClient  com...email.debug  I  X-Frame-Options: SAMEORIGIN
2024-12-30 11:32:05.264 okhttp.OkHttpClient  com...email.debug  I  Strict-Transport-Security: max-age=63072000; includeSubDomains; preload
2024-12-30 11:32:05.264 okhttp.OkHttpClient  com...email.debug  I  {"code":400,"message":"Domain disabled","details":"For more details, see FlowCrypt External Service logs."}
2024-12-30 11:32:05.264 okhttp.OkHttpClient  com...email.debug  I  <-- END HTTP (107-byte body)

@sosnovsky @martgil Please check my logs. Have I missed something?

[martgil]

Hello @DenBond7 - I'll check it in a second and get back to you.

[sosnovsky]

Feedback endpoint is disabled for flowcrypt.com accounts, can you please use some other account, like flowcrypt.compatibility

[martgil]

Den, I successfully received the feedback from your non-corporate email:

[DenBond7]

@martgil Please also check this error

2024-12-30 11:50:12.487 okhttp.OkHttpClient  com...email.debug  I  <-- 500 Server Error https://flowcrypt.com/shared-tenant-fes/api/v1/account/feedback (326ms)
2024-12-30 11:50:12.488 okhttp.OkHttpClient  com...email.debug  I  Date: Mon, 30 Dec 2024 09:50:13 GMT
2024-12-30 11:50:12.488 okhttp.OkHttpClient  com...email.debug  I  Content-Type: application/json
2024-12-30 11:50:12.488 okhttp.OkHttpClient  com...email.debug  I  Connection: keep-alive
2024-12-30 11:50:12.488 okhttp.OkHttpClient  com...email.debug  I  Access-Control-Allow-Origin: *
2024-12-30 11:50:12.488 okhttp.OkHttpClient  com...email.debug  I  X-Frame-Options: SAMEORIGIN
2024-12-30 11:50:12.488 okhttp.OkHttpClient  com...email.debug  I  Strict-Transport-Security: max-age=63072000; includeSubDomains; preload
2024-12-30 11:50:12.489 okhttp.OkHttpClient  com...email.debug  I  {"code":500,"message":"Illegal base64 character a","details":"java.lang.IllegalArgumentException: Illegal base64 character a\n\tat java.base/java.util.Base64$Decoder.decode0(Base64.java:848)\n\tat java.base/java.util.Base64$Decoder.decode(Base64.java:566)\n\tat java.base/java.util.Base64$Decoder.decode(Base64.java:589)\n\tat com.flowcrypt.shared.extensions.kotlin.StringKt.base64Decode(String.kt:14)\n\tat com.flowcrypt.fes.server.handlers.api.feedback.AccountFeedbackPost.handler(AccountFeedbackPost.kt:71)\n\tat com.flowcrypt.shared.server.handlers.EndpointHandler.handle(EndpointHandler.kt:65)\n\tat io.javalin.router.Endpoint.handle(Endpoint.kt:52)\n\tat io.javalin.router.ParsedEndpoint.handle(ParsedEndpoint.kt:15)\n\tat io.javalin.http.servlet.DefaultTasks.HTTP$lambda$9$lambda$7$lambda$6(DefaultTasks.kt:52)\n\tat io.javalin.http.servlet.JavalinServlet.handleTask(JavalinServlet.kt:99)\n\tat io.javalin.http.servlet.JavalinServlet.handleSync(JavalinServlet.kt:64)\n\tat io.javalin.http.servlet.JavalinServlet.handle(JavalinServlet.kt:50)\n\tat io.javalin.http.servlet.JavalinServlet.service(JavalinServlet.kt:30)\n\tat jakarta.servlet.http.HttpServlet.service(HttpServlet.java:587)\n\tat io.javalin.jetty.JavalinJettyServlet.service(JavalinJettyServlet.kt:52)\n\tat jakarta.servlet.http.HttpServlet.service(HttpServlet.java:587)\n\tat org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:764)\n\tat org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:529)\n\tat org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)\n\tat org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1580)\n\tat org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)\n\tat org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1381)\n\tat org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:176)\n\tat org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:484)\n\tat org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1553)\n\tat org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:174)\n\tat org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1303)\n\tat org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:129)\n\tat org.eclipse.jetty.server.handler.StatisticsHandler.handle(StatisticsHandler.java:173)\n\tat org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:122)\n\tat org.eclipse.jetty.server.Server.handle(Server.java:563)\n\tat org.eclipse.jetty.server.HttpChannel$RequestDispatchable.dispatch(HttpChannel.java:1598)\n\tat org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:753)\n\tat org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:501)\n\tat org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:287)\n\tat org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:314)\n\tat org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:100)\n\tat org.eclipse.jetty.io.SelectableChannelEndPoint$1.run(SelectableChannelEndPoint.java:53)\n\tat org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.runTask(AdaptiveExecutionStrategy.java:421)\n\tat org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.consumeTask(AdaptiveExecutionStrategy.java:390)\n\tat org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.tryProduce(AdaptiveExecutionStrategy.java:277)\n\tat org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.run(AdaptiveExecutionStrategy.java:199)\n\tat org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:411)\n\tat org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:969)\n\tat org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1194)\n\tat org.eclipse.jetty.util.thread.QueuedThreadPo
2024-12-30 11:50:12.489 okhttp.OkHttpClient  com...email.debug  I  ol$Runner.run(QueuedThreadPool.java:1149)\n\tat java.base/java.lang.Thread.run(Thread.java:840)\n"}
2024-12-30 11:50:12.489 okhttp.OkHttpClient  com...email.debug  I  <-- END HTTP (4099-byte body)

it looks like I can't send feedback with a screenshot

[martgil]

@DenBond7, were you able to share the HTTP request as well?

[DenBond7]

@DenBond7, were you able to share the HTTP request as well?

Sure. Also, just in case here is the code(how I prepare base64 string)

flowcrypt-android/FlowCrypt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/SendFeedbackViewModel.kt

Line 34 in b121724

fun postFeedback(

logs.txt

curl.txt

[martgil]

Got it, I'll just do several tests with the current implementation we have on the Production android app and try to compare them. I'll get back to you as soon as possible.