Password-protected messages compliance issue

[sosnovsky]

I added test-feature string to array of disallowed strings, but Android app still allows to send password-protected messages with test-feature subject. Maybe regex generator splits string and expects test and feature as separate words?

Browser extension implementation handles this case correctly - showing error alert.
Currently test-feature is in the list of disallowed strings for @flowcrypt.com email accounts, so you can test it with your real FlowCrypt email.

[sosnovsky]

Hi @DenBond7, can you please check this one, thanks!

[DenBond7]

Hi @sosnovsky

I added test-feature string to array of disallowed strings, but Android app still allows to send password-protected messages with test-feature subject. Maybe regex generator splits string and expects test and feature as separate words?

Based on #2906 (comment) we allow password protected messages for test-feature term. Restriction will work for the following cases(for example):

• [test-feature]
• before [test-feature] after

But I think I understand what you are looking for. I've updated the code.

flowcrypt-android/FlowCrypt/src/test/java/com/flowcrypt/email/api/retrofit/response/model/ClientConfigurationTest.kt

Line 18 in 9cd5443

val clientConfiguration = ClientConfiguration(

val matchingSubjects = listOf(
      "[Classification: Data Control: Internal Data Control] Quarter results",
      "Conference information [Classification: Data Control: Internal Data Control]",
      "[Classification: Data Control: Internal Data Control]",
      "aaaa[Classification: Data Control: Internal Data Control]bbb",
      "[droid]",
      "check -droid- case",
      "TEST-FEATURE",
      "[test-feature}",
      "before {test-feature}",
      "[test-feature] after",
      "before [test-feature} after",
      "test-feature",
      "test-feature after",
      "before test-feature",
      "before test-feature after",
      "before TEST-feature after",
      "before {TEST-feature} after"
    )

    val nonMatchingSubjects = listOf(
      "[1Classification: Data Control: Internal Data Control] Quarter results",
      "Conference information [1Classification: Data Control: Internal Data Control]",
      "[1Classification: Data Control: Internal Data Control]",
      "aaaa[1Classification: Data Control: Internal Data Control]bbb",
      "Microdroid androids",
      "beforetest-feature",
      "test-featureafter",
      "beforetest-featureafter",
      "before {TEST-feature}after",
      "before{TEST-feature} after",
      "before{TEST-feature}after"
    )

regex: ((^|\s)+[^\sa-zA-Z0-9_]test-feature[^\sa-zA-Z0-9_]($|\s)+)|((^|\s)+test-feature($|\s)+)

//match
TEST-FEATURE
[test-feature}
before {test-feature}
[test-feature] after
before [test-feature} after
test-feature
test-feature after
before test-feature
before test-feature after
before TEST-feature after
before {TEST-feature} after
//not match
test-featureafter
beforetest-feature
test-featureafter
beforetest-featureafter
before {TEST-feature}after
before{TEST-feature} after

https://regex101.com/r/fwv131/1

What do you think?

[sosnovsky]

Updated list looks great, handles more cases, thanks!