Re-fetch client configuration before sending password-protected messages

[sosnovsky]

Currently client configuration is fetched only on app launch (is it correct for Android?), and as app can be kept in Android memory for a long time, client configuration can become outdated.

After recent addition of password-protected messages compliance functionality (#2906), it's important to have up to date client configuration before sending password-protected message.

To fix it, let's implement client configuration re-fetch when sending password-protected message, so app will have the latest version of disallowPasswordMessagesForTerms array.
For now, re-fetch should be performed only in enterprise builds.

+ update ui test

iOS - FlowCrypt/flowcrypt-ios#2658

[sosnovsky]

Hi @DenBond7, let's work on this issue next, to include it in the 1.6.2 build and send it to testing on the next week.
Will such timing work for you?

[DenBond7]

Currently client configuration is fetched only on app launch (is it correct for Android?),

Not exactly. Please look at #1375 (comment)

Hi @DenBond7, let's work on this issue next, to include it in the 1.6.2 build and send it to testing on the next week.
Will such timing work for you?

I should close this issue by the middle of next week 100%. But I still don't like the existing draft functionality after migration to threads view. I hope we will be ready for a new release by the end of the next week.

[sosnovsky]

Not exactly. Please look at #1375 (comment)

Thanks, I remembered that it's a bit different from iOS, but didn't find such implementation details.

I should close this issue by the middle of next week 100%. But I still don't like the existing draft functionality after migration to threads view. I hope we will be ready for a new release by the end of the next week.

Got it, please let me know if it'll take longer than expected, I'll notify customer about possible delay. Thanks!

[DenBond7]

I have a few questions ))

it's important to have up to date client configuration before sending password-protected message.

1. Does it mean we have to re-fetch client configuration every time when a user opens the compose message screen?

To fix it, let's implement client configuration re-fetch when sending password-protected message, so app will have the latest version of disallowPasswordMessagesForTerms array.

2. Or should we re-fetch client configuration only when we can detect that a user is creating a password-protected message?
3. How to handle a situation when fetching client configuration fails? Just ignore and use the last one from the local cache?

[sosnovsky]

Or should we re-fetch client configuration only when we can detect that a user is creating a password-protected message?

It should be re-fetched only before sending of password-protected message.
So need to check if array of sending messages includes password-protected message, and in this case perform request to /client-configuration to refresh client configuration.

How to handle a situation when fetching client configuration fails? Just ignore and use the last one from the local cache?

Yes, let's just ignore it and use the last one, but it should be quite rare case.