made tests consistent

Author: manikyabard

test/rowtransforms.jl

@@ -9,7 +9,6 @@ include("imports.jl")
     normdict = Dict(:col1 => (col1_mean, col1_std), :col3 => (col3_mean, col3_std))
 
     tfm = NormalizeRow(normdict, cols_to_normalize)
-    # @test_nowarn apply(tfm, item)
     testapply(tfm, item)
     titem = apply(tfm, item)
     @test titem.data[:col1] == (item.data[:col1] - col1_mean)/col1_std
@@ -18,29 +17,30 @@ end
 
 @testset ExtendedTestSet "`FillMissing`" begin
     cols = [:col1, :col2, :col3]
-    item = TabularItem((; zip(cols, [1, missing, missing])...), cols)
+    item = TabularItem(NamedTuple(zip(cols, [1, missing, missing])), cols)
     cols_to_fill = [:col1, :col3]
     col1_fmval = 1000.
+    col2_fmval = "d"
     col3_fmval = 1000.
-    fmdict = Dict(:col1 => col1_fmval, :col3 => col3_fmval)
+    fmdict = Dict(:col1 => col1_fmval, :col2 => col2_fmval, :col3 => col3_fmval)
 
     tfm1 = FillMissing(fmdict, cols_to_fill)
     @test_nowarn apply(tfm1, item)
     titem = apply(tfm1, item)
     @test titem.data[:col1] == coalesce(item.data[:col1], col1_fmval)
-    @test titem.data[:col3] == (ismissing(item.data[:col3]) ? col3_fmval : item.data[:col3])
+    @test titem.data[:col3] == coalesce(item.data[:col3], col3_fmval)
     @test ismissing(titem.data[:col2])
 
-    fmdict[:col2] = "d"
-    tfm2 = FillMissing(fmdict, [:col1, :col2, :col3])
+    push!(cols_to_fill, :col2)
+    tfm2 = FillMissing(fmdict, cols_to_fill)
     testapply(tfm2, item)
     titem2 = apply(tfm2, item)
-    @test titem2.data[:col2] == (ismissing(item.data[:col2]) ? "d" : item.data[:col2])
+    @test titem2.data[:col2] == coalesce(item.data[:col2], "d")
 end
 
 @testset ExtendedTestSet "`Categorify`" begin
     cols = [:col1, :col2, :col3, :col4]
-    item = TabularItem((; zip(cols, [1, "a", "A", missing])...), cols)
+    item = TabularItem(NamedTuple(zip(cols, [1, "a", "A", missing])), cols)
     cols_to_categorify = [:col2, :col3, :col4]
 
     categorydict = Dict(:col2 => ["a", "b", "c"], :col3 => ["C", "B", "A"], :col4 => [missing, 10, 20])