From 4923df214431d64b13a9515f506f3420eb0e59f6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Chris=20W=C3=A4chter?= <cw@format-d.com>
Date: Mon, 14 Oct 2024 12:00:25 +0200
Subject: [PATCH 1/4] fix: set variable with default value

in case of catch during try default value will be returned
---
 Classes/Service/HubSpotService.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Classes/Service/HubSpotService.php b/Classes/Service/HubSpotService.php
index 57f6d2c..d1cb176 100644
--- a/Classes/Service/HubSpotService.php
+++ b/Classes/Service/HubSpotService.php
@@ -56,6 +56,8 @@ public function submitForm(string $formGuid, array $formFields, array $context,
 			],
 		];
 
+        $response = null;
+
 		try {
 			$response = $this->hubspotApi->apiRequest($requestOptions);
 		} catch (\GuzzleHttp\Exception\ClientException $e) {

From bf3f66ccf340a8a4ce740eb6ac8aac0fa0a334af Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Chris=20W=C3=A4chter?= <cw@format-d.com>
Date: Tue, 15 Oct 2024 10:11:09 +0200
Subject: [PATCH 2/4] fix: remove try catch in submitForm

we want more than a logging when error during form submit occurs
---
 Classes/Service/HubSpotService.php | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/Classes/Service/HubSpotService.php b/Classes/Service/HubSpotService.php
index d1cb176..79bd408 100644
--- a/Classes/Service/HubSpotService.php
+++ b/Classes/Service/HubSpotService.php
@@ -56,15 +56,7 @@ public function submitForm(string $formGuid, array $formFields, array $context,
 			],
 		];
 
-        $response = null;
-
-		try {
-			$response = $this->hubspotApi->apiRequest($requestOptions);
-		} catch (\GuzzleHttp\Exception\ClientException $e) {
-            $this->logger->error('Error during form submit to HubSpot: '. $e->getMessage());
-		}
-
-		return $response;
+        return $this->hubspotApi->apiRequest($requestOptions);
 	}
 
 }

From 9659e099d3b8ba456a2f51f00bc25995bf237426 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Chris=20W=C3=A4chter?= <cw@format-d.com>
Date: Mon, 3 Mar 2025 14:26:17 +0100
Subject: [PATCH 3/4] refactor: use namespace from Psr

---
 Classes/Service/HubSpotService.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Classes/Service/HubSpotService.php b/Classes/Service/HubSpotService.php
index 79bd408..3dac1fb 100644
--- a/Classes/Service/HubSpotService.php
+++ b/Classes/Service/HubSpotService.php
@@ -4,6 +4,7 @@
 
 use HubSpot\Discovery\Discovery;
 use Neos\Flow\Annotations as Flow;
+use Psr\Http\Message\ResponseInterface;
 use Psr\Log\LoggerInterface;
 
 /**
@@ -41,9 +42,9 @@ public function initializeObject(): void {
 	 * @param array $formFields
 	 * @param array $context
 	 * @param array $legalConsentOptions
-	 * @return \Psr\Http\Message\ResponseInterface
+	 * @return ResponseInterface
 	 */
-	public function submitForm(string $formGuid, array $formFields, array $context, array $legalConsentOptions): \Psr\Http\Message\ResponseInterface {
+	public function submitForm(string $formGuid, array $formFields, array $context, array $legalConsentOptions): ResponseInterface {
 
 		$requestOptions = [
 			'method' => 'POST',

From b10f7e29b70d056aa353930c0a4d656d88b64f2c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Chris=20W=C3=A4chter?= <cw@format-d.com>
Date: Mon, 3 Mar 2025 18:04:26 +0100
Subject: [PATCH 4/4] chore: remove logger injection

---
 Classes/Service/HubSpotService.php | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/Classes/Service/HubSpotService.php b/Classes/Service/HubSpotService.php
index 3dac1fb..65bc903 100644
--- a/Classes/Service/HubSpotService.php
+++ b/Classes/Service/HubSpotService.php
@@ -5,7 +5,6 @@
 use HubSpot\Discovery\Discovery;
 use Neos\Flow\Annotations as Flow;
 use Psr\Http\Message\ResponseInterface;
-use Psr\Log\LoggerInterface;
 
 /**
  * @Flow\Scope("singleton")
@@ -24,12 +23,6 @@ class HubSpotService
 	 */
 	protected Discovery $hubspotApi;
 
-    /**
-     * @Flow\Inject
-     * @var LoggerInterface
-     */
-    protected $logger;
-
 	/**
 	 * @return void
 	 */