Commit f2e761a
committed
Fix flash_version() leaving SPI mux unlocked, turning LED pink
flash_version() sent EC_CMD_FLASH_NOTIFIED with AccessSpi (0x00) to
unlock the SPI flash but never sent AccessSpiDone (0x03) to restore it.
On hx30 (12th Gen), GPIO_0056 is shared between the SPI flash clock
(function 2) and the right-side green charging LED PWM (function 1).
When AccessSpi is sent, the EC switches GPIO_0056 to SPI mode and
disables the LED driver (GPIO_TYPEC_G_DRV2_EN). Without the matching
AccessSpiDone, the green channel stays dead while red and blue continue
normally, turning the white charging LED pink (R+B without G).
Send AccessSpiDone after reading the version to restore the mux,
matching the pattern used by test_ec_flash_read() and
get_entire_ec_flash().
Signed-off-by: Daniel Schaefer <dhs@frame.work>1 parent f9cb1c2 commit f2e761a
1 file changed
+11
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
335 | 335 | | |
336 | 336 | | |
337 | 337 | | |
338 | | - | |
339 | | - | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
340 | 343 | | |
341 | 344 | | |
342 | 345 | | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
343 | 352 | | |
344 | 353 | | |
345 | 354 | | |
| |||
0 commit comments