finalized checks update for version 6.x

Author: Giu Platania

Checks/checks/PIM/Application Architecture/dApplicationComponent - configured by - dSystem.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Check>
   <CheckId>015</CheckId>
-  <CheckDescription>System configured by ApplicationComponent  </CheckDescription>
+  <CheckDescription>System configuring an Application Component  </CheckDescription>
   <QueryToFindElements>
     <Main>SELECT DISTINCT o1.ea_guid AS ItemGuid
 FROM ((((((t_object as o1
@@ -72,12 +72,12 @@ INNER JOIN t_connector as connector ON o.Object_ID = connector.Start_Object_ID
 INNER JOIN t_object AS o2 ON connector.End_Object_ID =  o2.Object_ID
 WHERE o.Stereotype = 'dSystem'
 AND  o2.Stereotype = 'dApplicationComponent'
-AND connector.Stereotype=  'configured by' 
+AND connector.Stereotype=  'dApplicationconfiguredbySystemConfiguration' 
 )</Main>
     <Parameters></Parameters>
   </QueryToCheckFoundElements>
   <WarningType>Warning</WarningType>
-  <Rationale>a 'dApplicationComponent' element should be connected to a 'dSystem' element by a 'configured by' Connector</Rationale>
+  <Rationale>a 'dApplicationComponent' element should be configured by a 'dSystem' element by a 'configured by' Connector</Rationale>
   <ProposedSolution>Create missing connection</ProposedSolution>
   <HelpUrl>https://github.com/FreeTAKTeam/DigitalArchitectureFramework</HelpUrl>
 </Check>

Checks/checks/PIM/Application Architecture/dController - Controlls - dModelClass.xml

@@ -72,7 +72,7 @@ INNER JOIN t_connector as connector ON o.Object_ID = connector.Start_Object_ID
 INNER JOIN t_object AS o2 ON connector.End_Object_ID =  o2.Object_ID
 WHERE o.Stereotype = 'dController' 
 AND  o2.Stereotype = 'dModelClass'
-AND connector.Stereotype=  'Controlls' 
+AND connector.Stereotype=  'dControllerControllsModel'
 )</Main>
     <Parameters></Parameters>
   </QueryToCheckFoundElements>

Checks/checks/PIM/Application Architecture/dController - Governs - dView.xml

@@ -72,7 +72,7 @@ INNER JOIN t_connector as connector ON o.Object_ID = connector.Start_Object_ID
 INNER JOIN t_object AS o2 ON connector.End_Object_ID =  o2.Object_ID
 WHERE o.Stereotype = 'dController' 
 AND  o2.Stereotype = 'dView' 
-AND connector.Stereotype=  'Governs' 
+AND connector.Stereotype=  'dControllerGovernsView'
 )</Main>
     <Parameters></Parameters>
   </QueryToCheckFoundElements>

Checks/checks/PIM/Application Architecture/dController - isImplementedBy - dBusinessUseCase.xml

@@ -72,7 +72,7 @@ INNER JOIN t_connector as connector ON o.Object_ID = connector.Start_Object_ID
 INNER JOIN t_object AS o2 ON connector.End_Object_ID =  o2.Object_ID
 WHERE o.Stereotype = 'dController' 
 AND  o2.Stereotype = 'dBusinessUseCase' 
-AND connector.Stereotype=  'isImplementedBy' 
+AND connector.Stereotype=  'dUseCaseisImplementedByController'
 )</Main>
     <Parameters></Parameters>
   </QueryToCheckFoundElements>

Checks/checks/PIM/Application Architecture/dPhysicalService - Implements - dBusinessService.xml

@@ -72,7 +72,7 @@ INNER JOIN t_connector as connector ON o.Object_ID = connector.Start_Object_ID
 INNER JOIN t_object AS o2 ON connector.End_Object_ID =  o2.Object_ID
 WHERE o.Stereotype = 'dPhysicalService'
 AND  o2.Stereotype = 'dBusinessService'
-AND connector.Stereotype=  'Implements'  
+AND connector.Stereotype=  'dPhysicalServiceImplementsBusinessService'  
 )</Main>
     <Parameters></Parameters>
   </QueryToCheckFoundElements>

Checks/checks/PIM/Business Architecture/Use Cases that are not in exactly one Boundary.xml

@@ -19,8 +19,7 @@ LEFT JOIN
 LEFT JOIN 
     t_package Package_p5 ON Package_p5.Package_id = Package_p4.parent_id
 WHERE 
-    o.Object_Type = 'UseCase'
-    AND      o.Stereotype = 'dBusinessUseCase' </Main>
+   o.Stereotype = 'dBusinessUseCase' </Main>
     <Filters>
       <Change>
 				AND o.ea_guid in (
@@ -88,9 +87,7 @@ SELECT         o.ea_guid
         INNER JOIN             t_diagram d ON d.Diagram_ID = do.Diagram_ID
         INNER JOIN             t_diagramobjects do2 ON do2.Diagram_ID = d.Diagram_ID
         INNER JOIN             t_object o2 ON o2.Object_ID = do2.Object_ID
-        WHERE          o.Object_Type = 'UseCase'
-            AND d.Diagram_Type = 'Use Case'
-            AND               o.Stereotype = 'dBusinessUseCase' 
+        WHERE                 o.Stereotype = 'dBusinessUseCase' 
             AND o2.Object_Type = 'Boundary'
             AND do2.RectRight &gt;= do.RectRight
             AND do2.RectLeft &lt;= do.RectLeft

Checks/checks/PIM/Business Architecture/dBusinessUseCase - is realized by Use Case - dFeature.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Check>
   <CheckId>001</CheckId>
-  <CheckDescription>Feature is realized by Business Use Case </CheckDescription>
+  <CheckDescription> Business Use Case is is realizing Feature</CheckDescription>
   <QueryToFindElements>
     <Main>SELECT DISTINCT o1.ea_guid AS ItemGuid
 FROM ((((((t_object as o1
@@ -72,7 +72,7 @@ INNER JOIN t_connector as connector ON o.Object_ID = connector.Start_Object_ID
 INNER JOIN t_object AS o2 ON connector.End_Object_ID =  o2.Object_ID
 WHERE o.Stereotype = 'dBusinessUseCase'
 AND  o2.Stereotype = 'dFeature'
-AND connector.Stereotype= 'is realized by Use Case'
+AND connector.Stereotype= 'dFeatureIsRealizedByUseCase'
 )</Main>
     <Parameters></Parameters>
   </QueryToCheckFoundElements>

Checks/checks/PIM/Business Architecture/dBusinessUseCase - isDescribedBy - dBusinessService.xml

@@ -72,7 +72,7 @@ INNER JOIN t_connector as connector ON o.Object_ID = connector.Start_Object_ID
 INNER JOIN t_object AS o2 ON connector.End_Object_ID =  o2.Object_ID
 WHERE o.Stereotype = 'dBusinessUseCase' 
 AND  o2.Stereotype = 'dBusinessService'
-AND connector.Stereotype= 'isDescribedBy' 
+AND connector.Stereotype= 'dBizServIsDescribedByUseCase'
 )</Main>
     <Parameters></Parameters>
   </QueryToCheckFoundElements>

Checks/checks/PIM/Technology Architecture/dDeploymentNode - isPhysicallyHostedBy - dApplicationComponent.xml

@@ -72,7 +72,7 @@ INNER JOIN t_connector as connector ON o.Object_ID = connector.Start_Object_ID
 INNER JOIN t_object AS o2 ON connector.End_Object_ID =  o2.Object_ID
 WHERE o.Stereotype = 'dDeploymentNode'
 AND  o2.Stereotype = 'dApplicationComponent'
-AND connector.Stereotype= 'isPhysicallyHostedBy'
+AND connector.Stereotype= 'dApplicationIRunsInNode'
 )</Main>
     <Parameters></Parameters>
   </QueryToCheckFoundElements>

Checks/checks/PSM/Data Architecture/06 - SID without description.xml

@@ -1,19 +1,20 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Check>
   <CheckId>026</CheckId>
-  <CheckDescription>Model Classes without Description</CheckDescription>
+  <CheckDescription>Attribute has no documentation</CheckDescription>
   <QueryToFindElements>
     <Main>
-SELECT o.ea_guid AS ItemGuid
-FROM ((((((t_object o
+SELECT a.ea_guid AS ItemGuid
+FROM ((((((( t_attribute a
+inner join t_object o on o.Object_ID = a.Object_ID)
 INNER JOIN t_package p ON p.Package_ID = o.Package_ID)
 LEFT JOIN t_package Package_p1 ON Package_p1.Package_ID = p.Parent_ID)
 LEFT JOIN t_package Package_p2 ON Package_p2.Package_ID = Package_p1.Parent_ID)
 LEFT JOIN t_package Package_p3 ON Package_p3.Package_ID = Package_p2.Parent_ID)
 LEFT JOIN t_package Package_p4 ON Package_p4.Package_ID = Package_p3.Parent_ID)
 LEFT JOIN t_package Package_p5 ON Package_p5.Package_ID = Package_p4.Parent_ID)
-WHERE o.object_type = 'Class'
-AND o.StereoType = 'dModelClass'
+
+WHERE IsOrdered = '0'
 		</Main>
     <Filters>
       <Change>
@@ -55,31 +56,35 @@ AND o.StereoType = 'dModelClass'
     </Filters>
   </QueryToFindElements>
   <QueryToCheckFoundElements>
-    <Main>
-SELECT o.Name AS ItemName
-, 'object' as ItemType
-, o.ea_guid AS ItemGuid
+    <Main>SELECT a.Name AS ItemName
+, 'Attribute' as ItemType
+, a.ea_guid AS ItemGuid
 , o.Object_Type AS ElementType
-, o.StereoType AS ElementStereotype
+, a.StereoType AS ElementStereotype
 , p.Name AS PackageName
-, Package_p1.Name AS PackageParentLevel1
-, Package_p2.Name AS PackageParentLevel2 
-, Package_p3.Name AS PackageParentLevel3
-, Package_p4.Name AS PackageParentLevel4
-, Package_p5.Name AS PackageParentLevel5
-FROM ((((((t_object o
+, package_p1.Name AS PackageParentLevel1
+, package_p2.Name AS PackageParentLevel2 
+, package_p3.Name AS PackageParentLevel3
+, package_p4.Name AS PackageParentLevel4
+, package_p5.Name AS PackageParentLevel5
+FROM (((((((t_attribute a
+INNER JOIN t_object o on o.Object_ID = a.Object_ID)
 INNER JOIN t_package p ON p.Package_ID = o.Package_ID)
-LEFT JOIN t_package Package_p1 ON Package_p1.Package_ID = p.Parent_ID)
-LEFT JOIN t_package Package_p2 ON Package_p2.Package_ID = Package_p1.Parent_ID)
-LEFT JOIN t_package Package_p3 ON Package_p3.Package_ID = Package_p2.Parent_ID)
-LEFT JOIN t_package Package_p4 ON Package_p4.Package_ID = Package_p3.Parent_ID)
-LEFT JOIN t_package Package_p5 ON Package_p5.Package_ID = Package_p4.Parent_ID)
-WHERE o.ea_guid in (#ElementGuids#)
-AND o.note IS NULL
+LEFT JOIN t_package package_p1 ON package_p1.package_ID = p.Parent_ID)
+LEFT JOIN t_package package_p2 ON package_p2.package_ID = package_p1.Parent_ID)
+LEFT JOIN t_package package_p3 ON package_p3.package_ID = package_p2.Parent_ID)
+LEFT JOIN t_package package_p4 on package_p4.package_ID = package_p3.Parent_ID)
+LEFT JOIN t_package package_p5 on package_p5.package_ID = package_p4.Parent_ID)
+WHERE a.ea_guid in (#ElementGuids#)
+AND a.ea_guid IN (
+SELECT a1.ea_guid
+FROM t_attribute AS a1
+where a1.Notes  IS NULL
+)
 		</Main>
     <Parameters></Parameters>
   </QueryToCheckFoundElements>
-  <WarningType>Error</WarningType>
-  <Rationale>All Model Classes must have a Description.</Rationale>
+  <WarningType>Warning</WarningType>
+  <Rationale>All Attribute should have a Description.</Rationale>
   <ProposedSolution>Add a short description to the entity according to the modelling standard</ProposedSolution>
 </Check>