-
Notifications
You must be signed in to change notification settings - Fork 86
Description
1st issue
I believe the lines:
if options.proxy:
handlers.append( urllib2.ProxyHandler( {'http':'http://'+options.proxy}) )
fail to work if the site is https. changing the above to
if options.proxy:
handlers.append( urllib2.ProxyHandler( {'https':'https://'+options.proxy}) )
i was able to make the request work through burp. I'm guessing if urllib2 is using an https handler it will ignore a proxyhanlder set using http.
2nd issue=
The help instructs to use "http://proxy.com" while the if statement is only expecting a domain:port.
Both issues could be fixed by changing the if options.proxy section to:
if options.proxy:
if url.startswith( "https://" ):
handlers.append( urllib2.ProxyHandler( {'https':'https://'+options.proxy}) )
if url.startswith( "http://" ):
handlers.append( urllib2.ProxyHandler( {'http':'http://'+options.proxy}) )
and changing the help for proxy example to -p "site.com:8080"