From af52dd23ae11188a81968116ce93225cde035356 Mon Sep 17 00:00:00 2001 From: Jian HUANG Date: Fri, 27 Jun 2025 15:26:59 -0500 Subject: [PATCH 1/3] add checks for mechanical properties --- .../constitutive/solid/porosity/BiotPorosity.hpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp b/src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp index 54730c0b73c..b9efb8721fc 100644 --- a/src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp +++ b/src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp @@ -190,6 +190,14 @@ class BiotPorosityUpdates : public PorosityBaseUpdates m_bulkModulus[k] = bulkModulus; m_shearModulus[k] = shearModulus; + GEOS_THROW_IF( m_bulkModulus[k] <= 0, + GEOS_FMT( "{}: the rock bulk modulus {} must be strictly positive", getFullName(), k ), + InputError ); + + GEOS_THROW_IF_GT_MSG( m_bulkModulus[k], m_grainBulkModulus[k], + GEOS_FMT( "{}: the rock bulk modulus {} cannot be greater than the grain bulk modulus {}", getFullName(), k ), + InputError ); + m_biotCoefficient[k] = 1.0 - bulkModulus / m_grainBulkModulus[k]; } From 379a197867d4cd93778fc13a0c4511df9c77acdb Mon Sep 17 00:00:00 2001 From: Nicola Castelletto <38361926+castelletto1@users.noreply.github.com> Date: Thu, 12 Feb 2026 17:49:17 -0800 Subject: [PATCH 2/3] Update src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp --- .../constitutive/solid/porosity/BiotPorosity.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp b/src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp index 2108fd32d8a..660ee4585ae 100644 --- a/src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp +++ b/src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp @@ -192,11 +192,11 @@ class BiotPorosityUpdates : public PorosityBaseUpdates GEOS_THROW_IF( m_bulkModulus[k] <= 0, GEOS_FMT( "{}: the rock bulk modulus {} must be strictly positive", getFullName(), k ), - InputError ); + InputError, getDataContext() ); GEOS_THROW_IF_GT_MSG( m_bulkModulus[k], m_grainBulkModulus[k], GEOS_FMT( "{}: the rock bulk modulus {} cannot be greater than the grain bulk modulus {}", getFullName(), k ), - InputError ); + InputError, getDataContext() ); m_biotCoefficient[k] = 1.0 - bulkModulus / m_grainBulkModulus[k]; } From 310b556bf745023c09b562a15b35f9c0c428976c Mon Sep 17 00:00:00 2001 From: Nicola Castelletto <38361926+castelletto1@users.noreply.github.com> Date: Fri, 13 Feb 2026 09:41:49 -0800 Subject: [PATCH 3/3] Apply suggestion from @castelletto1 --- .../constitutive/solid/porosity/BiotPorosity.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp b/src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp index 660ee4585ae..2108fd32d8a 100644 --- a/src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp +++ b/src/coreComponents/constitutive/solid/porosity/BiotPorosity.hpp @@ -192,11 +192,11 @@ class BiotPorosityUpdates : public PorosityBaseUpdates GEOS_THROW_IF( m_bulkModulus[k] <= 0, GEOS_FMT( "{}: the rock bulk modulus {} must be strictly positive", getFullName(), k ), - InputError, getDataContext() ); + InputError ); GEOS_THROW_IF_GT_MSG( m_bulkModulus[k], m_grainBulkModulus[k], GEOS_FMT( "{}: the rock bulk modulus {} cannot be greater than the grain bulk modulus {}", getFullName(), k ), - InputError, getDataContext() ); + InputError ); m_biotCoefficient[k] = 1.0 - bulkModulus / m_grainBulkModulus[k]; }