More bubble hidden on reuse (#1417)

rnystrom · web-flow · commit 898bddbe5a84 · 2018-01-14T19:26:52.000-05:00
diff --git a/Classes/Issues/Comments/IssueCommentBaseCell.swift b/Classes/Issues/Comments/IssueCommentBaseCell.swift
@@ -158,7 +158,7 @@ class IssueCommentBaseCell: UICollectionViewCell, UIGestureRecognizerDelegate {
 
             collapseButton.center = CGPoint(
                 x: collapseFrame.width / 2,
-                y: collapseFrame.minY + collapseButton.bounds.height / 2 - 3
+                y: collapseFrame.maxY - collapseButton.bounds.height / 2 - 1
             )
         }
     }
@@ -171,6 +171,12 @@ class IssueCommentBaseCell: UICollectionViewCell, UIGestureRecognizerDelegate {
         set { backgroundLayer.fillColor = newValue?.cgColor}
     }
 
+    override func prepareForReuse() {
+        super.prepareForReuse()
+        collapseLayer.isHidden = true
+        collapseButton.isHidden = true
+    }
+
     // MARK: Private API
 
     @objc private func onDoubleTap() {

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ class IssueCommentBaseCell: UICollectionViewCell, UIGestureRecognizerDelegate {`
`158`	`158`
`159`	`159`	`collapseButton.center = CGPoint(`
`160`	`160`	`x: collapseFrame.width / 2,`
`161`		`- y: collapseFrame.minY + collapseButton.bounds.height / 2 - 3`
	`161`	`+ y: collapseFrame.maxY - collapseButton.bounds.height / 2 - 1`
`162`	`162`	`)`
`163`	`163`	`}`
`164`	`164`	`}`
`@@ -171,6 +171,12 @@ class IssueCommentBaseCell: UICollectionViewCell, UIGestureRecognizerDelegate {`
`171`	`171`	`set { backgroundLayer.fillColor = newValue?.cgColor}`
`172`	`172`	`}`
`173`	`173`
	`174`	`+ override func prepareForReuse() {`
	`175`	`+ super.prepareForReuse()`
	`176`	`+ collapseLayer.isHidden = true`
	`177`	`+ collapseButton.isHidden = true`
	`178`	`+ }`
	`179`	`+`
`174`	`180`	`// MARK: Private API`
`175`	`181`
`176`	`182`	`@objc private func onDoubleTap() {`