disable uncollapse when menu visible (#1413)

Author: rnystrom

Classes/Issues/Comments/IssueCommentSectionController.swift

@@ -25,6 +25,7 @@ IssueCommentDoubleTapDelegate {
     private let model: IssueDetailsModel
     private var hasBeenDeleted = false
     private let autocomplete: IssueCommentAutocomplete
+    private var menuVisible = false
 
     private lazy var webviewCache: WebviewCellHeightCache = {
         return WebviewCellHeightCache(sectionController: self)
@@ -131,7 +132,7 @@ IssueCommentDoubleTapDelegate {
 
     @discardableResult
     private func uncollapse() -> Bool {
-        guard collapsed else { return false }
+        guard collapsed, !menuVisible else { return false }
         collapsed = false
         clearCollapseCells()
         update(animated: trueUnlessReduceMotionEnabled)
@@ -383,6 +384,14 @@ IssueCommentDoubleTapDelegate {
 
     // MARK: IssueCommentReactionCellDelegate
 
+    func willShowMenu(cell: IssueCommentReactionCell) {
+        menuVisible = true
+    }
+
+    func didHideMenu(cell: IssueCommentReactionCell) {
+        menuVisible = false
+    }
+
     func didAdd(cell: IssueCommentReactionCell, reaction: ReactionContent) {
         // don't add a reaction if already reacted
         guard let reactions = reactionMutation ?? self.object?.reactions,

Classes/Issues/Comments/Reactions/IssueCommentReactionCell.swift

@@ -11,6 +11,8 @@ import SnapKit
 import IGListKit
 
 protocol IssueCommentReactionCellDelegate: class {
+    func willShowMenu(cell: IssueCommentReactionCell)
+    func didHideMenu(cell: IssueCommentReactionCell)
     func didAdd(cell: IssueCommentReactionCell, reaction: ReactionContent)
     func didRemove(cell: IssueCommentReactionCell, reaction: ReactionContent)
 }
@@ -62,6 +64,20 @@ UICollectionViewDelegateFlowLayout {
             make.left.equalTo(addButton.snp.right).offset(Styles.Sizes.columnSpacing)
             make.top.bottom.right.equalTo(contentView)
         }
+
+        let nc = NotificationCenter.default
+        nc.addObserver(
+            self,
+            selector: #selector(onMenuControllerWillShow(notification:)),
+            name: NSNotification.Name.UIMenuControllerWillShowMenu,
+            object: nil
+        )
+        nc.addObserver(
+            self,
+            selector: #selector(onMenuControllerDidHide(notification:)),
+            name: NSNotification.Name.UIMenuControllerDidHideMenu,
+            object: nil
+        )
     }
 
     required init?(coder aDecoder: NSCoder) {
@@ -172,6 +188,16 @@ UICollectionViewDelegateFlowLayout {
         data.cell.iterate(add: add)
     }
 
+    // MARK: Notifications
+
+    @objc func onMenuControllerWillShow(notification: Notification) {
+        delegate?.willShowMenu(cell: self)
+    }
+
+    @objc func onMenuControllerDidHide(notification: Notification) {
+        delegate?.didHideMenu(cell: self)
+    }
+
     // MARK: ListBindable
 
     func bindViewModel(_ viewModel: Any) {