sync version

Goraved · Goraved · commit 2bfd766e154c · 2020-11-14T16:29:09.000+02:00
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -0,0 +1,2 @@
+# Add required reviewers
+* @Goraved
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -0,0 +1,20 @@
+## Main idea of the pull request
+
+{text}
+
+## Changes proposed in the pull request (required)
+
+1.
+2.
+3.
+
+## Links & attachments (optional)
+
+ -
+ -
+ 
+ 
+ ### Notes:
+ - @Goraved should be added to the assignees;
+ - Tests should be passed;
+ - Linter should be passed.
diff --git a/.github/workflows/pylint.yml b/.github/workflows/pylint.yml
@@ -0,0 +1,23 @@
+name: Pylint
+
+on: [push]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Python 3.8
+      uses: actions/setup-python@v1
+      with:
+        python-version: 3.8
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install -r requirements.txt
+    - name: Test with pylint
+      run: |
+        pylint-fail-under *.py **/*.py --fail_under 9.8
+
diff --git a/.github/workflows/pytest.yml b/.github/workflows/pytest.yml
@@ -0,0 +1,25 @@
+name: Python package
+
+on: [push]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: [3.8]
+
+    steps:
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install flake8 pytest
+        if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
+    - name: Test with pytest
+      env:
+        TOKEN: ${{ secrets.TOKEN }}
+        SELENIUM_HUB_HOST: 'http://localhost:4444/wd/hub'
+        GITHUB_RUN: True
+      run: |
+        pytest
diff --git a/.pylintrc b/.pylintrc
@@ -0,0 +1,8 @@
+[FORMAT]
+max-line-length=120
+
+# Docstrings
+disable=C0114,C0115,C0116,W0603
+
+[MASTER]
+init-hook="from pylint.config import find_pylintrc; import os, sys; sys.path.append(os.path.dirname(find_pylintrc()))"
diff --git a/Dockerfile b/Dockerfile
@@ -43,6 +43,7 @@ RUN pip install --upgrade pip && \
     pip install virtualenv && \
     virtualenv --python=/usr/bin/python3 /opt/venv && \
     . /opt/venv/bin/activate && \
-    python3.7 -m pip install -r requirements.txt --quiet
+    python3.7 -m pip install -r requirements.txt --quiet && \
+    python3.7 -m playwright install
 
 WORKDIR /app
diff --git a/README.md b/README.md
@@ -5,11 +5,11 @@ Just a [Playwright Python](https://github.com/Microsoft/playwright-python) tool
 1. Run tests `execute_tests.sh`
 
 ## Notes:
-I didn't enjoy this tool, cause it's very complicated. It totally looks like it just has been translated 
-from JS Playwright and need to wright on Python usign JS style. So annoying. But this tools is pretty 
-fast.
+Pretty interesting and fast-growing tool for test automation. It can have some troubles with the first setup 
+(especially with Docker), but generally this tool faster than Selenium and have pretty nice facade methods out of the box.
 
-Anyway, I won't recommend this tool to young Python AQA engineers.
+It's hard to say if I can recommend this tool to young Python AQA engineers because Selenium is a standard 
+and supports by W3C. But if you have a small project, then it can be a wise choice to use Playwright.
 
 ### [Video](https://drive.google.com/file/d/1K2uUlXASjPOiCbCbYkqmuHN26em7bPHs/view?usp=sharing)
 
diff --git a/execute_tests.sh b/execute_tests.sh
@@ -1,7 +1,9 @@
 #!/usr/bin/env bash
 source venv/bin/activate
-echo "-> Installing dependeincies"
+echo "-> Installing dependencies"
 pip install -r requirements.txt --quiet
+echo "-> Installing Playwright browsers"
+python3.7 -m playwright install
 
 echo "-> Removing old Allure results"
 rm -r allure-results/* || echo "No results"
diff --git a/page_objects/base_page.py b/page_objects/base_page.py
@@ -1,5 +1,5 @@
 import allure
-from playwright.helper import TimeoutError as TE
+from playwright.helper import TimeoutError as TError
 from playwright.page import Page
 
 
@@ -8,46 +8,47 @@ def __init__(self, page: Page):
         self.page = page
 
     @allure.step('Click locator - {locator}')
-    async def click(self, locator):
-        await self.page.click(locator)
+    def click(self, locator: str):
+        self.page.click(locator)
 
     @allure.step('Check checkbox locator - {locator}')
-    async def check(self, locator):
-        await self.page.check(locator)
+    def check(self, locator: str):
+        self.page.check(locator)
 
     @allure.step('Uncheck checkbox locator - {locator}')
-    async def uncheck(self, locator):
-        await self.page.check(locator)
+    def uncheck(self, locator: str):
+        self.page.check(locator)
 
     @allure.step('Hover locator - {locator}')
-    async def hover(self, locator):
-        await self.page.hover(locator)
+    def hover(self, locator: str):
+        self.page.hover(locator)
 
     @allure.step('Go to url - {url}')
-    async def go_to_url(self, url):
-        await self.page.goto(url)
+    def go_to_url(self, url: str):
+        self.page.goto(url)
 
     @allure.step('Type text - {text} into locator - {locator}')
-    async def type(self, locator, text):
-        await self.click(locator)
-        await self.page.fill(locator, text)
+    def type(self, locator: str, text: str):
+        self.click(locator)
+        self.page.fill(locator, text)
 
     @allure.step('Select option - {option} in locator - {locator}')
-    async def select_option(self, locator, option):
-        await self.page.selectOption(locator, option)
+    def select_option(self, locator: str, option: str):
+        self.page.selectOption(locator, option)
 
     @allure.step('Is element - {locator} present')
-    async def is_element_present(self, locator):
+    def is_element_present(self, locator: str) -> bool:
         try:
-            await self.page.waitForSelector(locator)
+            self.page.waitForSelector(locator)
             return True
-        except TE:
+        except TError:
             return False
 
     @allure.step('Is element - {locator} hidden')
-    async def is_element_present(self, locator):
+    def is_element_hidden(self, locator: str) -> bool:
         try:
-            await self.page.waitForSelector(locator, {'state': 'hidden'})
+            self.page.waitForSelector(locator, state='hidden')
             return True
-        except TE:
+        except TError:
             return False
+
diff --git a/page_objects/registation/registration_object.py b/page_objects/registation/registration_object.py
@@ -5,25 +5,25 @@
 
 
 class RegistrationPage(BasePage):
-    async def register_account(self):
-        await self.type(RegistrationLocators.EMAIL_INPUT, f'goraved@{randint(1000, 99999)}.com')
-        await self.click(RegistrationLocators.CREATE_BTN)
-        await self.click(RegistrationLocators.GENDER_OPTION)
-        await self.type(RegistrationLocators.CUSTOMER_FIRST_NAME_INPUT, "Test")
-        await self.type(RegistrationLocators.CUSTOMER_LAST_NAME_INPUT, "Goraved")
-        await self.type(RegistrationLocators.PASSWORD_INPUT, "123asd")
-        await self.select_option(RegistrationLocators.DAYS_SELECTOR, "1")
-        await self.select_option(RegistrationLocators.MONTHS_SELECTOR, "1")
-        await self.select_option(RegistrationLocators.YEARS_SELECTOR, "2020")
-        await self.click(RegistrationLocators.AGREE_CHECKBOX)
-        await self.click(RegistrationLocators.NEWSLETTER_CHECKBOX)
-        await self.type(RegistrationLocators.FIRST_NAME_INPUT, 'Test')
-        await self.type(RegistrationLocators.LAST_NAME_INPUT, 'Goraved')
-        await self.type(RegistrationLocators.ADDRESS_INPUT, "street")
-        await self.type(RegistrationLocators.CITY_INPUT, "test")
-        await self.select_option(RegistrationLocators.STATE_SELECT, "1")
-        await self.type(RegistrationLocators.POSTCODE_INPUT, "11111")
-        await self.type(RegistrationLocators.OTHER_INPUT, "123")
-        await self.type(RegistrationLocators.PHONE_INPUT, "123")
-        await self.click(RegistrationLocators.ALIAS_BTN)
-        await self.click(RegistrationLocators.SUBMIT_ACCOUNT_BTN)
+    def register_account(self):
+        self.type(RegistrationLocators.EMAIL_INPUT, f'goraved@{randint(1000, 99999)}.com')
+        self.click(RegistrationLocators.CREATE_BTN)
+        self.click(RegistrationLocators.GENDER_OPTION)
+        self.type(RegistrationLocators.CUSTOMER_FIRST_NAME_INPUT, "Test")
+        self.type(RegistrationLocators.CUSTOMER_LAST_NAME_INPUT, "Goraved")
+        self.type(RegistrationLocators.PASSWORD_INPUT, "123asd")
+        self.select_option(RegistrationLocators.DAYS_SELECTOR, "1")
+        self.select_option(RegistrationLocators.MONTHS_SELECTOR, "1")
+        self.select_option(RegistrationLocators.YEARS_SELECTOR, "2020")
+        self.click(RegistrationLocators.AGREE_CHECKBOX)
+        self.click(RegistrationLocators.NEWSLETTER_CHECKBOX)
+        self.type(RegistrationLocators.FIRST_NAME_INPUT, 'Test')
+        self.type(RegistrationLocators.LAST_NAME_INPUT, 'Goraved')
+        self.type(RegistrationLocators.ADDRESS_INPUT, "street")
+        self.type(RegistrationLocators.CITY_INPUT, "test")
+        self.select_option(RegistrationLocators.STATE_SELECT, "1")
+        self.type(RegistrationLocators.POSTCODE_INPUT, "11111")
+        self.type(RegistrationLocators.OTHER_INPUT, "123")
+        self.type(RegistrationLocators.PHONE_INPUT, "123")
+        self.click(RegistrationLocators.ALIAS_BTN)
+        self.click(RegistrationLocators.SUBMIT_ACCOUNT_BTN)
diff --git a/page_objects/shop/shop_object.py b/page_objects/shop/shop_object.py
@@ -3,31 +3,31 @@
 
 
 class ShopPage(BasePage):
-    async def open_site(self):
-        await self.go_to_url('http://automationpractice.com/index.php')
-
-    async def open_t_shirt_category(self):
-        await self.click(ShopLocators.T_SHIRT_CATEGORY_BTN)
-
-    async def add_item_to_cart_and_proceed(self):
-        await self.hover(ShopLocators.ITEM_NAME_LBL)
-        await self.click(ShopLocators.ITEM_NAME_LBL)
-        await self.click(ShopLocators.ADD_TO_CART_BTN)
-        await self.click(ShopLocators.PROCEED_TO_CHECKOUT_BTN)
-
-    async def go_to_the_second_cart_step(self):
-        await self.click(ShopLocators.SECOND_CART_STEP_BTN)
-
-    async def finish_order_after_registration(self):
-        await self.click('#center_column > form > p > button')
-        await self.click(ShopLocators.TERMS_CHECKBOX)
-        await self.click('#form > p > button')
-        await self.click(ShopLocators.PAY_WITH_BANK_BTN)
-        await self.click(ShopLocators.CONFIRM_ORDER_BTN)
-
-    async def open_profile_order_page(self):
-        await self.click(ShopLocators.PROFILE_BTN)
-        await self.click(ShopLocators.ORDERS_BTN)
-
-    async def is_order_present(self):
-        return await self.is_element_present(ShopLocators.ORDER_ROW)
+    def open_site(self):
+        self.go_to_url('http://automationpractice.com/index.php')
+
+    def open_t_shirt_category(self):
+        self.click(ShopLocators.T_SHIRT_CATEGORY_BTN)
+
+    def add_item_to_cart_and_proceed(self):
+        self.hover(ShopLocators.ITEM_NAME_LBL)
+        self.click(ShopLocators.ITEM_NAME_LBL)
+        self.click(ShopLocators.ADD_TO_CART_BTN)
+        self.click(ShopLocators.PROCEED_TO_CHECKOUT_BTN)
+
+    def go_to_the_second_cart_step(self):
+        self.click(ShopLocators.SECOND_CART_STEP_BTN)
+
+    def finish_order_after_registration(self):
+        self.click('#center_column > form > p > button')
+        self.click(ShopLocators.TERMS_CHECKBOX)
+        self.click('#form > p > button')
+        self.click(ShopLocators.PAY_WITH_BANK_BTN)
+        self.click(ShopLocators.CONFIRM_ORDER_BTN)
+
+    def open_profile_order_page(self):
+        self.click(ShopLocators.PROFILE_BTN)
+        self.click(ShopLocators.ORDERS_BTN)
+
+    def is_order_present(self):
+        return self.is_element_present(ShopLocators.ORDER_ROW)
diff --git a/requirements.txt b/requirements.txt
@@ -1,5 +1,6 @@
+allure-pytest
 playwright
 pytest
-allure-pytest
 pytest-asyncio
-pytest-xdist
+pylint-fail-under
+pytest-xdist
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -3,7 +3,7 @@
 
 import allure
 import pytest
-from playwright import chromium
+from playwright import sync_playwright
 
 
 # Will mark all the tests as async
@@ -20,23 +20,24 @@ def event_loop():
 
 
 @pytest.fixture(scope='session')
-async def page():
-    if os.getenv('DOCKER_RUN'):
-        browser = await chromium.launch(headless=True, args=['--no-sandbox'])
-    else:
-        browser = await chromium.launch(headless=False)
-    page = await browser.newPage()
-    global PAGE
-    PAGE = page
-    yield page
-    await browser.close()
+def page():
+    with sync_playwright() as play:
+        if os.getenv('DOCKER_RUN'):
+            browser = play.chromium.launch(headless=True, args=['--no-sandbox'])
+        else:
+            browser = play.firefox.launch(headless=False)
+        page = browser.newPage()
+        global PAGE
+        PAGE = page
+        yield page
+        browser.close()
 
 
 PAGE = None
 
 
 @pytest.hookimpl(tryfirst=True, hookwrapper=True)
-def pytest_runtest_makereport(item, call):
+def pytest_runtest_makereport():
     outcome = yield
     test_result = outcome.get_result()
 
@@ -48,6 +49,6 @@ def pytest_runtest_makereport(item, call):
             allure.attach(screenshot, name='screenshot', attachment_type=allure.attachment_type.PNG)
 
 
-async def get_screenshot():
+def get_screenshot():
     global PAGE
-    return await PAGE.screenshot()
+    return PAGE.screenshot()
diff --git a/tests/test_shop.py b/tests/test_shop.py

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+# Add required reviewers`
	`2`	`+* @Goraved`