memory management: library now handles de-initialization

Author: Grok Compression

bindings/rust/examples/initialize_grok.rs

@@ -39,7 +39,6 @@ fn str_to_slice(src: &str) -> Result<[i8; 4096], GrokError> {
 /// Clean up resources safely
 fn cleanup(grk_cparameters: *mut _grk_cparameters) {
     unsafe {
-        grk_deinitialize();
         libc::free(grk_cparameters as *mut libc::c_void);
     }
 }

bindings/swig/README.md

@@ -21,7 +21,6 @@ Now Grok api methods can be imported, for example
 from grok_core import (
     GRK_TILE_CACHE_ALL,
     grk_initialize,
-    grk_deinitialize,
     grk_decompress_parameters,
     grk_decompress_init,
     grk_decompress_read_header,

examples/core/core_compress.cpp

@@ -224,7 +224,6 @@ int main([[maybe_unused]] int argc, [[maybe_unused]] const char** argv)
   // cleanup
   grk_object_unref(codec);
   grk_object_unref(&inputImage->obj);
-  grk_deinitialize();
 
   return rc;
 }

examples/core/core_decompress.cpp

@@ -989,7 +989,6 @@ int main([[maybe_unused]] int argc, [[maybe_unused]] const char** argv)
   // cleanup
   grk_object_unref(codec_diff);
   grk_object_unref(codec_full);
-  grk_deinitialize();
 
   return rc;
 }

examples/core/core_decompress.py

@@ -18,7 +18,6 @@
 from PIL import Image, ImageChops  # Assumes Pillow is installed
 from grok_core import (
     grk_initialize,
-    grk_deinitialize,
     grk_decompress_parameters,
     grk_image_comp,
     grk_object,
@@ -135,7 +134,6 @@ def decompress_image(
         return False
 
     grk_object_unref(codec)
-    grk_deinitialize()
     return True
 
 

examples/core/core_simple.cpp

@@ -220,7 +220,6 @@ int main([[maybe_unused]] int argc, [[maybe_unused]] const char** argv)
   if(encInputImage)
     grk_object_unref(&encInputImage->obj);
   // note: since decImage was allocated by library, it will be cleaned up by library
-  grk_deinitialize();
 
   return rc;
 }

src/lib/codec/apps/GrkCompress.cpp

@@ -870,7 +870,6 @@ int GrkCompress::main(int argc, const char** argv, grk_image* in_image, grk_stre
     goto cleanup;
   }
 cleanup:
-  grk_deinitialize();
 
   return success;
 }

src/lib/codec/apps/GrkDecompress.cpp

@@ -1510,7 +1510,6 @@ int GrkDecompress::main(int argc, const char* argv[])
   }
 cleanup:
   destoryParams(&initParams.parameters);
-  grk_deinitialize();
   return rc;
 }
 

src/lib/codec/apps/GrkDump.cpp

@@ -360,7 +360,6 @@ int GrkDump::main(int argc, const char* argv[])
   grk_object_unref(codec);
   if(fout)
     fclose(fout);
-  grk_deinitialize();
 
   return rc;
 }

src/lib/core/grok.cpp

@@ -108,6 +108,12 @@ static grk_object* grkDecompressCreate(grk::IStream* stream)
   return &codec->obj;
 }
 
+static inline void grk_deinitialize()
+{
+  grk_plugin_cleanup();
+  ExecSingleton::destroy();
+}
+
 static inline bool areStringsEqual(const char* lhs, const char* rhs)
 {
   if(lhs == nullptr && rhs == nullptr)
@@ -157,6 +163,18 @@ void grk_initialize(const char* pluginPath, uint32_t numThreads, bool* plugin_in
         *plugin_initialized = initState_.pluginInitialized_;
       return;
     }
+
+    // Register cleanup once, before doing init work
+    static bool atexit_registered = false;
+    if(!atexit_registered)
+    {
+      if(std::atexit(grk_deinitialize) != 0)
+      {
+        // Handle registration failure (e.g., log error)
+      }
+      atexit_registered = true;
+    }
+
     // 1. set up executor
     ExecSingleton::create(numThreads);
 
@@ -200,12 +218,6 @@ void grk_initialize(const char* pluginPath, uint32_t numThreads, bool* plugin_in
   }
 }
 
-GRK_API void GRK_CALLCONV grk_deinitialize()
-{
-  grk_plugin_cleanup();
-  ExecSingleton::destroy();
-}
-
 GRK_API grk_object* GRK_CALLCONV grk_object_ref(grk_object* obj)
 {
   if(!obj)