Skip to content

Update "models/parflow_pdaf" to v3.14.1-pdaf#123

Merged
jjokella merged 13 commits into
masterfrom
dev-update-parflow-pdaf
Apr 15, 2026
Merged

Update "models/parflow_pdaf" to v3.14.1-pdaf#123
jjokella merged 13 commits into
masterfrom
dev-update-parflow-pdaf

Conversation

@jjokella

@jjokella jjokella commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Triggered by testing env/jsc.2026.gnu.openmpi (#122) for the TSMP-PDAF-testcases.

Parts:

@kvrigor

kvrigor commented Mar 20, 2026

Copy link
Copy Markdown
Member

@jjokella you need this fix in your parflow_pdaf repo: parflow/parflow@6f14cdb

@jjokella

jjokella commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

The ParFlow for PDAF should now contain the HYPRE fix. Now I have a netCDF error

TSMP2/models/parflow_pdaf/pfsimulator/amps/oas3/oas_pfl_define.F90:38:5:

   38 | USE netcdf
      |     1
Fatal Error: Cannot open module file ‘netcdf.mod’ for reading at (1): No such file or directory
compilation terminated.

@kvrigor

kvrigor commented Apr 9, 2026

Copy link
Copy Markdown
Member

@jjokella can you check if you have the same parflow/cmake/modules/FindNetCDF.cmake as upstream Parflow? https://github.com/parflow/parflow/blob/master/cmake/modules/FindNetCDF.cmake

If the issue persists, try adding -DCMAKE_MESSAGE_LOG_LEVEL="DEBUG" in BuildParFlow.cmake:

CMAKE_ARGS -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
-DCMAKE_C_FLAGS=${PF_CFLAGS}
-DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
-DCMAKE_Fortran_COMPILER=${CMAKE_Fortran_COMPILER}
-DCMAKE_Fortran_FLAGS=${PF_FFLAGS}
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
-DPARFLOW_ENABLE_HYPRE=ON
-DPARFLOW_ENABLE_NETCDF=ON
-DPARFLOW_AMPS_SEQUENTIAL_IO=ON
-DPARFLOW_ENABLE_TIMING=TRUE
-DPARFLOW_ACCELERATOR_BACKEND=${PF_ACC_BACKEND}
-DMPIEXEC_EXECUTABLE=${MPIEXEC_EXECUTABLE}
-DMPIEXEC_NUMPROC_FLAG=${MPIEXEC_NUMPROC_FLAG}
-DPARFLOW_ENABLE_SLURM=${ENABLE_SLURM}

We need to see how the ff. variables are set for your build.

# https://github.com/parflow/parflow/blob/c9dd2e392e9162a13e2da38923b3dda233760f76/cmake/modules/FindNetCDF.cmake#L111-L116
message(DEBUG "NETCDF search stragegy: via ${SEARCH_STRATEGY}")
message(DEBUG "NETCDF_DIR=${NETCDF_DIR}")
message(DEBUG "NETCDF_INCLUDE_DIRS=${NETCDF_INCLUDE_DIRS}")
message(DEBUG "NETCDF_LIBRARIES=${NETCDF_LIBRARIES}")
message(DEBUG "NETCDF_HAS_PARALLEL=${NETCDF_HAS_PARALLEL}")
message(DEBUG "NETCDF_VERSION=${NETCDF_VERSION}")

@jjokella jjokella merged commit 6d4cfd5 into master Apr 15, 2026
5 checks passed
@jjokella jjokella deleted the dev-update-parflow-pdaf branch April 15, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants