Skip to content

BuildPDAF: use FindLAPACK result variables for linking #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjokella wants to merge 3 commits into
base: master
Choose a base branch
from
Open

BuildPDAF: use FindLAPACK result variables for linking #131

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a222f23
BuildPDAF: try building PDAF with result variables from FindLAPACK
jjokella Dec 11, 2025
3ffd67a
Merge branch 'master' into dev-pdaf-buildpdaf
jjokella Jun 3, 2026
5cad693
remove comments
jjokella Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions cmake/BuildPDAF.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ endif()
# LAPACK is required
# For eCLM-PDAF, this setting has to be consistent with MKL/LAPACK
# loading in `eCLM/src/clm5/CMakelists.txt`
# https://cmake.org/cmake/help/latest/module/FindLAPACK.html
find_package(LAPACK REQUIRED)
message(STATUS "LAPACK_LIBRARIES: ${LAPACK_LIBRARIES}")
message(STATUS "LAPACK_LINKER_FLAGS: ${LAPACK_LINKER_FLAGS}")

# OpenMP is required
find_package(OpenMP REQUIRED)
Expand Down Expand Up @@ -60,23 +63,8 @@ set(PDAF_DIR "${PDAF_SRC}")

# Set PDAF_LINK_LIBS for Makefile header
# --------------------------------------
# --start-group: libraries inside the group are recalled until, such
# --that order does not matter in the linking command
list(APPEND PDAF_LINK_LIBS "-Wl,--start-group")
list(APPEND PDAF_LINK_LIBS "${mkl_intel_ilp64_file}")
list(APPEND PDAF_LINK_LIBS "${mkl_intel_thread_file}")
list(APPEND PDAF_LINK_LIBS "${mkl_core_file}")
if (CMAKE_CXX_COMPILER_ID STREQUAL "Intel"
OR CMAKE_CXX_COMPILER_ID STREQUAL "IntelLLVM")
list(APPEND PDAF_LINK_LIBS "-qmkl")
elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
list(APPEND PDAF_LINK_LIBS "-mkl")
list(APPEND PDAF_LINK_LIBS "${LAPACK_LIBRARIES}")
message(WARNING "LAPACK_LIBRARIES: ${LAPACK_LIBRARIES}")
else()
message(FATAL_ERROR "Unsupported CMAKE_CXX_COMPILER_ID: ${CMAKE_CXX_COMPILER_ID}")
endif()
list(APPEND PDAF_LINK_LIBS "-Wl,--end-group")
list(APPEND PDAF_LINK_LIBS "${LAPACK_LIBRARIES}")
list(APPEND PDAF_LINK_LIBS "${LAPACK_LINKER_FLAGS}")

# Explicit libraries named in comments should be handed over by the
# variables. For checking this, search `$BUILD_DIR/CMakeCache.txt`.
Expand Down
Loading