Skip to content

Sort button names get out of sync with action #13

Description

@extra808

All buttons start as "sort by {header} in ascending order." If you activate one of the buttons, its name changes to "sort by {header} in descending order." However, all the other button names also change to "sort by {header} in descending order" which is not correct, activating those buttons will still sort in ascending order.

I think the issue is because the text for all buttons is chosen based on the value of sortDir which only reflects the sort direction of the currently sorted column. The Arrow component and aria-sort attribute don't have this problem because they incorporate sortedBy.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions