Skip to content
This repository was archived by the owner on Apr 18, 2024. It is now read-only.

Commit 6a66edf

Browse files
bmarteljuliosgarbihlomzik
authored
chore: 1.8.0 cherrypick 2023 05 31 (#1426)
* fix: LSDV-5192: Change quick view icon and change hover color (#1412) * fix: LSDV-5202: Fix Ranker d-n-d in Preview (#1421) There was a problem with ResizeObserver from our panels, when user moved item to another column making it higher. That happens only in collapsed mode, and ResizeObserver is actually not needed there. --------- Co-authored-by: Julio Sgarbi <julio.sgarbi@hotmail.com> Co-authored-by: hlomzik <hlomzik@gmail.com>
1 parent fb21e6c commit 6a66edf

File tree

3 files changed

+25
-2
lines changed

3 files changed

+25
-2
lines changed

src/components/AnnotationsCarousel/AnnotationsCarousel.styl

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,26 @@
3333
padding 0
3434
height 28px
3535
width 28px
36+
box-shadow: 0 2px 5px 0 rgba(0,0,0,0.2);
37+
38+
&:hover
39+
background #EBF3FC
40+
box-shadow: 0 2px 5px 0 rgba(0,0,0,0.2);
41+
3642
&_disabled
37-
opacity 0.08
43+
background #F0EFF1
44+
45+
svg
46+
opacity .4
47+
48+
&:hover
49+
background #F0EFF1
50+
filter none
51+
3852
.button
53+
&:hover
54+
filter none
55+
3956
&__arrow
4057
&_left
4158
transform rotate(-90deg)

src/components/SidePanels/SidePanels.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -405,6 +405,9 @@ const SidePanelsComponent: FC<SidePanelsProps> = ({
405405
const observer = new ResizeObserver(() => {
406406
const { clientWidth, clientHeight } = root ?? {};
407407

408+
// we don't need to check or resize anything in collapsed state
409+
if (clientWidth <= maxWindowWidth) return;
410+
408411
// Remember current width and height of the viewport
409412
viewportSize.current.width = clientWidth ?? 0;
410413
viewportSize.current.height = clientHeight ?? 0;

src/components/SidePanels/TabPanels/SideTabsPanels.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,10 @@ const SideTabsPanelsComponent: FC<SidePanelsProps> = ({
389389

390390
const observer = new ResizeObserver(() => {
391391
const { clientWidth, clientHeight } = root ?? {};
392-
392+
393+
// we don't need to check or resize anything in collapsed state
394+
if (clientWidth <= maxWindowWidth) return;
395+
393396
if(viewportSize.current.height !== clientHeight) setPanelData(getSnappedHeights(panelData, clientHeight));
394397
// Remember current width and height of the viewport
395398
viewportSize.current.width = clientWidth ?? 0;

0 commit comments

Comments
 (0)