Added UnitTests

Signed-off-by: Subtixx <subtixx@gmail.com>

Author: Subtixx

RCON.sln

@@ -4,6 +4,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "RCONServer", "RCONServer\RC
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "RCONServerLib", "RCONServerLib\RCONServerLib.csproj", "{2EFA0311-14CE-414B-9867-FC0D1FF6F6C4}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "RCONServerLib.Tests", "RCONServerLib.Tests\RCONServerLib.Tests.csproj", "{5C204D9A-D264-43E3-9270-0D0E7F21C87E}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -18,5 +20,9 @@ Global
 		{2EFA0311-14CE-414B-9867-FC0D1FF6F6C4}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{2EFA0311-14CE-414B-9867-FC0D1FF6F6C4}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{2EFA0311-14CE-414B-9867-FC0D1FF6F6C4}.Release|Any CPU.Build.0 = Release|Any CPU
+		{5C204D9A-D264-43E3-9270-0D0E7F21C87E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{5C204D9A-D264-43E3-9270-0D0E7F21C87E}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{5C204D9A-D264-43E3-9270-0D0E7F21C87E}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{5C204D9A-D264-43E3-9270-0D0E7F21C87E}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 EndGlobal

RCONServerLib.Tests/RCONServerLib.Tests.csproj

@@ -0,0 +1,15 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <TargetFramework>netcoreapp2.0</TargetFramework>
+    <IsPackable>false</IsPackable>
+  </PropertyGroup>
+  <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.5.0" />
+    <PackageReference Include="xunit" Version="2.3.1" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
+    <DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
+  </ItemGroup>
+  <ItemGroup>
+    <ProjectReference Include="..\RCONServerLib\RCONServerLib.csproj" />
+  </ItemGroup>
+</Project>

RCONServerLib.Tests/RconPacketTests.cs

@@ -0,0 +1,58 @@
+using System;
+using System.Net.Http.Headers;
+using Xunit;
+
+namespace RCONServerLib.Tests
+{
+    public class RconPacketTests
+    {
+        [Fact]
+        public void RconPacketLengthTest()
+        {
+            Assert.Throws<LengthMismatchException>(() => new RemoteConPacket(new byte[] {0xFF, 0xFF, 0x00, 0x00}));
+        }
+        
+        [Fact]
+        public void RconPacketTypeTest()
+        {
+            Assert.Throws<InvalidPacketTypeException>(() => new RemoteConPacket(new byte[]
+            {
+                0x08, 0x00, 0x00, 0x00, // Size
+                0x00, 0x00, 0x00, 0x00, // Id
+                0xFF, 0xFF, 0x00, 0x00, // Type
+            }));
+        }
+        
+        [Fact]
+        public void RconPacketNullTerminatorEndTest()
+        {
+            Assert.Throws<NullTerminatorMissingException>(() => new RemoteConPacket(new byte[]
+            {
+                0x0A, 0x00, 0x00, 0x00, // Size
+                0x00, 0x00, 0x00, 0x00, // Id
+                0x00, 0x00, 0x00, 0x00, // Type
+                0x00, // Payload
+                0x01, // Null-terminator end
+            }));
+        }
+        
+        [Fact]
+        public void RconPacketTooLongTest()
+        {
+            byte[] bytes = new byte[4096];
+            Array.Copy(new byte[]
+            {
+                0xFC, 0x0F, 0x00, 0x00, // Size - 4092
+                0x00, 0x00, 0x00, 0x00,
+                0x00, 0x00, 0x00, 0x00,
+            }, 0, bytes, 0, 12);
+            bytes[4094] = 0x00;
+            bytes[4095] = 0x00;
+            for (var i = 13; i < 4094; i++)
+            {
+                bytes[i] = 0xFF;
+            }
+            Assert.Throws<NullTerminatorMissingException>(() => new RemoteConPacket(bytes));
+        }
+    }
+}

RCONServerLib/Properties/AssemblyInfo.cs

@@ -1,4 +1,5 @@
 using System.Reflection;
+using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 // General Information about an assembly is controlled through the following 
@@ -21,6 +22,8 @@
 // The following GUID is for the ID of the typelib if this project is exposed to COM
 [assembly: Guid("2EFA0311-14CE-414B-9867-FC0D1FF6F6C4")]
 
+[assembly:InternalsVisibleTo("RCONServerLib.Tests")]
+
 // Version information for an assembly consists of the following four values:
 //
 //      Major Version

RCONServerLib/RemoteConPacket.cs

@@ -51,24 +51,24 @@ public RemoteConPacket(byte[] packetBytes)
 
                     // The size field (4-Bytes Little Endian Int) is, according to specification, not included.
                     if (Size + 4 != packetBytes.Length)
-                        throw new Exception("packet length mismatch");
+                        throw new LengthMismatchException("packet length mismatch");
 
                     Id = reader.ReadInt32LittleEndian();
                     var packetType = reader.ReadInt32LittleEndian();
                     if (!Enum.IsDefined(typeof(PacketType), packetType))
-                        throw new Exception("Invalid packet type");
+                        throw new InvalidPacketTypeException("Invalid packet type");
                     Type = (PacketType) Enum.ToObject(typeof(PacketType), packetType);
                     Payload = reader.ReadAscii();
 
                     // Get payload length by subtracting 9 bytes (ID 4-Bytes, Type 4-Bytes, Null-terminator 1-Byte)
                     if (Encoding.ASCII.GetByteCount(Payload) > Size - 9)
-                        throw new Exception("Payload length mismatch");
+                        throw new LengthMismatchException("Payload length mismatch");
 
                     var nullTerminator = reader.ReadByte();
-                    if(nullTerminator != 0x00)
-                        throw new Exception("Missing last null-terminator");
-                    
-                    if(reader.BaseStream.Position != reader.BaseStream.Length)
+                    if (nullTerminator != 0x00)
+                        throw new NullTerminatorMissingException("Missing last null-terminator");
+
+                    if (reader.BaseStream.Position != reader.BaseStream.Length)
                         throw new Exception("More data to read");
                 }
             }
@@ -79,6 +79,8 @@ public RemoteConPacket(int id, PacketType type, string payload)
             Payload = payload;
             Id = id;
             Type = type;
+            if (Length > 4096)
+                throw new PacketTooLongException();
         }
 
         /// <summary>
@@ -104,4 +106,32 @@ public byte[] GetBytes()
             }
         }
     }
+
+    public class PacketTooLongException : Exception
+    {
+        public PacketTooLongException() : base()
+        {
+        }
+    }
+
+    public class NullTerminatorMissingException : Exception
+    {
+        public NullTerminatorMissingException(string message) : base(message)
+        {
+        }
+    }
+
+    public class LengthMismatchException : Exception
+    {
+        public LengthMismatchException(string message) : base(message)
+        {
+        }
+    }
+
+    public class InvalidPacketTypeException : Exception
+    {
+        public InvalidPacketTypeException(string message) : base(message)
+        {
+        }
+    }
 }