Skip to content

Commit 1096909

Browse files
author
Denys Zaiats
committed
[1.4.1-fix] - fixed error message for Grid verification
1 parent f1b9c01 commit 1096909

File tree

3 files changed

+66
-64
lines changed

3 files changed

+66
-64
lines changed

‎pom.xml‎

Lines changed: 58 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -39,68 +39,68 @@
3939
<maven.compiler.target>1.8</maven.compiler.target>
4040
</properties>
4141

42-
<!--<build>-->
43-
<!--<plugins>-->
44-
<!--<plugin>-->
45-
<!--<groupId>org.apache.maven.plugins</groupId>-->
46-
<!--<artifactId>maven-gpg-plugin</artifactId>-->
47-
<!--<executions>-->
48-
<!--<execution>-->
49-
<!--<id>sign-artifacts</id>-->
50-
<!--<phase>verify</phase>-->
51-
<!--<goals>-->
52-
<!--<goal>sign</goal>-->
53-
<!--</goals>-->
54-
<!--</execution>-->
55-
<!--</executions>-->
56-
<!--</plugin>-->
42+
<build>
43+
<plugins>
44+
<plugin>
45+
<groupId>org.apache.maven.plugins</groupId>
46+
<artifactId>maven-gpg-plugin</artifactId>
47+
<executions>
48+
<execution>
49+
<id>sign-artifacts</id>
50+
<phase>verify</phase>
51+
<goals>
52+
<goal>sign</goal>
53+
</goals>
54+
</execution>
55+
</executions>
56+
</plugin>
5757

58-
<!--<plugin>-->
59-
<!--<groupId>org.sonatype.plugins</groupId>-->
60-
<!--<artifactId>nexus-staging-maven-plugin</artifactId>-->
61-
<!--<version>1.6.3</version>-->
62-
<!--<extensions>true</extensions>-->
63-
<!--<configuration>-->
64-
<!--<serverId>ossrh</serverId>-->
65-
<!--<nexusUrl>https://oss.sonatype.org/</nexusUrl>-->
66-
<!--<stagingProfileId>22f8da536d8418</stagingProfileId> &lt;!&ndash;Staging&ndash;&gt;-->
67-
<!--&lt;!&ndash;<stagingProfileId>7edbe315063867</stagingProfileId> &lt;!&ndash;Central staging&ndash;&gt;&ndash;&gt;-->
68-
<!--<skipStagingRepositoryClose>true</skipStagingRepositoryClose>-->
69-
<!--<autoReleaseAfterClose>true</autoReleaseAfterClose>-->
70-
<!--</configuration>-->
71-
<!--</plugin>-->
58+
<plugin>
59+
<groupId>org.sonatype.plugins</groupId>
60+
<artifactId>nexus-staging-maven-plugin</artifactId>
61+
<version>1.6.3</version>
62+
<extensions>true</extensions>
63+
<configuration>
64+
<serverId>ossrh</serverId>
65+
<nexusUrl>https://oss.sonatype.org/</nexusUrl>
66+
<stagingProfileId>22f8da536d8418</stagingProfileId> <!--Staging-->
67+
<!--<stagingProfileId>7edbe315063867</stagingProfileId> &lt;!&ndash;Central staging&ndash;&gt;-->
68+
<skipStagingRepositoryClose>true</skipStagingRepositoryClose>
69+
<autoReleaseAfterClose>true</autoReleaseAfterClose>
70+
</configuration>
71+
</plugin>
7272

73-
<!--<plugin>-->
74-
<!--<groupId>org.apache.maven.plugins</groupId>-->
75-
<!--<artifactId>maven-source-plugin</artifactId>-->
76-
<!--<executions>-->
77-
<!--<execution>-->
78-
<!--<id>attach-sources</id>-->
79-
<!--<goals>-->
80-
<!--<goal>jar</goal>-->
81-
<!--</goals>-->
82-
<!--</execution>-->
83-
<!--</executions>-->
84-
<!--</plugin>-->
73+
<plugin>
74+
<groupId>org.apache.maven.plugins</groupId>
75+
<artifactId>maven-source-plugin</artifactId>
76+
<executions>
77+
<execution>
78+
<id>attach-sources</id>
79+
<goals>
80+
<goal>jar</goal>
81+
</goals>
82+
</execution>
83+
</executions>
84+
</plugin>
8585

86-
<!--<plugin>-->
87-
<!--<groupId>org.apache.maven.plugins</groupId>-->
88-
<!--<artifactId>maven-javadoc-plugin</artifactId>-->
89-
<!--<executions>-->
90-
<!--<execution>-->
91-
<!--<id>attach-javadocs</id>-->
92-
<!--<goals>-->
93-
<!--<goal>jar</goal>-->
94-
<!--</goals>-->
95-
<!--</execution>-->
96-
<!--</executions>-->
97-
<!--<configuration>-->
98-
<!--<additionalparam>-Xdoclint:none</additionalparam>-->
99-
<!--</configuration>-->
100-
<!--</plugin>-->
86+
<plugin>
87+
<groupId>org.apache.maven.plugins</groupId>
88+
<artifactId>maven-javadoc-plugin</artifactId>
89+
<executions>
90+
<execution>
91+
<id>attach-javadocs</id>
92+
<goals>
93+
<goal>jar</goal>
94+
</goals>
95+
</execution>
96+
</executions>
97+
<configuration>
98+
<additionalparam>-Xdoclint:none</additionalparam>
99+
</configuration>
100+
</plugin>
101101

102-
<!--</plugins>-->
103-
<!--</build>-->
102+
</plugins>
103+
</build>
104104

105105
<distributionManagement>
106106
<snapshotRepository>

‎readme.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ This is JAVA library for the running of mobile, web or API automated tests.
88
<dependency>
99
<groupId>net.itarray</groupId>
1010
<artifactId>automotion</artifactId>
11-
<version>1.4.0</version>
11+
<version>1.4.1</version>
1212
</dependency>
1313

1414
### Steps of adding to the project ###

‎src/main/java/util/validator/ResponsiveUIValidator.java‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -552,18 +552,20 @@ private void validateGridAlignment(int columns, int rows) {
552552
map.get(y).incrementAndGet();
553553
}
554554

555+
int mapSize = map.size();
555556
if (rows > 0) {
556-
if (map.size() != rows) {
557-
putJsonDetailsWithoutElement("Elements in a grid are not aligned properly. Looks like grid has wrong amount of rows. Expected is " + rows + ". Actual is " + map.size() + "");
557+
if (mapSize != rows) {
558+
putJsonDetailsWithoutElement("Elements in a grid are not aligned properly. Looks like grid has wrong amount of rows. Expected is " + rows + ". Actual is " + mapSize + "");
558559
}
559560
}
560561

561562
if (columns > 0) {
562563
int rowCount = 1;
563564
for (Map.Entry<Integer, AtomicLong> entry : map.entrySet()) {
564-
if (rowCount <= map.size()) {
565-
if (entry.getValue().intValue() != columns) {
566-
putJsonDetailsWithoutElement("Elements in a grid are not aligned properly in row #" + rowCount + ".");
565+
if (rowCount <= mapSize) {
566+
int actualInARow = entry.getValue().intValue();
567+
if (actualInARow != columns) {
568+
putJsonDetailsWithoutElement("Elements in a grid are not aligned properly in row #" + rowCount + ". Expected " + columns + " elements in a row. Actually it's " + actualInARow + "");
567569
}
568570
rowCount++;
569571
}

0 commit comments

Comments
 (0)