You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@raviks789 I remember that we found an issue which we didn't fix at the time this got introduced. I found this test in my stash. Is this nonsense or do you see what this is supposed to test?
@raviks789 I remember that we found an issue which we didn't fix at the time this got introduced. I found this test in my stash. Is this nonsense or do you see what this is supposed to test?
If I remember correctly, the case was if a navigation item already exists in icingadb-host-action but is not a shared item and the same navigation item is present in host-action as shared item, then only the filter needs to be transformed, instead of creating a new shared navigation item for icingadb-host-action. If I am understanding correctly the test is written for this case.
So I think this is a valid test case if the bug gets fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla/signedCLA is signed by all contributors of a PR
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.