Skip to content

Commit 05be8e6

Browse files
committed
add gh_actions modifications and remove existing outputs
1 parent d6153fa commit 05be8e6

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

.github/workflows/test_colab.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
for nb in part1_prerequisites part2_searching_basics part3_exploring_cohorts; do
9090
docker run -d --name colab -v "$(pwd):/content" -e GOOGLE_APPLICATION_CREDENTIALS="${{ env.GOOGLE_APPLICATION_CREDENTIALS }}" imagingdatacommons/idc-testing-colab:latest
9191
docker exec -t colab /bin/bash -c "pip install papermill"
92-
docker exec -t colab /bin/bash -c "set -o xtrace && set -o errexit && set -o pipefail && set -o nounset && set +o errexit && cd content/ && papermill /content/notebooks/getting_started/${nb}.ipynb /content/test/outputs/output_${nb}.ipynb && set -o errexit && ls -A"
92+
docker exec -t colab /bin/bash -c "set -o xtrace && set -o errexit && set -o pipefail && set -o nounset && set +o errexit && cd content/ && papermill /content/notebooks/getting_started/${nb}.ipynb /content/test/outputs/${nb}_papermill_output.ipynb && set -o errexit && ls -A"
9393
#docker exec -t colab /bin/bash -c "jupyter nbconvert --to html --ExtractOutputPreprocessor.enabled=False /content/test/outputs/output_${nb}.ipynb"
9494
docker stop colab
9595
docker rm colab
@@ -103,15 +103,15 @@ jobs:
103103
file_pattern: 'test/*.csv test/outputs/*.ipynb'
104104
branch: 'master'
105105

106-
- name: Check output notebooks for errors
107-
run: |
108-
for nb in part1_prerequisites part2_searching_basics part3_exploring_cohorts; do
109-
if grep -q '"name": "stderr"\|"status": "failed"' test/outputs/output_${nb}.ipynb; then
110-
echo "Error messages found in the ${nb} notebook output:"
111-
cat test/outputs/output_${nb}.ipynb
112-
exit 1
113-
else
114-
echo "No errors found in the ${nb} notebook output."
115-
fi
116-
done
117-
exit $EXIT_CODE
106+
#- name: Check output notebooks for errors
107+
# run: |
108+
# for nb in part1_prerequisites part2_searching_basics part3_exploring_cohorts; do
109+
# if grep -q '"name": "stderr"\|"status": "failed"' test/outputs/output_${nb}.ipynb; then
110+
# echo "Error messages found in the ${nb} notebook output:"
111+
# cat test/outputs/output_${nb}.ipynb
112+
# exit 1
113+
# else
114+
# echo "No errors found in the ${nb} notebook output."
115+
# fi
116+
# done
117+
# exit $EXIT_CODE

0 commit comments

Comments
 (0)