Selecting cell calls different SectionController's didSelect method

[benedekvarga]

New issue checklist

• [ ✅] I have reviewed the README and documentation
• [ ✅] I have searched existing issues and this is not a duplicate

General information

• IGListKit version: 3.4.0
• iOS version(s): 10-11-12
• CocoaPods/Carthage version:
• Xcode version: 10.0
• Devices/Simulators affected:
• Reproducible in the demo project? (Yes/No): No
• Related issues:

Hello everyone! 👋

I have a strange bug with my ListSectionController subclasses, or (which is more likely) I misunderstood something.
I have a UICollectionvVew with 4 different types of data. Thus I have 4 ListSectionController subclass, one for each type of section. One section's cells are needed to be clickable, so I can navigate to a new screen depending the data in the cell. I simply implement the didSelectItem(at index: Int) method in the proper subclass.

My problem is that the other type of sections seem to implement this same method. 🤔
Imagine you have A, B and C type of sections, with different types of cells. I want to navigate to a new screen if I click a cell in A section, and do nothing if I click in B or C. But instead If I click B's or C's cell the same method is called (WHICH IS ONLY IMPLEMENTED IN ASectionController 🤯😡) and I navigate to a new screen. (Cell click in A works fine though...)

I cannot understand this issue, please help me how can I fix that? I think it's in connection with that the collectionView reuses cells maybe.

Any andvice is welcomed! 🙌🏻

[kwstasna]

Could you send some of the code so we can see it ?

[benedekvarga]

@kwstasna Thanks, let me know if you need more code!

Section Controller:

import UIKit
import IGListKit
import RealmSwift
class TransactionSectionController: ListSectionController {
    var transaction: TransactionListElement!
    override init() {
        super.init()
        inset = UIEdgeInsets(top: 0, left: 0, bottom: 0, right: 0)
    }
    override func didUpdate(to object: Any) {
        transaction = object as? TransactionListElement
    }
    override func sizeForItem(at index: Int) -> CGSize {
        return CGSize(width: collectionContext!.containerSize.width, height: 64)
    }
    override func cellForItem(at index: Int) -> UICollectionViewCell {
        guard let cell = collectionContext?.dequeueReusableCell(of: TransactionCell.self, for: self, at: index) as? TransactionCell else { return .init() }
        let value = NSNumber(value: transaction.value).formattedNumericString + " " + (transaction.currency?.isocode)!
        cell.configure(title: transaction.tagsReadable, subtitle: transaction.categoryReadable, value: value, image: transaction.icon, color: transaction.color)
        return cell
    }
    override func numberOfItems() -> Int {
        return 1
    }
    override func didSelectItem(at index: Int) {
        guard let vc = viewController as? DashboardViewController else {
            logger("FAIL")
            fatalError()
        }
        do {
            let realm = try Realm()
            let transaction = realm.objects(Transaction.self).filter("id == %@", self.transaction.id)
            let tr = transaction.toArray()[0]
            vc.viewModel.editTransactionAction.execute(tr)
        } catch let error {
            logger(error.localizedDescription)
        }
    }
}

ViewController

import UIKit
import RxSwift
import RxCocoa
import RxDataSources
import RxGesture
import Action
import IGListKit
final class DashboardViewController: UIViewController, BindableType {
    // ...
    var dashboardList: [ListDiffable] = []
    lazy var adapter: ListAdapter = {
        return ListAdapter(updater: ListAdapterUpdater(), viewController: self, workingRangeSize: 0)
    }()

    override func viewDidLoad() {
        super.viewDidLoad()
        automaticallyAdjustsScrollViewInsets = true
        adapter.collectionView = myView.collectionView
        adapter.dataSource = self
    }

    // MARK: - Binds
    func bindViewModel() {
        bindButtons()
        bindLists()
    }

    private func bindLists() {
        viewModel.dashboardList
            .subscribe(onNext: { list in
                self.dashboardList = list
                self.adapter.performUpdates(animated: true)
            })
            .disposed(by: rx.disposeBag)
    }
}

extension DashboardViewController: ListAdapterDataSource {
    func objects(for listAdapter: ListAdapter) -> [ListDiffable] {
        return dashboardList
    }
    func listAdapter(_ listAdapter: ListAdapter, sectionControllerFor object: Any) -> ListSectionController {
        if object is SmartCardListElement {
            return SmartCardSectionController()
        } else if object is TransactionListElement {
            return TransactionSectionController()
        } else if object is TaskListElement {
            return EndingTaskSectionController()
        } else if object is AccountHeaderList {
            return DashboardHeaderSectionController()
        } else {
            return .init()
        }
    }
    func emptyView(for listAdapter: ListAdapter) -> UIView? {
        return nil
    }
- }

_{Sent with GitHawk}

[kwstasna]

First of all normally i would not user numberOfItems but apart from that could you download the Examples folder from this repo and go to

ExpendableSectionController.swift

and replace the function didSelectItem with the following code?

    override func didSelectItem(at index: Int) {
        let storyboard = UIStoryboard(name: "Demo", bundle: nil)
        let controller = storyboard.instantiateViewController(withIdentifier: "singleSectionDemo")
        controller.title = "Single Selection"
        viewController?.navigationController?.pushViewController(controller, animated: true)
    }

And see that the MixedDataViewController has multiple SectionControllers and with the code above only when you press the Expandable section controller, it transitions to new VC.
So look close at the implementation and test it at your code. Cause at a first look i can't see anything wrong at your code, but maybe we are missing something!

[benedekvarga]

First of all normally i would not user numberOfItems but apart from that could you download the Examples folder from this repo and go to ...

@kwstasna Maybe I should do cell type check like guard let cell = collectionContext?.cellForItem...

_{Sent with GitHawk}

[benedekvarga]

First of all normally i would not user numberOfItems but apart from that could you download the Examples folder from this repo and go to ...

@kwstasna Why shouldn’t I use the numberOfItems()... method oberride? 🤔

_{Sent with GitHawk}

[kwstasna]

@benedekvarga I guess it's being calculated itself? anyway. Normally you wouldn't have to check for cell type etc. Did you tried the example project with the code that i sended?