Skip to content

Commit 5c1e40d

Browse files
authored
Fix deprecated version for actions and remove unsupported platforms
- Updates actions/upload-artifact from v2 to v4 - Updates actions/checkout from v2 to v3 - Updates pre-commit/action to v3.0.1 - Removed Mac-OS and Ubuntu20.04
1 parent 18250db commit 5c1e40d

File tree

1 file changed

+5
-61
lines changed

1 file changed

+5
-61
lines changed

.github/workflows/github-ci.yml

Lines changed: 5 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ jobs:
4545
name: Format
4646
runs-on: ubuntu-22.04
4747
steps:
48-
- uses: actions/checkout@v2
48+
- uses: actions/checkout@v3
4949
# Required for pre-commit
5050
- run: pip3 install cpplint==1.5.5
5151
# NOTE: This is deprecated in favor of pre-commit.ci
52-
- uses: pre-commit/action@v2.0.2
52+
- uses: pre-commit/action@v3.0.1
5353
with:
5454
extra_args: --all-files
5555

@@ -64,10 +64,7 @@ jobs:
6464
strategy:
6565
matrix:
6666
# removed platforms not available on github hosted servers.
67-
# sel-fhosted ice-lake servers not enabled by sysadmin
68-
# os: [ice-lake, [self-hosted, ubuntu-18.04], macos-latest, ubuntu-20.04]
69-
# os: [macos-latest, ubuntu-20.04]
70-
os: [macos-latest, ubuntu-22.04]
67+
os: [ubuntu-22.04]
7168
build_type: [Release, Debug]
7269
shared_lib: [ON, OFF]
7370
include:
@@ -76,9 +73,6 @@ jobs:
7673
benchmark_min_time: "--benchmark_min_time=0.001"
7774
- build_type: Release
7875
benchmark_min_time: ""
79-
exclude: # Skip debug on Mac. TODO: add Debug mode
80-
- os: macos-latest
81-
build_type: Debug
8276
steps:
8377
- uses: actions/checkout@v2
8478
- name: Setup cmake
@@ -142,9 +136,9 @@ jobs:
142136
# set +x
143137
144138
- name: Archive benchmark results
145-
uses: actions/upload-artifact@v2
139+
uses: actions/upload-artifact@v4
146140
with:
147-
name: bench_hexl_${{github.sha}}.csv
141+
name: bench_hexl_${{github.sha}}_${{github.run_id}}_${{github.job}}_${{matrix.os}}_${{matrix.build_type}}_Shared_${{matrix.shared_lib}}
148142
path: ${{ github.workspace }}/${{ github.workflow }}_${{ github.sha }}
149143
retention-days: 90 # Maximum for free version
150144

@@ -182,53 +176,3 @@ jobs:
182176
build/${{ matrix.build_type}}/example.exe
183177
184178
# TODO: add pkgconfig and vcpkg examples
185-
186-
experimental-build:
187-
name: 'experimental: ${{ matrix.os }} ${{ matrix.build_type }} shared=${{ matrix.shared_lib }}'
188-
runs-on: '${{ matrix.os }}'
189-
defaults:
190-
run:
191-
shell: bash
192-
strategy:
193-
matrix:
194-
# This is an unsupported experimental build - use at your own risk
195-
#
196-
# Ice-lake platform not available on github
197-
# self-hosted platforms disabled by Intel github sys admin
198-
# building on default ubuntu-20.04 platform
199-
# os: [ice-lake]
200-
os: [ubuntu-20.04]
201-
build_type: [Release]
202-
shared_lib: [ON]
203-
steps:
204-
- uses: actions/checkout@v2
205-
- name: Default build
206-
run: |
207-
set -x
208-
if [ "$RUNNER_OS" == "Linux" ]; then
209-
export CC=clang-11
210-
export CXX=clang++-11
211-
fi
212-
213-
# Print information useful for debugging
214-
whoami
215-
echo $HOME
216-
echo $GITHUB_WORKSPACE
217-
echo "Testing from branch:"
218-
echo $GITHUB_REFH
219-
cmake --version
220-
pwd
221-
222-
# Build library
223-
cmake -S . -B build -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \
224-
-DHEXL_SHARED_LIB=${{ matrix.shared_lib }} \
225-
-DCMAKE_INSTALL_PREFIX=./ \
226-
-DHEXL_EXPERIMENTAL=ON
227-
cmake --build build -j
228-
cmake --build build --target install
229-
cmake --build build --target unittest
230-
# Instead of calling cmake --build build --target bench,
231-
# we run the executable directly to pass command-line arguments
232-
./build/benchmark/bench_hexl \
233-
--benchmark_out="${GITHUB_WORKFLOW}_${GITHUB_SHA}" \
234-
--benchmark_out_format=csv

0 commit comments

Comments
 (0)