Skip to content

Commit 68103fe

Browse files
committed
address review comments
1 parent b5177a4 commit 68103fe

File tree

1 file changed

+19
-26
lines changed

1 file changed

+19
-26
lines changed

dpnp/dpnp_iface_logic.py

Lines changed: 19 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1169,24 +1169,27 @@ def isfortran(a):
11691169
def isin(element, test_elements, assume_unique=False, invert=False):
11701170
"""
11711171
Calculates ``element in test_elements``, broadcasting over `element` only.
1172-
Returns a boolean array of the same shape as `element` that is True
1173-
where an element of `element` is in `test_elements` and False otherwise.
1172+
Returns a boolean array of the same shape as `element` that is ``True``
1173+
where an element of `element` is in `test_elements` and ``False``
1174+
otherwise.
1175+
1176+
For full documentation refer to :obj:`numpy.isin`.
11741177
11751178
Parameters
11761179
----------
1177-
element : {array_like, dpnp.ndarray, usm_ndarray}
1180+
element : {dpnp.ndarray, usm_ndarray, scalar}
11781181
Input array.
1179-
test_elements : {array_like, dpnp.ndarray, usm_ndarray}
1182+
test_elements : {dpnp.ndarray, usm_ndarray, scalar}
11801183
The values against which to test each value of `element`.
1181-
This argument is flattened if it is an array or array_like.
1182-
See notes for behavior with non-array-like parameters.
1184+
This argument is flattened if it is an array.
11831185
assume_unique : bool, optional
11841186
Ignored
11851187
invert : bool, optional
1186-
If True, the values in the returned array are inverted, as if
1187-
calculating `element not in test_elements`. Default is False.
1188+
If ``True``, the values in the returned array are inverted, as if
1189+
calculating `element not in test_elements`.
11881190
``dpnp.isin(a, b, invert=True)`` is equivalent to (but faster
11891191
than) ``dpnp.invert(dpnp.isin(a, b))``.
1192+
Default: ``False``.
11901193
11911194
11921195
Returns
@@ -1228,28 +1231,18 @@ def isin(element, test_elements, assume_unique=False, invert=False):
12281231
"""
12291232

12301233
dpnp.check_supported_arrays_type(element, test_elements, scalar_type=True)
1231-
if dpnp.isscalar(element):
1232-
usm_element = dpt.asarray(
1233-
element,
1234-
sycl_queue=test_elements.sycl_queue,
1235-
usm_type=test_elements.usm_type,
1236-
)
1237-
usm_test = dpnp.get_usm_ndarray(test_elements)
1238-
elif dpnp.isscalar(test_elements):
1239-
usm_test = dpt.asarray(
1240-
test_elements,
1241-
sycl_queue=element.sycl_queue,
1242-
usm_type=element.usm_type,
1243-
)
1244-
usm_element = dpnp.get_usm_ndarray(element)
1245-
else:
1246-
usm_element = dpnp.get_usm_ndarray(element)
1247-
usm_test = dpnp.get_usm_ndarray(test_elements)
1234+
usm_element = dpnp.as_usm_ndarray(
1235+
element, usm_type=element.usm_type, sycl_queue=element.sycl_queue
1236+
)
1237+
usm_test = dpnp.as_usm_ndarray(
1238+
test_elements,
1239+
usm_type=test_elements.usm_type,
1240+
sycl_queue=test_elements.sycl_queue,
1241+
)
12481242
return dpnp.get_result_array(
12491243
dpt.isin(
12501244
usm_element,
12511245
usm_test,
1252-
assume_unique=assume_unique,
12531246
invert=invert,
12541247
)
12551248
)

0 commit comments

Comments
 (0)