Move definition of _result_typeid to the header to avoid undefined reference issue

Author: antonwolfy

dpnp/backend/extensions/elementwise_functions/elementwise_functions.hpp

@@ -62,6 +62,8 @@ namespace td_ns = dpctl::tensor::type_dispatch;
 using dpctl::tensor::kernels::alignment_utils::is_aligned;
 using dpctl::tensor::kernels::alignment_utils::required_alignment;
 
+using type_utils::_result_typeid;
+
 /*! @brief Template implementing Python API for unary elementwise functions */
 template <typename output_typesT,
           typename contig_dispatchT,
@@ -261,9 +263,7 @@ py::object py_unary_ufunc_result_type(const py::dtype &input_dtype,
         throw py::value_error(e.what());
     }
 
-    using type_utils::_result_typeid;
     int dst_typeid = _result_typeid(src_typeid, output_types);
-
     if (dst_typeid < 0) {
         auto res = py::none();
         return py::cast<py::object>(res);
@@ -511,7 +511,6 @@ std::pair<py::object, py::object>
         throw py::value_error(e.what());
     }
 
-    using type_utils::_result_typeid;
     std::pair<int, int> dst_typeids = _result_typeid(src_typeid, output_types);
     int dst1_typeid = dst_typeids.first;
     int dst2_typeid = dst_typeids.second;

dpnp/backend/extensions/elementwise_functions/elementwise_functions_type_utils.cpp

@@ -37,11 +37,11 @@
 // dpctl tensor headers
 #include "utils/type_dispatch.hpp"
 
+namespace dpnp::extensions::py_internal::type_utils
+{
 namespace py = pybind11;
 namespace td_ns = dpctl::tensor::type_dispatch;
 
-namespace dpnp::extensions::py_internal::type_utils
-{
 py::dtype _dtype_from_typenum(td_ns::typenum_t dst_typenum_t)
 {
     switch (dst_typenum_t) {
@@ -77,15 +77,4 @@ py::dtype _dtype_from_typenum(td_ns::typenum_t dst_typenum_t)
         throw py::value_error("Unrecognized dst_typeid");
     }
 }
-
-template <typename output_idT>
-output_idT _result_typeid(int arg_typeid, const output_idT *fn_output_id)
-{
-    if (arg_typeid < 0 || arg_typeid >= td_ns::num_types) {
-        throw py::value_error("Input typeid " + std::to_string(arg_typeid) +
-                              " is outside of expected bounds.");
-    }
-
-    return fn_output_id[arg_typeid];
-}
 } // namespace dpnp::extensions::py_internal::type_utils

dpnp/backend/extensions/elementwise_functions/elementwise_functions_type_utils.hpp

@@ -47,6 +47,13 @@ extern py::dtype _dtype_from_typenum(td_ns::typenum_t);
 /*! @brief Lookup typeid of the result from typeid of
  *         argument and the mapping table */
 template <typename output_idT>
-extern output_idT _result_typeid(int arg_typeid,
-                                 const output_idT *fn_output_id);
+output_idT _result_typeid(int arg_typeid, const output_idT *fn_output_id)
+{
+    if (arg_typeid < 0 || arg_typeid >= td_ns::num_types) {
+        throw py::value_error("Input typeid " + std::to_string(arg_typeid) +
+                              " is outside of expected bounds.");
+    }
+
+    return fn_output_id[arg_typeid];
+}
 } // namespace dpnp::extensions::py_internal::type_utils