From 28d68a4a020d59a642ad1a554de052d7b855fb83 Mon Sep 17 00:00:00 2001 From: Martin Kourim Date: Thu, 19 Mar 2026 10:05:02 +0100 Subject: [PATCH] feat(scripts): print usage messages to stderr on invalid arguments Redirect usage output to stderr in run_tests.sh, build_and_link_node_bins.sh, and update_node_bins.sh when invoked due to invalid arguments. This improves error visibility and aligns with standard CLI practices. --- .github/run_tests.sh | 2 +- scripts/build_and_link_node_bins.sh | 2 +- scripts/update_node_bins.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/run_tests.sh b/.github/run_tests.sh index bb5c42a0c..6672f7060 100755 --- a/.github/run_tests.sh +++ b/.github/run_tests.sh @@ -221,7 +221,7 @@ main() { testpr) shift; target_testpr "$@";; testnets) shift; target_testnets "$@";; -h|--help) usage;; - *) echo "Unknown target: $cmd" >&2; usage; exit 2;; + *) echo "Unknown target: $cmd" >&2; usage >&2; exit 2;; esac } diff --git a/scripts/build_and_link_node_bins.sh b/scripts/build_and_link_node_bins.sh index 3d71f9fd0..da0fc844a 100755 --- a/scripts/build_and_link_node_bins.sh +++ b/scripts/build_and_link_node_bins.sh @@ -18,7 +18,7 @@ usage() { } if [ $# -ne 3 ]; then - usage + usage >&2 exit 2 fi diff --git a/scripts/update_node_bins.sh b/scripts/update_node_bins.sh index 80dfec5c3..d46c0ba50 100755 --- a/scripts/update_node_bins.sh +++ b/scripts/update_node_bins.sh @@ -10,7 +10,7 @@ set -euo pipefail usage() { printf "Usage: %s /path/to/cardano-node-repo\n" "${0}"; } if [ $# -ne 1 ]; then - usage + usage >&2 exit 2 fi REPO_PATH="$(readlink -m "$1")"